From: Namjae Jeon <linkinjeon@kernel.org>
To: Stefan Metzmacher <metze@samba.org>
Cc: linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
Steve French <smfrench@gmail.com>, Tom Talpey <tom@talpey.com>
Subject: Re: [PATCH] smb: server: let free_transport() wait for SMBDIRECT_SOCKET_DISCONNECTED
Date: Thu, 16 Oct 2025 10:39:29 +0900 [thread overview]
Message-ID: <CAKYAXd-qN17m=CCnyUksiZZD0F7221kFh9xpV0FhRk8hSQiNgQ@mail.gmail.com> (raw)
In-Reply-To: <20251015150527.1109622-1-metze@samba.org>
On Thu, Oct 16, 2025 at 12:05 AM Stefan Metzmacher <metze@samba.org> wrote:
>
> We should wait for the rdma_cm to become SMBDIRECT_SOCKET_DISCONNECTED!
>
> At least on the client side (with similar code)
> wait_event_interruptible() often returns with -ERESTARTSYS instead of
> waiting for SMBDIRECT_SOCKET_DISCONNECTED.
> We should use wait_event() here too, which makes the code be identical
> in client and server, which will help when moving to common functions.
>
> Fixes: b31606097de8 ("smb: server: move smb_direct_disconnect_rdma_work() into free_transport()")
> Cc: Namjae Jeon <linkinjeon@kernel.org>
> Cc: Steve French <smfrench@gmail.com>
> Cc: Tom Talpey <tom@talpey.com>
> Cc: linux-cifs@vger.kernel.org
> Cc: samba-technical@lists.samba.org
> Signed-off-by: Stefan Metzmacher <metze@samba.org>
Applied it to #ksmbd-for-next-next.
Thanks!
prev parent reply other threads:[~2025-10-16 1:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-15 15:05 [PATCH] smb: server: let free_transport() wait for SMBDIRECT_SOCKET_DISCONNECTED Stefan Metzmacher
2025-10-16 1:39 ` Namjae Jeon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKYAXd-qN17m=CCnyUksiZZD0F7221kFh9xpV0FhRk8hSQiNgQ@mail.gmail.com' \
--to=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=metze@samba.org \
--cc=samba-technical@lists.samba.org \
--cc=smfrench@gmail.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).