From: Namjae Jeon <linkinjeon@kernel.org>
To: Stefan Metzmacher <metze@samba.org>
Cc: Steve French <smfrench@gmail.com>, linux-cifs@vger.kernel.org
Subject: Re: [PATCH] MAINTAINERS: change git.samba.org to https
Date: Sat, 29 Nov 2025 07:35:05 +0900 [thread overview]
Message-ID: <CAKYAXd9CouGFSOjFCL3gk=tggsX7r02wcs8XkzOdxM0XJ93NHQ@mail.gmail.com> (raw)
In-Reply-To: <e67a626a-828a-434d-8921-4bd8fcaeabcb@samba.org>
You should first buy a Mellanox connectX series NIC. That's what most
people use. ksmbd rdma is actually having issues with Windows client +
connectX-7 after applying your work. This is what I was most worried
about when you started this, and the patches are so fucking chopped up
that they're hard to find. I'm absolutely against splitting the
smbdirect section, and every time you unilaterally apply something to
smbdirect.ko, it affects ksmbd rdma.
Thanks.
On Sat, Nov 29, 2025 at 3:51 AM Stefan Metzmacher <metze@samba.org> wrote:
>
> Am 28.11.25 um 19:15 schrieb Steve French:
> > ok - this change seems harmless. I also want to look at way to add
> > you to MAINTAINERS to make clear you are "expert" at RDMA/SMBDIRECT
> > and either reviewer or co-maintainer for smb client/server/common more
> > generally. Wanted to look at a few other examples in MAINTAINERS and
> > compare
>
> I compared things like
> NETWORKING [GENERAL]
> and
> NETWORKING [SOCKETS]
>
> They are 2 sections, but some files overlab.
>
> scripts/get_maintainer.pl include/net/sock.h
> Eric Dumazet <edumazet@google.com> (maintainer:NETWORKING [SOCKETS])
> Kuniyuki Iwashima <kuniyu@google.com> (maintainer:NETWORKING [SOCKETS])
> Paolo Abeni <pabeni@redhat.com> (maintainer:NETWORKING [SOCKETS])
> Willem de Bruijn <willemb@google.com> (maintainer:NETWORKING [SOCKETS])
> "David S. Miller" <davem@davemloft.net> (maintainer:NETWORKING [GENERAL])
> Jakub Kicinski <kuba@kernel.org> (maintainer:NETWORKING [GENERAL])
> Simon Horman <horms@kernel.org> (reviewer:NETWORKING [GENERAL])
> netdev@vger.kernel.org (open list:NETWORKING [GENERAL])
> linux-kernel@vger.kernel.org (open list)
>
> And I think we might want an additional section that covers
> F: fs/smb/common/smbdirect/
> F: fs/smb/client/smbdirect.*
> F: fs/smb/server/transport_rdma.*
>
> That way the maintainers for the smbdirect section will appear
> first followed by the more general results.
>
> I first thought to have excludes for fs/smb/common/smbdirect/
> in the cifs.ko and ksmbd.ko sections, but we can leave that out
> and just let it overlab.
>
> > On Fri, Nov 28, 2025 at 12:00 PM Stefan Metzmacher <metze@samba.org> wrote:
> >>
> >> Am 28.11.25 um 18:48 schrieb Steve French:
> >>> On Fri, Nov 28, 2025 at 7:49 AM Stefan Metzmacher <metze@samba.org> wrote:
> >>>>
> >>>> This is the preferred way to access the server.
> >>>
> >>> Are you sure that is the preferred way? 75% of the entries in
> >>> MAINTAINERS use "git git://" not "git http://" but ... I did notice
> >>> that for all github and gitlab ones they use "git http://"
> >>
> >> It seems a lot of them were created long time ago.
> >>
> >>> But maybe for samba.org there is an advantage to https?!
> >>
> >> Yes, the admins of git.samba.org prefer that clients use https://
> >> instead of git://
> >>
> >> I also checked what linux-net uses and it also uses https most of the time:
> >>
> >> $ git lo -187 linux-next/master | grep 'Merge branch .*\/\/'| grep https | wc -l
> >> 178
> >> $ git lo -187 linux-next/master | grep 'Merge branch .*\/\/'| grep -v https | cut -d ' ' -f2-
> >> Merge branch 'main' of git://git.infradead.org/users/willy/xarray.git
> >> Merge branch 'master' of git://www.linux-watchdog.org/linux-watchdog-next.git
> >> Merge branch 'master' of git://git.code.sf.net/p/tomoyo/tomoyo.git
> >> Merge branch 'next' of git://linuxtv.org/media-ci/media-pending.git
> >> Merge branch 'docs-next' of git://git.lwn.net/linux.git
> >> Merge branch 'master' of git://git.kernel.org/pub/scm/virt/kvm/kvm.git
> >>
> >> metze
> >
> >
> >
>
next prev parent reply other threads:[~2025-11-28 22:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-28 13:49 [PATCH] MAINTAINERS: change git.samba.org to https Stefan Metzmacher
2025-11-28 17:48 ` Steve French
2025-11-28 18:00 ` Stefan Metzmacher
2025-11-28 18:15 ` Steve French
2025-11-28 18:51 ` Stefan Metzmacher
2025-11-28 22:35 ` Namjae Jeon [this message]
2026-04-15 13:54 ` Stefan Metzmacher
2026-04-15 22:59 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKYAXd9CouGFSOjFCL3gk=tggsX7r02wcs8XkzOdxM0XJ93NHQ@mail.gmail.com' \
--to=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=metze@samba.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).