From: Pavel Shilovsky <piastryyy@gmail.com>
To: Daniel Parks <danielrparks@ti.com>
Cc: linux-cifs@vger.kernel.org, Steve French <smfrench@gmail.com>
Subject: Re: [PATCH] cifs-utils: Make automake treat /sbin as exec, not data
Date: Mon, 25 Mar 2024 18:18:49 -0700 [thread overview]
Message-ID: <CAKywueTOwZDtArbHFddkTdUROgVGd-Q9EP9pBuFKSQYXPdBf5A@mail.gmail.com> (raw)
In-Reply-To: <20220603203459.21422-1-danielrparks@ti.com>
Merged into the next branch. Sorry, I somehow missed this patch before.
--
Best regards,
Pavel Shilovsky
вс, 5 июн. 2022 г. в 22:05, Daniel Parks <danielrparks@ti.com>:
>
> Otherwise, $(DESTDIR)/sbin doesn't get created until install-data on a
> -j1 build and install-exec-hook can fail because it might not exist.
>
> Steps to reproduce this bug:
> $ autoreconf -i
> $ ./configure
> $ mkdir image
> $ make DESTDIR=image install -j1
>
> Signed-off-by: Daniel Parks <danielrparks@ti.com>
> ---
> Makefile.am | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile.am b/Makefile.am
> index 84dd119..b1444f6 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -1,8 +1,8 @@
> AM_CFLAGS = -Wall -Wextra -D_FORTIFY_SOURCE=2 $(PIE_CFLAGS) $(RELRO_CFLAGS)
> ACLOCAL_AMFLAGS = -I aclocal
>
> -root_sbindir = $(ROOTSBINDIR)
> -root_sbin_PROGRAMS = mount.cifs
> +root_exec_sbindir = $(ROOTSBINDIR)
> +root_exec_sbin_PROGRAMS = mount.cifs
> mount_cifs_SOURCES = mount.cifs.c mtab.c resolve_host.c util.c
> mount_cifs_LDADD = $(LIBCAP) $(CAPNG_LDADD) $(RT_LDADD)
> include_HEADERS = cifsidmap.h
> --
> 2.17.1
>
prev parent reply other threads:[~2024-03-26 1:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 20:34 [PATCH] cifs-utils: Make automake treat /sbin as exec, not data Daniel Parks
2024-03-26 1:18 ` Pavel Shilovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKywueTOwZDtArbHFddkTdUROgVGd-Q9EP9pBuFKSQYXPdBf5A@mail.gmail.com \
--to=piastryyy@gmail.com \
--cc=danielrparks@ti.com \
--cc=linux-cifs@vger.kernel.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).