From: Markus Elfring <Markus.Elfring@web.de>
To: linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
Bharath SM <bharathsm@microsoft.com>,
Boris Protopopov <bprotopopov@hotmail.com>,
Paulo Alcantara <pc@manguebit.org>,
Ronnie Sahlberg <ronniesahlberg@gmail.com>,
Shyam Prasad N <sprasad@microsoft.com>,
Steve French <sfrench@samba.org>, Tom Talpey <tom@talpey.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH] smb: client: Delete duplicate error code assignments in cifs_xattr_set()
Date: Fri, 10 Oct 2025 14:28:13 +0200 [thread overview]
Message-ID: <ecbc86ff-4556-4446-8205-066b633dbe40@web.de> (raw)
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 10 Oct 2025 14:10:22 +0200
The local variable “rc” is initialised with an error code.
Thus omit two repeated assignment statements according to this value.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
fs/smb/client/xattr.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/fs/smb/client/xattr.c b/fs/smb/client/xattr.c
index b88fa04f5792..a74d12d36176 100644
--- a/fs/smb/client/xattr.c
+++ b/fs/smb/client/xattr.c
@@ -127,7 +127,6 @@ static int cifs_xattr_set(const struct xattr_handler *handler,
returns as xattrs */
if (size > MAX_EA_VALUE_SIZE) {
cifs_dbg(FYI, "size of EA value too large\n");
- rc = -EOPNOTSUPP;
goto out;
}
@@ -206,8 +205,6 @@ static int cifs_xattr_set(const struct xattr_handler *handler,
rc = pTcon->ses->server->ops->set_acl(pacl,
size, inode, full_path, aclflags);
- } else {
- rc = -EOPNOTSUPP;
}
if (rc == 0) /* force revalidate of the inode */
CIFS_I(inode)->time = 0;
--
2.51.0
reply other threads:[~2025-10-10 12:28 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecbc86ff-4556-4446-8205-066b633dbe40@web.de \
--to=markus.elfring@web.de \
--cc=bharathsm@microsoft.com \
--cc=bprotopopov@hotmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pc@manguebit.org \
--cc=ronniesahlberg@gmail.com \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=sprasad@microsoft.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).