From: neil.armstrong@linaro.org
To: Krzysztof Kozlowski <krzk@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: qcom: fix module autoloading
Date: Wed, 10 Apr 2024 17:55:52 +0200 [thread overview]
Message-ID: <0a93713a-efd4-4b9a-b9e0-50631cb69e2d@linaro.org> (raw)
In-Reply-To: <20240410155356.224098-1-krzk@kernel.org>
On 10/04/2024 17:53, Krzysztof Kozlowski wrote:
> Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded
> based on the alias from of_device_id table. Clocks are considered core
> components, so usually they are built-in, however these can be built and
> used as modules on some generic kernel.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/clk/qcom/gcc-msm8917.c | 1 +
> drivers/clk/qcom/gcc-msm8953.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/clk/qcom/gcc-msm8917.c b/drivers/clk/qcom/gcc-msm8917.c
> index f2dd132e2fb1..f2b8729e4198 100644
> --- a/drivers/clk/qcom/gcc-msm8917.c
> +++ b/drivers/clk/qcom/gcc-msm8917.c
> @@ -3278,6 +3278,7 @@ static const struct of_device_id gcc_msm8917_match_table[] = {
> { .compatible = "qcom,gcc-qm215", .data = &gcc_qm215_desc },
> {},
> };
> +MODULE_DEVICE_TABLE(of, gcc_msm8917_match_table);
>
> static struct platform_driver gcc_msm8917_driver = {
> .probe = gcc_msm8917_probe,
> diff --git a/drivers/clk/qcom/gcc-msm8953.c b/drivers/clk/qcom/gcc-msm8953.c
> index 68359534ff25..7563bff58118 100644
> --- a/drivers/clk/qcom/gcc-msm8953.c
> +++ b/drivers/clk/qcom/gcc-msm8953.c
> @@ -4227,6 +4227,7 @@ static const struct of_device_id gcc_msm8953_match_table[] = {
> { .compatible = "qcom,gcc-msm8953" },
> {},
> };
> +MODULE_DEVICE_TABLE(of, gcc_msm8953_match_table);
>
> static struct platform_driver gcc_msm8953_driver = {
> .probe = gcc_msm8953_probe,
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
next prev parent reply other threads:[~2024-04-10 15:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 15:53 [PATCH] clk: qcom: fix module autoloading Krzysztof Kozlowski
2024-04-10 15:55 ` neil.armstrong [this message]
2024-04-10 17:57 ` Konrad Dybcio
2024-04-12 1:27 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a93713a-efd4-4b9a-b9e0-50631cb69e2d@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=andersson@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).