From: Jerome Brunet <jbrunet@baylibre.com>
To: Jan Dakinevich <jan.dakinevich@salutedevices.com>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
Jerome Brunet <jbrunet@baylibre.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Kevin Hilman <khilman@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Jiucheng Xu <jiucheng.xu@amlogic.com>,
linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH v3 3/6] clk: meson: axg: introduce AUD_MUX_TABLE() helper macro
Date: Mon, 22 Apr 2024 10:09:04 +0200 [thread overview]
Message-ID: <1jv849akel.fsf@starbuckisacylon.baylibre.com> (raw)
In-Reply-To: <20240419125812.983409-4-jan.dakinevich@salutedevices.com>
On Fri 19 Apr 2024 at 15:58, Jan Dakinevich <jan.dakinevich@salutedevices.com> wrote:
> This macro takes into account ->table property of
> 'struct clk_regmap_mux_data'.
Useless if the interface of controller is fixed.
>
> Signed-off-by: Jan Dakinevich <jan.dakinevich@salutedevices.com>
> ---
> drivers/clk/meson/meson-audio.h | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/clk/meson/meson-audio.h b/drivers/clk/meson/meson-audio.h
> index cbcdbd487d4a..1947c6cbf233 100644
> --- a/drivers/clk/meson/meson-audio.h
> +++ b/drivers/clk/meson/meson-audio.h
> @@ -17,9 +17,11 @@
> }, \
> }
>
> -#define AUD_MUX(_name, _reg, _mask, _shift, _dflags, _pdata, _iflags) { \
> +#define AUD_MUX_TABLE(_name, _reg, _table, _mask, _shift, _dflags, \
> + _pdata, _iflags) { \
> .data = &(struct clk_regmap_mux_data){ \
> .offset = (_reg), \
> + .table = (_table), \
> .mask = (_mask), \
> .shift = (_shift), \
> .flags = (_dflags), \
> @@ -33,6 +35,10 @@
> }, \
> }
>
> +#define AUD_MUX(_name, _reg, _mask, _shift, _dflags, _pdata, _iflags) \
> + AUD_MUX_TABLE(_name, (_reg), NULL, (_mask), (_shift), \
> + (_dflags), (_pdata), (_iflags))
> +
> #define AUD_DIV(_name, _reg, _shift, _width, _dflags, _pname, _iflags) { \
> .data = &(struct clk_regmap_div_data){ \
> .offset = (_reg), \
--
Jerome
next prev parent reply other threads:[~2024-04-22 8:09 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 12:58 [RFC PATCH v3 0/6] Add A1 Soc audio clock controller driver Jan Dakinevich
2024-04-19 12:58 ` [RFC PATCH v3 1/6] reset: reset-meson-audio: introduce separate driver Jan Dakinevich
2024-04-22 7:46 ` Jerome Brunet
2024-05-14 18:33 ` Jan Dakinevich
2024-04-19 12:58 ` [RFC PATCH v3 2/6] clk: meson: axg: share the set of audio helper macro Jan Dakinevich
2024-04-19 12:58 ` [RFC PATCH v3 3/6] clk: meson: axg: introduce AUD_MUX_TABLE() " Jan Dakinevich
2024-04-22 8:09 ` Jerome Brunet [this message]
2024-04-19 12:58 ` [RFC PATCH v3 4/6] dt-bindings: clock: meson: document A1 SoC audio clock controller driver Jan Dakinevich
2024-04-19 14:06 ` Krzysztof Kozlowski
2024-04-20 14:48 ` Jan Dakinevich
2024-04-21 14:02 ` Krzysztof Kozlowski
2024-04-21 15:35 ` Jan Dakinevich
2024-04-21 18:17 ` Krzysztof Kozlowski
2024-04-22 7:43 ` Jerome Brunet
2024-04-19 16:44 ` Rob Herring
2024-04-19 21:09 ` Rob Herring
2024-04-20 16:15 ` Jan Dakinevich
2024-04-21 18:14 ` Krzysztof Kozlowski
2024-04-21 21:03 ` Jan Dakinevich
2024-04-22 7:16 ` Jerome Brunet
2024-04-22 7:57 ` Jerome Brunet
2024-04-22 14:31 ` Jan Dakinevich
2024-04-22 15:38 ` Jerome Brunet
2024-04-22 15:43 ` Jan Dakinevich
2024-04-22 7:40 ` Jerome Brunet
2024-04-19 12:58 ` [RFC PATCH v3 5/6] clk: meson: a1: add the " Jan Dakinevich
2024-04-22 7:53 ` Jerome Brunet
2024-04-22 13:49 ` Jan Dakinevich
2024-04-19 12:58 ` [RFC PATCH v3 6/6] arm64: dts: meson: a1: add the audio clock controller Jan Dakinevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1jv849akel.fsf@starbuckisacylon.baylibre.com \
--to=jbrunet@baylibre.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jan.dakinevich@salutedevices.com \
--cc=jiucheng.xu@amlogic.com \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).