* [PATCH] clk: socfpga: fix __init annotation
@ 2016-02-08 14:39 Arnd Bergmann
2016-02-08 22:13 ` Stephen Boyd
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2016-02-08 14:39 UTC (permalink / raw
To: Michael Turquette, Stephen Boyd
Cc: linux-arm-kernel, Arnd Bergmann, Dinh Nguyen, linux-clk,
linux-kernel
clang found a bug with the __socfpga_pll_init definition:
drivers/clk/socfpga/clk-pll-a10.c:77:15: error: '__section__' attribute only applies to functions and
global variables
This moves the __init annotation to the right place so the function
actually gets discarded.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/clk/socfpga/clk-pll-a10.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/socfpga/clk-pll-a10.c b/drivers/clk/socfpga/clk-pll-a10.c
index 402d630bd531..35fabe1a32c3 100644
--- a/drivers/clk/socfpga/clk-pll-a10.c
+++ b/drivers/clk/socfpga/clk-pll-a10.c
@@ -74,7 +74,7 @@ static struct clk_ops clk_pll_ops = {
.get_parent = clk_pll_get_parent,
};
-static struct __init clk * __socfpga_pll_init(struct device_node *node,
+static struct clk * __init __socfpga_pll_init(struct device_node *node,
const struct clk_ops *ops)
{
u32 reg;
--
2.7.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] clk: socfpga: fix __init annotation
2016-02-08 14:39 [PATCH] clk: socfpga: fix __init annotation Arnd Bergmann
@ 2016-02-08 22:13 ` Stephen Boyd
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Boyd @ 2016-02-08 22:13 UTC (permalink / raw
To: Arnd Bergmann
Cc: Michael Turquette, linux-arm-kernel, Dinh Nguyen, linux-clk,
linux-kernel
On 02/08, Arnd Bergmann wrote:
> clang found a bug with the __socfpga_pll_init definition:
>
> drivers/clk/socfpga/clk-pll-a10.c:77:15: error: '__section__' attribute only applies to functions and
> global variables
>
> This moves the __init annotation to the right place so the function
> actually gets discarded.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Applied to clk-next
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-08 22:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-08 14:39 [PATCH] clk: socfpga: fix __init annotation Arnd Bergmann
2016-02-08 22:13 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).