From: Onkarnarth <onkarnath.1@samsung.com>
To: paulburton@kernel.org, mturquette@baylibre.com, sboyd@kernel.org
Cc: linux-mips@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, r.thapliyal@samsung.com,
Onkarnath <onkarnath.1@samsung.com>,
Maninder singh <maninder1.s@samsung.com>
Subject: [PATCH 1/1] clk: imgtec: use %pe for better readability of errors while printing
Date: Mon, 5 Feb 2024 16:41:55 +0530 [thread overview]
Message-ID: <20240205111155.3939125-1-onkarnath.1@samsung.com> (raw)
In-Reply-To: CGME20240205111208epcas5p4775d540854dd8778388065a574b7862b@epcas5p4.samsung.com
From: Onkarnath <onkarnath.1@samsung.com>
instead of printing errros as a number(%ld), it's better to print in string
format for better readability of logs
Signed-off-by: Maninder singh <maninder1.s@samsung.com>
Signed-off-by: Onkarnath <onkarnath.1@samsung.com>
---
drivers/clk/imgtec/clk-boston.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/clk/imgtec/clk-boston.c b/drivers/clk/imgtec/clk-boston.c
index b00cbd045af5..db96f8bea630 100644
--- a/drivers/clk/imgtec/clk-boston.c
+++ b/drivers/clk/imgtec/clk-boston.c
@@ -67,21 +67,21 @@ static void __init clk_boston_setup(struct device_node *np)
hw = clk_hw_register_fixed_rate(NULL, "input", NULL, 0, in_freq);
if (IS_ERR(hw)) {
- pr_err("failed to register input clock: %ld\n", PTR_ERR(hw));
+ pr_err("failed to register input clock: %pe\n", hw);
goto fail_input;
}
onecell->hws[BOSTON_CLK_INPUT] = hw;
hw = clk_hw_register_fixed_rate(NULL, "sys", "input", 0, sys_freq);
if (IS_ERR(hw)) {
- pr_err("failed to register sys clock: %ld\n", PTR_ERR(hw));
+ pr_err("failed to register sys clock: %pe\n", hw);
goto fail_sys;
}
onecell->hws[BOSTON_CLK_SYS] = hw;
hw = clk_hw_register_fixed_rate(NULL, "cpu", "input", 0, cpu_freq);
if (IS_ERR(hw)) {
- pr_err("failed to register cpu clock: %ld\n", PTR_ERR(hw));
+ pr_err("failed to register cpu clock: %pe\n", hw);
goto fail_cpu;
}
onecell->hws[BOSTON_CLK_CPU] = hw;
--
2.25.1
next parent reply other threads:[~2024-02-05 11:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240205111208epcas5p4775d540854dd8778388065a574b7862b@epcas5p4.samsung.com>
2024-02-05 11:11 ` Onkarnarth [this message]
2024-04-11 7:35 ` [PATCH 1/1] clk: imgtec: use %pe for better readability of errors while printing Stephen Boyd
[not found] ` <CGME20240205111208epcas5p4775d540854dd8778388065a574b7862b@epcms5p3>
[not found] ` <20240412061040epcms5p32581354cacdacda8a1bfd7b1a79e8020@epcms5p3>
2024-04-12 6:29 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240205111155.3939125-1-onkarnath.1@samsung.com \
--to=onkarnath.1@samsung.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=maninder1.s@samsung.com \
--cc=mturquette@baylibre.com \
--cc=paulburton@kernel.org \
--cc=r.thapliyal@samsung.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).