From: Stephen Boyd <sboyd@kernel.org>
To: "Catalin Marinas" <catalin.marinas@arm.com>,
"Conor Dooley" <conor+dt@kernel.org>,
"Duje Mihanović" <duje.mihanovic@skole.hr>,
"Guilherme G. Piccoli" <gpiccoli@igalia.com>,
"Haojian Zhuang" <haojian.zhuang@linaro.org>,
"Kees Cook" <keescook@chromium.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Lubomir Rintel" <lkundrak@v3.sk>,
"Michael Turquette" <mturquette@baylibre.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Tony Lindgren" <tony@atomide.com>,
"Tony Luck" <tony.luck@intel.com>,
"Will Deacon" <will@kernel.org>
Cc: phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
Karel Balej <balejk@matfyz.cz>,
David Wronek <david@mainlining.org>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v9 5/9] clk: mmp: Add Marvell PXA1908 clock driver
Date: Mon, 22 Apr 2024 17:38:38 -0700 [thread overview]
Message-ID: <2473d3ddeea21640b20735d660e48f98.sboyd@kernel.org> (raw)
In-Reply-To: <eb221864-0044-4ea5-bbee-7545d10cb130@skole.hr>
Quoting Duje Mihanović (2024-04-20 06:32:56)
> On 4/20/24 00:24, Stephen Boyd wrote:
> > Quoting Duje Mihanović (2024-04-19 07:31:14)
> >> On Friday, April 12, 2024 4:57:09 AM GMT+2 Stephen Boyd wrote:
> >>> Quoting Duje Mihanović (2024-04-11 03:15:34)
> >>>
> >>>> On 4/11/2024 10:00 AM, Stephen Boyd wrote:
> >>>>> Is there a reason this file can't be a platform driver?
> >>>>
> >>>> Not that I know of, I did it like this only because the other in-tree
> >>>> MMP clk drivers do so. I guess the initialization should look like any
> >>>> of the qcom GCC drivers then?
> >>>
> >>> Yes.
> >>
> >> With the entire clock driver code in one file this is quite messy as I also
> >> needed to add module_init and module_exit functions to (un)register each
> >> platform driver, presumably because the module_platform_driver macro doesn't
> >> work with multiple platform drivers in one module. If I split up the driver
> >> code for each clock controller block into its own file (such as clk-of-
> >> pxa1908-apbc.c) as I believe is the best option, should the commits be split
> >> up accordingly as well?
> >
> > Sure. Why is 'of' in the name? Maybe that is unnecessary?
>
> That seems to be a historical leftover from when Marvell was just adding
> DT support to the ARM32 MMP SoCs which Rob followed along with in the
> PXA1928 clk driver and so have I. Should I drop it then as Marvell has
> in the PXA1908 vendor kernel?
>
Sounds good to me.
next prev parent reply other threads:[~2024-04-23 0:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 20:55 [PATCH v9 0/9] Initial Marvell PXA1908 support Duje Mihanović
2024-04-02 20:55 ` [PATCH v9 1/9] clk: mmp: Switch to use struct u32_fract instead of custom one Duje Mihanović
2024-04-11 7:56 ` Stephen Boyd
2024-04-02 20:55 ` [PATCH v9 2/9] dt-bindings: pinctrl: pinctrl-single: add marvell,pxa1908-padconf compatible Duje Mihanović
2024-04-02 20:55 ` [PATCH v9 3/9] pinctrl: single: " Duje Mihanović
2024-04-02 20:55 ` [PATCH v9 4/9] dt-bindings: clock: Add Marvell PXA1908 clock bindings Duje Mihanović
2024-04-11 7:58 ` Stephen Boyd
2024-04-02 20:55 ` [PATCH v9 5/9] clk: mmp: Add Marvell PXA1908 clock driver Duje Mihanović
2024-04-11 8:00 ` Stephen Boyd
2024-04-11 10:15 ` Duje Mihanović
2024-04-12 2:57 ` Stephen Boyd
2024-04-19 14:31 ` Duje Mihanović
2024-04-19 22:24 ` Stephen Boyd
2024-04-20 13:32 ` Duje Mihanović
2024-04-23 0:38 ` Stephen Boyd [this message]
2024-04-02 20:55 ` [PATCH v9 6/9] dt-bindings: marvell: Document PXA1908 SoC Duje Mihanović
2024-04-02 20:55 ` [PATCH v9 7/9] arm64: Kconfig.platforms: Add config for Marvell PXA1908 platform Duje Mihanović
2024-04-02 21:16 ` [PATCH v9 8/9] arm64: dts: Add DTS for Marvell PXA1908 and samsung,coreprimevelte Duje Mihanović
2024-04-02 21:20 ` [PATCH v9 9/9] MAINTAINERS: add myself as Marvell PXA1908 maintainer Duje Mihanović
2024-04-03 14:15 ` [PATCH v9 0/9] Initial Marvell PXA1908 support Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2473d3ddeea21640b20735d660e48f98.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=balejk@matfyz.cz \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=david@mainlining.org \
--cc=devicetree@vger.kernel.org \
--cc=duje.mihanovic@skole.hr \
--cc=gpiccoli@igalia.com \
--cc=haojian.zhuang@linaro.org \
--cc=keescook@chromium.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=mturquette@baylibre.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=tony.luck@intel.com \
--cc=tony@atomide.com \
--cc=will@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).