Linux-Clk Archive mirror
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: David Yang <mmyangfl@gmail.com>, linux-clk@vger.kernel.org
Cc: Michael Turquette <mturquette@baylibre.com>,
	linux-kernel@vger.kernel.org, David Yang <mmyangfl@gmail.com>
Subject: Re: [PATCH v8 09/13] clk: hisilicon: hi3620: Convert into platform driver module
Date: Thu, 11 Apr 2024 00:15:21 -0700	[thread overview]
Message-ID: <276bd3d76b57cf2916ba968e99499096.sboyd@kernel.org> (raw)
In-Reply-To: <20240411070503.38093-11-mmyangfl@gmail.com>

Quoting David Yang (2024-04-11 00:04:54)
> Use common helper functions and register clks with a single of_device_id
> data.
> 
> Signed-off-by: David Yang <mmyangfl@gmail.com>
> ---
>  drivers/clk/hisilicon/clk-hi3620.c | 191 +++++++++++++++--------------
>  1 file changed, 96 insertions(+), 95 deletions(-)
> 
> diff --git a/drivers/clk/hisilicon/clk-hi3620.c b/drivers/clk/hisilicon/clk-hi3620.c
> index 5d0226530fdb..8832cdd6bd57 100644
> --- a/drivers/clk/hisilicon/clk-hi3620.c
> +++ b/drivers/clk/hisilicon/clk-hi3620.c
> @@ -12,6 +12,7 @@
>  #include <linux/kernel.h>
>  #include <linux/clk-provider.h>
>  #include <linux/io.h>
> +#include <linux/module.h>
>  #include <linux/of.h>
>  #include <linux/of_address.h>
>  #include <linux/slab.h>

You need to include linux/platform_device.h if you're making it into a
platform driver.

  reply	other threads:[~2024-04-11  7:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-11  7:04 [PATCH v8 00/13] clk: hisilicon: Migrate devm APIs David Yang
2024-04-11  7:04 ` [PATCH v8 01/13] clk: hisilicon: Add helper functions for platform driver David Yang
2024-04-11  7:04 ` [PATCH v8 02/13] clk: hisilicon: hi3516cv300: Use helper functions David Yang
2024-04-11  7:04 ` [PATCH v8 03/13] clk: hisilicon: hi3798cv200: " David Yang
2024-04-11  7:04 ` [PATCH v8 04/13] clk: hisilicon: Remove hisi_crg_funcs David Yang
2024-04-11  7:04 ` [PATCH v8 05/13] clk: hisilicon: hi3519: Use helper functions David Yang
2024-04-11  7:04 ` [PATCH v8 06/13] clk: hisilicon: hi3559a: " David Yang
2024-04-11  7:04 ` [PATCH v8 07/13] clk: hisilicon: hi3660: Convert into module David Yang
2024-04-11  7:04 ` [PATCH v8 08/13] clk: hisilicon: hi3670: " David Yang
2024-04-11  7:04 ` [PATCH v8 09/13] clk: hisilicon: hi3620: Convert into platform driver module David Yang
2024-04-11  7:15   ` Stephen Boyd [this message]
2024-04-11  7:04 ` [PATCH v8 10/13] clk: hisilicon: hi6220: " David Yang
2024-04-11  7:04 ` [PATCH v8 11/13] clk: hisilicon: hip04: " David Yang
2024-04-11  7:04 ` [PATCH v8 12/13] clk: hisilicon: hix5hd2: " David Yang
2024-04-11  7:04 ` [PATCH v8 13/13] clk: hisilicon: Migrate devm APIs David Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=276bd3d76b57cf2916ba968e99499096.sboyd@kernel.org \
    --to=sboyd@kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmyangfl@gmail.com \
    --cc=mturquette@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).