From: Krzysztof Kozlowski <krzk@kernel.org>
To: Stephen Boyd <sboyd@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Michael Turquette <mturquette@baylibre.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>,
linux-clk@vger.kernel.org,
Sylwester Nawrocki <snawrocki@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Peter Griffin <peter.griffin@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] clk: samsung: drivers for v6.10
Date: Wed, 8 May 2024 08:24:43 +0200 [thread overview]
Message-ID: <49ff4f07-aaf9-4f29-ba97-b4b03b05f36d@kernel.org> (raw)
In-Reply-To: <b3e320ecb16320f88d7db566be51b1e9.sboyd@kernel.org>
On 07/05/2024 22:43, Stephen Boyd wrote:
> Quoting Krzysztof Kozlowski (2024-05-06 22:54:10)
>> On 07/05/2024 01:44, Stephen Boyd wrote:
>>> Quoting Krzysztof Kozlowski (2024-05-04 05:06:22)
>>>> The following changes since commit 4cece764965020c22cff7665b18a012006359095:
>>>>
>>>> Linux 6.9-rc1 (2024-03-24 14:10:05 -0700)
>>>>
>>>> are available in the Git repository at:
>>>>
>>>> https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git tags/samsung-clk-6.10
>>>
>>> I'm getting compile warnings. Is there a pending fix? Also, why is GS101
>>
>> I don't see any of these warnings. Neither local (W=1), nor on my CI,
>> nor reported by LKP (which reported build successes for this branch).
>> How can I reproduce it?
>
> I ran this command
>
> make W=1 ARCH=arm CROSS_COMPILE=arm-linux-gnueabi- drivers/clk/samsung/clk-gs101.o
>
> and I see the warnings. They're actually upgraded to errors.
So regular W=1 build... weird.
>
>>
>>
>>> describing clk parents with strings instead of using clk_parent_data?
>>
>> GS101 uses existing Samsuung clock framework, so that's how it is done
>> there. There is nothing odd here, comparing to other Samsung clocks.
>
> Ok. Is anyone working on migrating Samsung clk drivers to the non-string
> way?
I am not aware of it. There was no serious development for Samsung SoC
in total for years.
>
>>
>>>
>>> In file included from drivers/clk/samsung/clk-gs101.c:16:
>>> drivers/clk/samsung/clk-gs101.c:2616:7: error: ‘mout_hsi2_mmc_card_p’
>>> defined but not used [-Werror=unused-const-variable=]
>>> 2616 | PNAME(mout_hsi2_mmc_card_p) = { "fout_shared2_pll", "fout_shared3_pll",
>>
>> I see indeed some unused variables and I will drop them but your
>> warnings are not reproducible.
>
> Weird! I use gcc-12.2 if that helps. I've been meaning to upgrade but I
> also don't see much urgency.
>
> I'll wait for the next PR.
Yes, patch is already in linux-next, so I'll wait a bit and send today.
Best regards,
Krzysztof
prev parent reply other threads:[~2024-05-08 6:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-04 12:06 [GIT PULL] clk: samsung: drivers for v6.10 Krzysztof Kozlowski
2024-05-06 23:44 ` Stephen Boyd
2024-05-07 5:54 ` Krzysztof Kozlowski
2024-05-07 20:43 ` Stephen Boyd
2024-05-08 6:24 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49ff4f07-aaf9-4f29-ba97-b4b03b05f36d@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=peter.griffin@linaro.org \
--cc=sboyd@kernel.org \
--cc=snawrocki@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).