From: Neil Armstrong <neil.armstrong@linaro.org>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Jerome Brunet <jbrunet@baylibre.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Kevin Hilman <khilman@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: meson: s4: fix module autoloading
Date: Wed, 10 Apr 2024 17:56:12 +0200 [thread overview]
Message-ID: <7c1aa6a9-b964-45e7-bd8c-d9ef5096a04a@linaro.org> (raw)
In-Reply-To: <20240410155406.224128-1-krzk@kernel.org>
On 10/04/2024 17:54, Krzysztof Kozlowski wrote:
> Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded
> based on the alias from of_device_id table. Clocks are considered core
> components, so usually they are built-in, however these can be built and
> used as modules on some generic kernel.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/clk/meson/s4-peripherals.c | 1 +
> drivers/clk/meson/s4-pll.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/clk/meson/s4-peripherals.c b/drivers/clk/meson/s4-peripherals.c
> index 6c35de3d536f..22ff030bd6a8 100644
> --- a/drivers/clk/meson/s4-peripherals.c
> +++ b/drivers/clk/meson/s4-peripherals.c
> @@ -3799,6 +3799,7 @@ static const struct of_device_id clkc_match_table[] = {
> },
> {}
> };
> +MODULE_DEVICE_TABLE(of, clkc_match_table);
>
> static struct platform_driver s4_driver = {
> .probe = meson_s4_periphs_probe,
> diff --git a/drivers/clk/meson/s4-pll.c b/drivers/clk/meson/s4-pll.c
> index 8dfaeccaadc2..8a917b9703bf 100644
> --- a/drivers/clk/meson/s4-pll.c
> +++ b/drivers/clk/meson/s4-pll.c
> @@ -853,6 +853,7 @@ static const struct of_device_id clkc_match_table[] = {
> },
> {}
> };
> +MODULE_DEVICE_TABLE(of, clkc_match_table);
>
> static struct platform_driver s4_driver = {
> .probe = meson_s4_pll_probe,
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
next prev parent reply other threads:[~2024-04-10 15:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 15:54 [PATCH] clk: meson: s4: fix module autoloading Krzysztof Kozlowski
2024-04-10 15:56 ` Neil Armstrong [this message]
2024-04-10 19:01 ` Martin Blumenstingl
2024-05-03 13:22 ` Jerome Brunet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c1aa6a9-b964-45e7-bd8c-d9ef5096a04a@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzk@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).