From: Md Sadre Alam <quic_mdalam@quicinc.com>
To: Stephen Boyd <sboyd@kernel.org>, <linux-arm-msm@vger.kernel.org>,
<linux-clk@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<mturquette@baylibre.com>, <quic_srichara@quicinc.com>,
<quic_varada@quicinc.com>
Subject: Re: [PATCH] clk: qcom: gcc-ipq9574: Add BRANCH_HALT_VOTED flag
Date: Fri, 3 May 2024 14:41:17 +0530 [thread overview]
Message-ID: <883248ce-23a7-1f41-aeab-67dc0828566b@quicinc.com> (raw)
In-Reply-To: <2e05b0e246431d9dcf28c7135fff8231.sboyd@kernel.org>
On 5/3/2024 3:38 AM, Stephen Boyd wrote:
> Quoting Md Sadre Alam (2024-05-01 20:42:47)
>> Add BRANCH_HALT_VOTED flag to inform clock framework
>> don't check for CLK_OFF bit.
>>
>> CRYPTO_AHB_CLK_ENA and CRYPTO_AXI_CLK_ENA enable bit is
>> present in other VOTE registers also, like TZ.
>> If anyone else also enabled this clock, even if we turn
>> off in GCC_APCS_CLOCK_BRANCH_ENA_VOTE | 0x180B004, it won't
>> turn off.
>
> Are you seeing problems where we need to send this patch to stable?
Yes
>
>>
>> Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com>
>> ---
>
> Any fixes tag?
Will add in next patch
>
>> drivers/clk/qcom/gcc-ipq9574.c | 10 ++++++----
>> 1 file changed, 6 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/clk/qcom/gcc-ipq9574.c b/drivers/clk/qcom/gcc-ipq9574.c
>> index 0a3f846695b8..f8b9a1e93bef 100644
>> --- a/drivers/clk/qcom/gcc-ipq9574.c
>> +++ b/drivers/clk/qcom/gcc-ipq9574.c
>> @@ -2140,9 +2140,10 @@ static struct clk_rcg2 pcnoc_bfdcd_clk_src = {
>>
>> static struct clk_branch gcc_crypto_axi_clk = {
>> .halt_reg = 0x16010,
>> + .halt_check = BRANCH_HALT_VOTED,
>> .clkr = {
>> - .enable_reg = 0x16010,
>> - .enable_mask = BIT(0),
>> + .enable_reg = 0xb004,
>
> You could be more explicit in the commit text that you're changing the
> register offset to the voting register.
will update the commit message in next patch.
>
>> + .enable_mask = BIT(15),
Thanks for reviewing.
Regards,
Alam.
prev parent reply other threads:[~2024-05-03 9:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 3:42 [PATCH] clk: qcom: gcc-ipq9574: Add BRANCH_HALT_VOTED flag Md Sadre Alam
2024-05-02 22:08 ` Stephen Boyd
2024-05-03 9:11 ` Md Sadre Alam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=883248ce-23a7-1f41-aeab-67dc0828566b@quicinc.com \
--to=quic_mdalam@quicinc.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_srichara@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).