From: Stephen Boyd <sboyd@kernel.org>
To: Albert Ou <aou@eecs.berkeley.edu>,
Conor Dooley <conor+dt@kernel.org>,
Drew Fustini <dfustini@tenstorrent.com>,
Emil Renner Berthing <emil.renner.berthing@canonical.com>,
Fu Wei <wefu@redhat.com>, Guo Ren <guoren@kernel.org>,
Jisheng Zhang <jszhang@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Rob Herring <robh@kernel.org>,
Thomas Bonnefille <thomas.bonnefille@bootlin.com>,
Yangtao Li <frank.li@vivo.com>
Cc: linux-riscv@lists.infradead.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Drew Fustini <dfustini@tenstorrent.com>
Subject: Re: [PATCH RFC v3 2/7] dt-bindings: clock: Document T-Head TH1520 AP_SUBSYS controller
Date: Thu, 09 May 2024 15:13:42 -0700 [thread overview]
Message-ID: <8dc03fdc36b72888bd1b59cec6feebad.sboyd@kernel.org> (raw)
In-Reply-To: <20240506-th1520-clk-v3-2-085a18a23a7f@tenstorrent.com>
Quoting Drew Fustini (2024-05-06 21:55:15)
> diff --git a/Documentation/devicetree/bindings/clock/thead,th1520-clk-ap.yaml b/Documentation/devicetree/bindings/clock/thead,th1520-clk-ap.yaml
> new file mode 100644
> index 000000000000..d7e665c1534a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/thead,th1520-clk-ap.yaml
> @@ -0,0 +1,64 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/thead,th1520-clk-ap.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: T-HEAD TH1520 AP sub-system clock controller
> +
> +description: |
> + The T-HEAD TH1520 AP sub-system clock controller configures the
> + CPU, DPU, GMAC and TEE PLLs.
> +
> + SoC reference manual
> + https://openbeagle.org/beaglev-ahead/beaglev-ahead/-/blob/main/docs/TH1520%20System%20User%20Manual.pdf
> +
> +maintainers:
> + - Jisheng Zhang <jszhang@kernel.org>
> + - Wei Fu <wefu@redhat.com>
> + - Drew Fustini <dfustini@tenstorrent.com>
> +
> +properties:
> + compatible:
> + const: thead,th1520-clk-ap
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + items:
> + - description: main oscillator (24MHz)
> +
> + clock-names:
> + items:
> + - const: osc
I recommend dropping clock-names so that you don't rely on anything
besides the cell index when describing clk_parent_data.
> +
> + "#clock-cells":
> + const: 1
> + description:
> + See <dt-bindings/clock/thead,th1520-clk-ap.h> for valid indices.
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
If you can't drop it at least make it optional.
next prev parent reply other threads:[~2024-05-09 22:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 4:55 [PATCH RFC v3 0/7] clk: thead: Add support for TH1520 AP_SUBSYS clock controller Drew Fustini
2024-05-07 4:55 ` [PATCH RFC v3 1/7] riscv: dts: thead: Fix node ordering in TH1520 device tree Drew Fustini
2024-05-07 4:55 ` [PATCH RFC v3 2/7] dt-bindings: clock: Document T-Head TH1520 AP_SUBSYS controller Drew Fustini
2024-05-07 20:16 ` Rob Herring (Arm)
2024-05-09 22:13 ` Stephen Boyd [this message]
2024-05-07 4:55 ` [PATCH RFC v3 3/7] clk: thead: Add support for T-Head TH1520 AP_SUBSYS clocks Drew Fustini
2024-05-07 4:55 ` [PATCH RFC v3 4/7] riscv: dts: thead: Add TH1520 AP_SUBSYS clock controller Drew Fustini
2024-05-07 4:55 ` [PATCH RFC v3 5/7] riscv: dts: thead: change TH1520 uart nodes to use " Drew Fustini
2024-05-07 4:55 ` [PATCH RFC v3 6/7] riscv: dts: thead: change TH1520 mmc " Drew Fustini
2024-05-07 4:55 ` [PATCH RFC v3 7/7] riscv: dts: thead: update TH1520 dma and timer " Drew Fustini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8dc03fdc36b72888bd1b59cec6feebad.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dfustini@tenstorrent.com \
--cc=emil.renner.berthing@canonical.com \
--cc=frank.li@vivo.com \
--cc=guoren@kernel.org \
--cc=jszhang@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=thomas.bonnefille@bootlin.com \
--cc=wefu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).