* [PATCH] clk: samsung: Don't register clkdev lookup for the fixed rate clocks
[not found] <CGME20240507065329eucas1p1b26d68384a4f076b31223ed099fd3a48@eucas1p1.samsung.com>
@ 2024-05-07 6:53 ` Marek Szyprowski
2024-05-07 16:35 ` André Draszik
2024-05-08 20:46 ` Sam Protsenko
0 siblings, 2 replies; 4+ messages in thread
From: Marek Szyprowski @ 2024-05-07 6:53 UTC (permalink / raw
To: linux-samsung-soc, linux-clk
Cc: Marek Szyprowski, Krzysztof Kozlowski, Sylwester Nawrocki,
Chanwoo Choi, Alim Akhtar, Michael Turquette, Stephen Boyd
Commit 4d11c62ca8d7 ("clkdev: report over-sized strings when creating
clkdev entries") revealed that clock lookup is registered for all fixed
clocks. The mentioned commit added a check if the registered name is not
too long. This fails for some clocks registered for Exynos542x SoCs family.
This lookup is a left-over from early common clock framework days, not
really needed nowadays, so remove it to avoid further issues.
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
Here is the fix for the mentioned 4d11c62ca8d7 commit, which fixes
booting of Exynos542x SoCs:
https://lore.kernel.org/all/20240507064434.3213933-1-m.szyprowski@samsung.com/
This change is independent fix. I've tested it on all Exynos based boards
I have in my test lab. It would be great if someone could test it on
s3c64xx and s3c24xx based boards.
---
drivers/clk/samsung/clk.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/drivers/clk/samsung/clk.c b/drivers/clk/samsung/clk.c
index b6701905f254..6342ff411757 100644
--- a/drivers/clk/samsung/clk.c
+++ b/drivers/clk/samsung/clk.c
@@ -151,15 +151,6 @@ void __init samsung_clk_register_fixed_rate(struct samsung_clk_provider *ctx,
}
samsung_clk_add_lookup(ctx, clk_hw, list->id);
-
- /*
- * Unconditionally add a clock lookup for the fixed rate clocks.
- * There are not many of these on any of Samsung platforms.
- */
- ret = clk_hw_register_clkdev(clk_hw, list->name, NULL);
- if (ret)
- pr_err("%s: failed to register clock lookup for %s",
- __func__, list->name);
}
}
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] clk: samsung: Don't register clkdev lookup for the fixed rate clocks
2024-05-07 6:53 ` [PATCH] clk: samsung: Don't register clkdev lookup for the fixed rate clocks Marek Szyprowski
@ 2024-05-07 16:35 ` André Draszik
2024-05-08 20:46 ` Sam Protsenko
1 sibling, 0 replies; 4+ messages in thread
From: André Draszik @ 2024-05-07 16:35 UTC (permalink / raw
To: m.szyprowski
Cc: alim.akhtar, cw00.choi, krzk, linux-clk, linux-samsung-soc,
mturquette, s.nawrocki, sboyd
> Commit 4d11c62ca8d7 ("clkdev: report over-sized strings when creating
> clkdev entries") revealed that clock lookup is registered for all fixed
> clocks. The mentioned commit added a check if the registered name is not
> too long. This fails for some clocks registered for Exynos542x SoCs family.
> This lookup is a left-over from early common clock framework days, not
> really needed nowadays, so remove it to avoid further issues.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> Here is the fix for the mentioned 4d11c62ca8d7 commit, which fixes
> booting of Exynos542x SoCs:
> https://lore.kernel.org/all/20240507064434.3213933-1-m.szyprowski@samsung.com/
>
> This change is independent fix. I've tested it on all Exynos based boards
> I have in my test lab. It would be great if someone could test it on
> s3c64xx and s3c24xx based boards.
> ---
> drivers/clk/samsung/clk.c | 9 ---------
> 1 file changed, 9 deletions(-)
I've boot tested this on gs101 / Pixel6, which now completes again successfully on
this Exynos-based SoC.
Tested-by: André Draszik <andre.draszik@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] clk: samsung: Don't register clkdev lookup for the fixed rate clocks
2024-05-07 6:53 ` [PATCH] clk: samsung: Don't register clkdev lookup for the fixed rate clocks Marek Szyprowski
2024-05-07 16:35 ` André Draszik
@ 2024-05-08 20:46 ` Sam Protsenko
2024-05-09 8:11 ` Marek Szyprowski
1 sibling, 1 reply; 4+ messages in thread
From: Sam Protsenko @ 2024-05-08 20:46 UTC (permalink / raw
To: Marek Szyprowski
Cc: linux-samsung-soc, linux-clk, Krzysztof Kozlowski,
Sylwester Nawrocki, Chanwoo Choi, Alim Akhtar, Michael Turquette,
Stephen Boyd
On Tue, May 7, 2024 at 1:53 AM Marek Szyprowski
<m.szyprowski@samsung.com> wrote:
>
> Commit 4d11c62ca8d7 ("clkdev: report over-sized strings when creating
> clkdev entries") revealed that clock lookup is registered for all fixed
> clocks. The mentioned commit added a check if the registered name is not
> too long. This fails for some clocks registered for Exynos542x SoCs family.
> This lookup is a left-over from early common clock framework days, not
> really needed nowadays, so remove it to avoid further issues.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> Here is the fix for the mentioned 4d11c62ca8d7 commit, which fixes
> booting of Exynos542x SoCs:
> https://lore.kernel.org/all/20240507064434.3213933-1-m.szyprowski@samsung.com/
>
> This change is independent fix. I've tested it on all Exynos based boards
> I have in my test lab. It would be great if someone could test it on
> s3c64xx and s3c24xx based boards.
> ---
Thanks Marek, it fixes some warnings when booting the E850-96 board
with current kernel-next (next-20240508), like:
samsung_clk_register_fixed_rate: failed to register clock lookup
for clk_rco_i3c_pmic
...
But I guess 'ret' variable should be removed now, I'm seeing this
build warning after applying this patch:
drivers/clk/samsung/clk.c: In function 'samsung_clk_register_fixed_rate':
drivers/clk/samsung/clk.c:142:20: warning: unused variable 'ret'
[-Wunused-variable]
Also, maybe add corresponding "Fixes" tag?
Other than that:
Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
Tested-by: Sam Protsenko <semen.protsenko@linaro.org>
Thanks!
[snip]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] clk: samsung: Don't register clkdev lookup for the fixed rate clocks
2024-05-08 20:46 ` Sam Protsenko
@ 2024-05-09 8:11 ` Marek Szyprowski
0 siblings, 0 replies; 4+ messages in thread
From: Marek Szyprowski @ 2024-05-09 8:11 UTC (permalink / raw
To: Sam Protsenko
Cc: linux-samsung-soc, linux-clk, Krzysztof Kozlowski,
Sylwester Nawrocki, Chanwoo Choi, Alim Akhtar, Michael Turquette,
Stephen Boyd
On 08.05.2024 22:46, Sam Protsenko wrote:
> On Tue, May 7, 2024 at 1:53 AM Marek Szyprowski
> <m.szyprowski@samsung.com> wrote:
>> Commit 4d11c62ca8d7 ("clkdev: report over-sized strings when creating
>> clkdev entries") revealed that clock lookup is registered for all fixed
>> clocks. The mentioned commit added a check if the registered name is not
>> too long. This fails for some clocks registered for Exynos542x SoCs family.
>> This lookup is a left-over from early common clock framework days, not
>> really needed nowadays, so remove it to avoid further issues.
>>
>> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
>> ---
>> Here is the fix for the mentioned 4d11c62ca8d7 commit, which fixes
>> booting of Exynos542x SoCs:
>> https://lore.kernel.org/all/20240507064434.3213933-1-m.szyprowski@samsung.com/
>>
>> This change is independent fix. I've tested it on all Exynos based boards
>> I have in my test lab. It would be great if someone could test it on
>> s3c64xx and s3c24xx based boards.
>> ---
> Thanks Marek, it fixes some warnings when booting the E850-96 board
> with current kernel-next (next-20240508), like:
>
> samsung_clk_register_fixed_rate: failed to register clock lookup
> for clk_rco_i3c_pmic
> ...
>
> But I guess 'ret' variable should be removed now, I'm seeing this
> build warning after applying this patch:
>
> drivers/clk/samsung/clk.c: In function 'samsung_clk_register_fixed_rate':
> drivers/clk/samsung/clk.c:142:20: warning: unused variable 'ret'
> [-Wunused-variable]
Indeed I've missed that. I will send v2 then.
> Also, maybe add corresponding "Fixes" tag?
The problem is which commit should be pointed there. The removed code
originates from commit 721c42a351b1 ("clk: samsung: add common clock
framework helper functions for Samsung platforms"), but that time such
workaround might have been required, so this doesn't match the 'Fixes'
tag usage.
> Other than that:
>
> Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
> Tested-by: Sam Protsenko <semen.protsenko@linaro.org>
>
> Thanks!
>
> [snip]
>
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-05-09 8:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20240507065329eucas1p1b26d68384a4f076b31223ed099fd3a48@eucas1p1.samsung.com>
2024-05-07 6:53 ` [PATCH] clk: samsung: Don't register clkdev lookup for the fixed rate clocks Marek Szyprowski
2024-05-07 16:35 ` André Draszik
2024-05-08 20:46 ` Sam Protsenko
2024-05-09 8:11 ` Marek Szyprowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).