From: Peter Griffin <peter.griffin@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: mturquette@baylibre.com, sboyd@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, vkoul@kernel.org, kishon@kernel.org,
alim.akhtar@samsung.com, avri.altman@wdc.com,
bvanassche@acm.org, s.nawrocki@samsung.com,
cw00.choi@samsung.com, jejb@linux.ibm.com,
martin.petersen@oracle.com,
James.Bottomley@hansenpartnership.com, ebiggers@kernel.org,
linux-scsi@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, tudor.ambarus@linaro.org,
andre.draszik@linaro.org, saravanak@google.com,
willmcvicker@google.com
Subject: Re: [PATCH v2 03/14] dt-bindings: ufs: exynos-ufs: Add gs101 compatible
Date: Thu, 25 Apr 2024 17:49:11 +0100 [thread overview]
Message-ID: <CADrjBPpQE2bMkVUHQHmBBZfRO8Hjb86xPvLQgSvn4BN0guY9xQ@mail.gmail.com> (raw)
In-Reply-To: <20240424195318.GA367166-robh@kernel.org>
Hi Rob,
Thanks for the review.
On Wed, 24 Apr 2024 at 20:53, Rob Herring <robh@kernel.org> wrote:
>
> On Tue, Apr 23, 2024 at 09:49:55PM +0100, Peter Griffin wrote:
> > Add dedicated google,gs101-ufs compatible for Google Tensor gs101
> > SoC.
> >
> > Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> > ---
> > .../bindings/ufs/samsung,exynos-ufs.yaml | 38 +++++++++++++++++--
> > 1 file changed, 35 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml b/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml
> > index b2b509b3944d..1179527d29d1 100644
> > --- a/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml
> > +++ b/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml
> > @@ -12,12 +12,10 @@ maintainers:
> > description: |
> > Each Samsung UFS host controller instance should have its own node.
> >
> > -allOf:
> > - - $ref: ufs-common.yaml
> > -
> > properties:
> > compatible:
> > enum:
> > + - google,gs101-ufs
> > - samsung,exynos7-ufs
> > - samsung,exynosautov9-ufs
> > - samsung,exynosautov9-ufs-vh
> > @@ -38,14 +36,24 @@ properties:
> > - const: ufsp
> >
> > clocks:
> > + minItems: 2
> > items:
> > - description: ufs link core clock
> > - description: unipro main clock
> > + - description: fmp clock
> > + - description: ufs aclk clock
> > + - description: ufs pclk clock
> > + - description: sysreg clock
> >
> > clock-names:
> > + minItems: 2
> > items:
> > - const: core_clk
> > - const: sclk_unipro_main
> > + - const: fmp
> > + - const: ufs_aclk
> > + - const: ufs_pclk
>
> 'ufs_' is redundant.
Will fix.
Thanks,
Peter.
next prev parent reply other threads:[~2024-04-25 16:49 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 20:49 [PATCH v2 00/14] HSI2, UFS & UFS phy support for Tensor GS101 Peter Griffin
2024-04-23 20:49 ` [PATCH v2 01/14] dt-bindings: clock: google,gs101-clock: add HSI2 clock management unit Peter Griffin
2024-04-24 19:51 ` Rob Herring
2024-04-25 12:19 ` André Draszik
2024-04-23 20:49 ` [PATCH v2 02/14] dt-bindings: soc: google: exynos-sysreg: add dedicated hsi2 sysreg compatible Peter Griffin
2024-04-23 20:49 ` [PATCH v2 03/14] dt-bindings: ufs: exynos-ufs: Add gs101 compatible Peter Griffin
2024-04-24 19:53 ` Rob Herring
2024-04-25 16:49 ` Peter Griffin [this message]
2024-04-23 20:49 ` [PATCH v2 04/14] arm64: dts: exynos: gs101: enable cmu-hsi2 clock controller Peter Griffin
2024-04-25 11:39 ` André Draszik
2024-04-23 20:49 ` [PATCH v2 05/14] arm64: dts: exynos: gs101: Add the hsi2 sysreg node Peter Griffin
2024-04-25 11:50 ` André Draszik
2024-04-23 20:49 ` [PATCH v2 06/14] arm64: dts: exynos: gs101: Add ufs, ufs-phy and ufs regulator dt nodes Peter Griffin
2024-04-25 12:02 ` André Draszik
2024-04-25 16:35 ` Peter Griffin
2024-04-23 20:49 ` [PATCH v2 07/14] clk: samsung: gs101: add support for cmu_hsi2 Peter Griffin
2024-04-23 20:50 ` [PATCH v2 08/14] scsi: ufs: host: ufs-exynos: Add EXYNOS_UFS_OPT_UFSPR_SECURE option Peter Griffin
2024-04-23 20:50 ` [PATCH v2 09/14] scsi: ufs: host: ufs-exynos: add EXYNOS_UFS_OPT_TIMER_TICK_SELECT option Peter Griffin
2024-04-23 20:50 ` [PATCH v2 10/14] scsi: ufs: host: ufs-exynos: allow max frequencies up to 267Mhz Peter Griffin
2024-04-23 20:50 ` [PATCH v2 11/14] scsi: ufs: host: ufs-exynos: add some pa_dbg_ register offsets into drvdata Peter Griffin
2024-04-23 20:50 ` [PATCH v2 12/14] scsi: ufs: host: ufs-exynos: Add support for Tensor gs101 SoC Peter Griffin
2024-04-23 20:50 ` [PATCH v2 13/14] phy: samsung-ufs: ufs: remove superfluous mfd/syscon.h header Peter Griffin
2024-04-23 20:50 ` [PATCH v2 14/14] phy: samsung-ufs: ufs: exit on first reported error Peter Griffin
2024-04-25 7:08 ` [PATCH v2 00/14] HSI2, UFS & UFS phy support for Tensor GS101 Krzysztof Kozlowski
2024-04-25 10:31 ` Peter Griffin
2024-04-25 10:47 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADrjBPpQE2bMkVUHQHmBBZfRO8Hjb86xPvLQgSvn4BN0guY9xQ@mail.gmail.com \
--to=peter.griffin@linaro.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=conor+dt@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=ebiggers@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=saravanak@google.com \
--cc=sboyd@kernel.org \
--cc=tudor.ambarus@linaro.org \
--cc=vkoul@kernel.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).