From: "Satya Priya Kakitapalli (Temp)" <quic_skakitap@quicinc.com>
To: Rob Herring <robh@kernel.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Ajit Pandey <quic_ajipan@quicinc.com>,
Imran Shaik <quic_imrashai@quicinc.com>,
"Taniya Das" <quic_tdas@quicinc.com>,
Jagadeesh Kona <quic_jkona@quicinc.com>,
<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-clk@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: clock: qcom: Update SM8150 videocc bindings
Date: Tue, 30 Apr 2024 15:31:13 +0530 [thread overview]
Message-ID: <be6ce8b8-ce4f-7018-a46b-fa5780050847@quicinc.com> (raw)
In-Reply-To: <20240402160545.GA223060-robh@kernel.org>
On 4/2/2024 9:35 PM, Rob Herring wrote:
> On Mon, Apr 01, 2024 at 04:44:23PM +0530, Satya Priya Kakitapalli wrote:
>> Update the clocks list for SM8150 to add both AHB and XO clocks,
>> as it needs both of them.
> I read this as you are adding 2 clocks, but it is really just 1 you are
> adding (iface).
Yes, I am adding AHB (iface) as its needed for SM8150, which is not
present in the current bindings.
> This should have more detail on why breaking the ABI is okay here.
Sure, I'll update the commit text accordingly.
>> Fixes: 35d26e9292e2 ("dt-bindings: clock: Add YAML schemas for the QCOM VIDEOCC clock bindings")
>> Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
>> ---
>> .../devicetree/bindings/clock/qcom,videocc.yaml | 17 ++++++++++++++++-
>> 1 file changed, 16 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/clock/qcom,videocc.yaml b/Documentation/devicetree/bindings/clock/qcom,videocc.yaml
>> index 6999e36ace1b..68bac801adb0 100644
>> --- a/Documentation/devicetree/bindings/clock/qcom,videocc.yaml
>> +++ b/Documentation/devicetree/bindings/clock/qcom,videocc.yaml
>> @@ -75,7 +75,6 @@ allOf:
>> enum:
>> - qcom,sc7180-videocc
>> - qcom,sdm845-videocc
>> - - qcom,sm8150-videocc
>> then:
>> properties:
>> clocks:
>> @@ -101,6 +100,22 @@ allOf:
>> - const: bi_tcxo
>> - const: bi_tcxo_ao
>>
>> + - if:
>> + properties:
>> + compatible:
>> + enum:
>> + - qcom,sm8150-videocc
>> + then:
>> + properties:
>> + clocks:
>> + items:
>> + - description: AHB
>> + - description: Board XO source
>> + clock-names:
>> + items:
>> + - const: iface
>> + - const: bi_tcxo
>> +
>> - if:
>> properties:
>> compatible:
>>
>> --
>> 2.25.1
>>
next prev parent reply other threads:[~2024-04-30 10:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-01 11:14 [PATCH v2 0/2] Add DT support for video clock controller on SM8150 Satya Priya Kakitapalli
2024-04-01 11:14 ` [PATCH v2 1/2] dt-bindings: clock: qcom: Update SM8150 videocc bindings Satya Priya Kakitapalli
2024-04-02 16:05 ` Rob Herring
2024-04-30 10:01 ` Satya Priya Kakitapalli (Temp) [this message]
2024-04-01 11:14 ` [PATCH v2 2/2] arm64: dts: qcom: sm8150: Add video clock controller node Satya Priya Kakitapalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be6ce8b8-ce4f-7018-a46b-fa5780050847@quicinc.com \
--to=quic_skakitap@quicinc.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_ajipan@quicinc.com \
--cc=quic_imrashai@quicinc.com \
--cc=quic_jkona@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).