From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Jagadeesh Kona <quic_jkona@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Cc: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Taniya Das <quic_tdas@quicinc.com>,
Satya Priya Kakitapalli <quic_skakitap@quicinc.com>,
Ajit Pandey <quic_ajipan@quicinc.com>,
Imran Shaik <quic_imrashai@quicinc.com>
Subject: Re: [PATCH V3 2/8] dt-bindings: clock: qcom: Add SM8650 video clock controller
Date: Wed, 1 May 2024 11:41:28 +0100 [thread overview]
Message-ID: <c55b7cdf-5ff2-42fb-8611-d9492f37d4b1@linaro.org> (raw)
In-Reply-To: <20240430142757.16872-3-quic_jkona@quicinc.com>
On 30/04/2024 15:27, Jagadeesh Kona wrote:
> SM8650 video clock controller has most clocks same as SM8450,
> but it also has few additional clocks and resets. Add device tree
> bindings for the video clock controller on Qualcomm SM8650 platform
> by defining these additional clocks and resets on top of SM8450.
>
> Signed-off-by: Jagadeesh Kona <quic_jkona@quicinc.com>
> ---
> .../bindings/clock/qcom,sm8450-videocc.yaml | 6 ++++-
> .../dt-bindings/clock/qcom,sm8650-videocc.h | 23 +++++++++++++++++++
> 2 files changed, 28 insertions(+), 1 deletion(-)
> create mode 100644 include/dt-bindings/clock/qcom,sm8650-videocc.h
>
> diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml
> index 78a1bb5be878..922e95c61778 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml
> @@ -8,18 +8,22 @@ title: Qualcomm Video Clock & Reset Controller on SM8450
>
> maintainers:
> - Taniya Das <quic_tdas@quicinc.com>
> + - Jagadeesh Kona <quic_jkona@quicinc.com>
>
> description: |
> Qualcomm video clock control module provides the clocks, resets and power
> domains on SM8450.
>
> - See also:: include/dt-bindings/clock/qcom,sm8450-videocc.h
> + See also::
> + include/dt-bindings/clock/qcom,sm8450-videocc.h
> + include/dt-bindings/clock/qcom,sm8650-videocc.h
>
> properties:
> compatible:
> enum:
> - qcom,sm8450-videocc
> - qcom,sm8550-videocc
> + - qcom,sm8650-videocc
>
> reg:
> maxItems: 1
> diff --git a/include/dt-bindings/clock/qcom,sm8650-videocc.h b/include/dt-bindings/clock/qcom,sm8650-videocc.h
> new file mode 100644
> index 000000000000..4e3c2d87280f
> --- /dev/null
> +++ b/include/dt-bindings/clock/qcom,sm8650-videocc.h
> @@ -0,0 +1,23 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> +/*
> + * Copyright (c) 2024, Qualcomm Innovation Center, Inc. All rights reserved.
> + */
> +
> +#ifndef _DT_BINDINGS_CLK_QCOM_VIDEO_CC_SM8650_H
> +#define _DT_BINDINGS_CLK_QCOM_VIDEO_CC_SM8650_H
> +
> +#include "qcom,sm8450-videocc.h"
> +
> +/* SM8650 introduces below new clocks and resets compared to SM8450 */
> +
> +/* VIDEO_CC clocks */
> +#define VIDEO_CC_MVS0_SHIFT_CLK 12
> +#define VIDEO_CC_MVS0C_SHIFT_CLK 13
> +#define VIDEO_CC_MVS1_SHIFT_CLK 14
> +#define VIDEO_CC_MVS1C_SHIFT_CLK 15
> +#define VIDEO_CC_XO_CLK_SRC 16
> +
> +/* VIDEO_CC resets */
> +#define VIDEO_CC_XO_CLK_ARES 7
> +
> +#endif
Extensibility +1
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
next prev parent reply other threads:[~2024-05-01 10:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 14:27 [PATCH V3 0/8] Add support for videocc and camcc on SM8650 Jagadeesh Kona
2024-04-30 14:27 ` [PATCH V3 1/8] dt-bindings: clock: qcom: Fix SM8450 videocc incorrect header file name Jagadeesh Kona
2024-05-01 10:18 ` Bryan O'Donoghue
2024-05-04 12:45 ` Krzysztof Kozlowski
2024-05-08 6:21 ` Jagadeesh Kona
2024-04-30 14:27 ` [PATCH V3 2/8] dt-bindings: clock: qcom: Add SM8650 video clock controller Jagadeesh Kona
2024-05-01 10:41 ` Bryan O'Donoghue [this message]
2024-05-04 12:46 ` Krzysztof Kozlowski
2024-04-30 14:27 ` [PATCH V3 3/8] clk: qcom: videocc-sm8550: Add support for videocc XO clk ares Jagadeesh Kona
2024-04-30 14:27 ` [PATCH V3 4/8] clk: qcom: videocc-sm8550: Add SM8650 video clock controller Jagadeesh Kona
2024-04-30 14:27 ` [PATCH V3 5/8] dt-bindings: clock: qcom: Fix the incorrect order of SC8280XP camcc header Jagadeesh Kona
2024-05-01 6:43 ` Johan Hovold
2024-05-02 11:09 ` Jagadeesh Kona
2024-05-01 10:42 ` Bryan O'Donoghue
2024-04-30 14:27 ` [PATCH V3 6/8] dt-bindings: clock: qcom: Add SM8650 camera clock controller Jagadeesh Kona
2024-04-30 14:27 ` [PATCH V3 7/8] clk: qcom: camcc-sm8650: Add SM8650 camera clock controller driver Jagadeesh Kona
2024-04-30 14:27 ` [PATCH V3 8/8] arm64: dts: qcom: sm8650: Add video and camera clock controllers Jagadeesh Kona
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c55b7cdf-5ff2-42fb-8611-d9492f37d4b1@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_ajipan@quicinc.com \
--cc=quic_imrashai@quicinc.com \
--cc=quic_jkona@quicinc.com \
--cc=quic_skakitap@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).