From: Chenghai Huang <huangchenghai2@huawei.com>
To: <herbert@gondor.apana.org.au>, <davem@davemloft.net>
Cc: <linux-kernel@vger.kernel.org>, <linux-crypto@vger.kernel.org>,
<fanghao11@huawei.com>, <liulongfang@huawei.com>,
<shenyang39@huawei.com>, <songzhiqi1@huawei.com>,
<qianweili@huawei.com>, <liushangbin@hisilicon.com>,
<linwenkai6@hisilicon.com>, <taoqi10@huawei.com>,
<wangzhou1@hisilicon.com>, <huangchenghai2@huawei.com>
Subject: [PATCH v2 9/9] crypto: hisilicon/qm - Add the err memory release process to qm uninit
Date: Sun, 7 Apr 2024 16:00:00 +0800 [thread overview]
Message-ID: <20240407080000.673435-10-huangchenghai2@huawei.com> (raw)
In-Reply-To: <20240407080000.673435-1-huangchenghai2@huawei.com>
When the qm uninit command is executed, the err data needs to
be released to prevent memory leakage. The error information
release operation and uacce_remove are integrated in
qm_remove_uacce.
So add the qm_remove_uacce to qm uninit to avoid err memory
leakage.
Signed-off-by: Chenghai Huang <huangchenghai2@huawei.com>
---
drivers/crypto/hisilicon/qm.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c
index cedb3af1fc1a..3dac8d8e8568 100644
--- a/drivers/crypto/hisilicon/qm.c
+++ b/drivers/crypto/hisilicon/qm.c
@@ -2896,12 +2896,9 @@ void hisi_qm_uninit(struct hisi_qm *qm)
hisi_qm_set_state(qm, QM_NOT_READY);
up_write(&qm->qps_lock);
+ qm_remove_uacce(qm);
qm_irqs_unregister(qm);
hisi_qm_pci_uninit(qm);
- if (qm->use_sva) {
- uacce_remove(qm->uacce);
- qm->uacce = NULL;
- }
}
EXPORT_SYMBOL_GPL(hisi_qm_uninit);
--
2.30.0
next prev parent reply other threads:[~2024-04-07 8:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-07 7:59 [PATCH v2 0/9] crypto: hisilicon - Optimize and fix some driver processes Chenghai Huang
2024-04-07 7:59 ` [PATCH v2 1/9] crypto: hisilicon/sec - Add the condition for configuring the sriov function Chenghai Huang
2024-04-07 7:59 ` [PATCH v2 2/9] crypto: hisilicon/debugfs - Fix debugfs uninit process issue Chenghai Huang
2024-04-07 7:59 ` [PATCH v2 3/9] crypto: hisilicon/sgl - Delete redundant parameter verification Chenghai Huang
2024-04-07 7:59 ` [PATCH v2 4/9] crypto: hisilicon/debugfs - Fix the processing logic issue in the debugfs creation Chenghai Huang
2024-04-07 7:59 ` [PATCH v2 5/9] crypto: hisilicon/qm - Add the default processing branch Chenghai Huang
2024-04-07 7:59 ` [PATCH v2 6/9] crypto: hisilicon - Adjust debugfs creation and release order Chenghai Huang
2024-04-07 7:59 ` [PATCH v2 7/9] crypto: hisilicon/sec - Fix memory leak for sec resource release Chenghai Huang
2024-04-07 7:59 ` [PATCH v2 8/9] crypto: hisilicon/debugfs - Resolve the problem of applying for redundant space in sq dump Chenghai Huang
2024-04-07 8:00 ` Chenghai Huang [this message]
2024-04-12 7:33 ` [PATCH v2 0/9] crypto: hisilicon - Optimize and fix some driver processes Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240407080000.673435-10-huangchenghai2@huawei.com \
--to=huangchenghai2@huawei.com \
--cc=davem@davemloft.net \
--cc=fanghao11@huawei.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linwenkai6@hisilicon.com \
--cc=liulongfang@huawei.com \
--cc=liushangbin@hisilicon.com \
--cc=qianweili@huawei.com \
--cc=shenyang39@huawei.com \
--cc=songzhiqi1@huawei.com \
--cc=taoqi10@huawei.com \
--cc=wangzhou1@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).