From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8771AC433EF for ; Mon, 3 Jan 2022 06:11:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231807AbiACGLl (ORCPT ); Mon, 3 Jan 2022 01:11:41 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:48070 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231804AbiACGLk (ORCPT ); Mon, 3 Jan 2022 01:11:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1641190300; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eZWdqglEJRBMyWOswue91QGGug+foo23E07h4yycLxk=; b=UoWwmUTCiOr4Q+ETUTbX7SuB9YDG70Acx/InccEsUaBN57qlBZ9fnR1CQtguM8eqER/inY nyCnZfgqksrUFsvmmBe4bpUVDeA4U713dcMOYPSNmCXJfPMjp3MuOkmGXdwEKSWMRRMhHZ VK4dcFRcZhPxG85cLQNe9ExCQBIAzO0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-607-jznnFRq4Ox2x6SNXuNadWw-1; Mon, 03 Jan 2022 01:11:36 -0500 X-MC-Unique: jznnFRq4Ox2x6SNXuNadWw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DB1321006AA9; Mon, 3 Jan 2022 06:11:33 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.193.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 76F497B9DB; Mon, 3 Jan 2022 06:11:30 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id C52A6180039F; Mon, 3 Jan 2022 07:11:27 +0100 (CET) Date: Mon, 3 Jan 2022 07:11:27 +0100 From: Gerd Hoffmann To: Niklas Schnelle Cc: Arnd Bergmann , Bjorn Helgaas , John Garry , Nick Hu , Greentime Hu , Vincent Chen , Paul Walmsley , Palmer Dabbelt , Albert Ou , Guo Ren , Dave Airlie , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-pci@vger.kernel.org, linux-riscv@lists.infradead.org, linux-csky@vger.kernel.org, virtualization@lists.linux-foundation.org, spice-devel@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [RFC 26/32] drm: handle HAS_IOPORT dependencies Message-ID: <20220103061127.jrnsfuxbxk2ywmtg@sirius.home.kraxel.org> References: <20211227164317.4146918-1-schnelle@linux.ibm.com> <20211227164317.4146918-27-schnelle@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211227164317.4146918-27-schnelle@linux.ibm.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Precedence: bulk List-ID: X-Mailing-List: linux-csky@vger.kernel.org On Mon, Dec 27, 2021 at 05:43:11PM +0100, Niklas Schnelle wrote: > In a future patch HAS_IOPORT=n will result in inb()/outb() and friends > not being declared. We thus need to add HAS_IOPORT as dependency for > those drivers using them. There is also a direct and hard coded use in > cirrus.c which according to the comment is only necessary during resume. > Let's just skip this as for example s390 which doesn't have I/O port > support also doesen't support suspend/resume. > config DRM_BOCHS > tristate "DRM Support for bochs dispi vga interface (qemu stdvga)" > depends on DRM && PCI && MMU > + depends on HAS_IOPORT > select DRM_KMS_HELPER > select DRM_VRAM_HELPER > select DRM_TTM On devices with an mmio bar the driver works just fine without inb/outb, see bochs->mmio checks in bochs.c take care, Gerd