From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4670C433F5 for ; Sun, 30 Jan 2022 14:58:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355305AbiA3O65 (ORCPT ); Sun, 30 Jan 2022 09:58:57 -0500 Received: from ams.source.kernel.org ([145.40.68.75]:58328 "EHLO ams.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345912AbiA3O6y (ORCPT ); Sun, 30 Jan 2022 09:58:54 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D2107B8296F; Sun, 30 Jan 2022 14:58:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B6C61C340E4; Sun, 30 Jan 2022 14:58:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643554730; bh=GL1zKW+fnVss13mOmdWWVRmOagcQ6XFxtwi7aOMdkXw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=iqwJ3iNFmreR4JSoSb4n27mVOKwAewuQXXOFGNk4buR2bUqeaXL0Pnz8qH7UMdbOL YVTNx/bXBnSh3ddVHi9MjxOyx4o56pVqJkaF5orz2suVUp6L7z7MNGvI9jwWDluvQM abfTwVqaEnksmOuCzx9B/LQOMLDwXIF0sgsiGg1/L/TgqCl5f0hfPSayS9WYnP1rNE Wf4xIlKEeKSB4bzDrcS6HvjQXQPUtiudZiKxLkmdfDy181KMyWBXUosw397yqxSx0e AcVsnpixAiVrsts7NdGblMAN8BclBYHagOWoUo+t4wO+G3vfpXR3yhnk9TmfX070XJ oaa3r6iUZCoWg== Date: Sun, 30 Jan 2022 15:05:10 +0000 From: Jonathan Cameron To: Niklas Schnelle Cc: Geert Uytterhoeven , Arnd Bergmann , Bjorn Helgaas , John Garry , Nick Hu , Greentime Hu , Vincent Chen , Paul Walmsley , Palmer Dabbelt , Albert Ou , Guo Ren , Lars-Peter Clausen , Linux Kernel Mailing List , Linux-Arch , linux-pci , linux-riscv , linux-csky@vger.kernel.org, linux-iio@vger.kernel.org, Michael Hennerich Subject: Re: [RFC 12/32] iio: adc: Kconfig: add HAS_IOPORT dependencies Message-ID: <20220130150510.66ea7cd4@jic23-huawei> In-Reply-To: <20211228170031.12dac755@jic23-huawei> References: <20211227164317.4146918-1-schnelle@linux.ibm.com> <20211227164317.4146918-13-schnelle@linux.ibm.com> <20211228170031.12dac755@jic23-huawei> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-csky@vger.kernel.org On Tue, 28 Dec 2021 17:01:25 +0000 Jonathan Cameron wrote: > On Tue, 28 Dec 2021 13:50:20 +0100 > Niklas Schnelle wrote: > > > On Tue, 2021-12-28 at 11:32 +0100, Geert Uytterhoeven wrote: > > > Hi Niklas, > > > > > > On Mon, Dec 27, 2021 at 5:53 PM Niklas Schnelle wrote: > > > > In a future patch HAS_IOPORT=n will result in inb()/outb() and friends > > > > not being declared. We thus need to add HAS_IOPORT as dependency for > > > > those drivers using them. > > > > > > > > Co-developed-by: Arnd Bergmann > > > > Signed-off-by: Arnd Bergmann > > > > Signed-off-by: Niklas Schnelle > > As a side note, whilst it doesn't always happen and I regularly forget > to fix it up whilst applying, it's really helpful to make sure the driver > name is somewhere in the patch title. > > e.g. iio: adc: ad7606: add HAS_IOPORT dependencies. > > > > > > > Thanks for your patch! > > > > > > > --- a/drivers/iio/adc/Kconfig > > > > +++ b/drivers/iio/adc/Kconfig > > > > @@ -119,7 +119,7 @@ config AD7606 > > > > > > > > config AD7606_IFACE_PARALLEL > > > > tristate "Analog Devices AD7606 ADC driver with parallel interface support" > > > > - depends on HAS_IOMEM > > > > + depends on HAS_IOPORT > > > > > > While this driver uses ins[bw](), this seems unrelated to legacy > > > I/O space, as the driver maps a MMIO region. Probably different > > > accessors should be used instead. > > > > You're right on first glance it looks like a misuse of the ins[bw]() > > accessors. I do wonder how that even works, if PCI_IOBASE is 0 it would > > result in readsw()/readsb() with presumably the correct address but no > > idea how this interacts witth x86's special I/O instructions. > > > > > > > > Note that this driver has no in-tree users. Same for the SPI variant, > > > but at least that one has modern json-schema DT bindings ;-) > > > > Can't find any mention in the MAINTAINERS file either. > > It falls under the Analog devices catch all. > We don't list them all individually because there are a lot of them and > it would just be noise in many case. > > Added Michael to CC. You already have Lars. > > ANALOG DEVICES INC IIO DRIVERS > M: Lars-Peter Clausen > M: Michael Hennerich > S: Supported > W: http://wiki.analog.com/ > W: http://ez.analog.com/community/linux-device-drivers > F: Documentation/ABI/testing/sysfs-bus-iio-frequency-ad9523 > F: Documentation/ABI/testing/sysfs-bus-iio-frequency-adf4350 > F: Documentation/devicetree/bindings/iio/*/adi,* > F: Documentation/devicetree/bindings/iio/dac/adi,ad5758.yaml > F: drivers/iio/*/ad* > F: drivers/iio/adc/ltc249* > F: drivers/iio/amplifiers/hmc425a.c > F: drivers/staging/iio/*/ad* > X: drivers/iio/*/adjd* > > https://wiki.analog.com/resources/tools-software/linux-drivers/iio-adc/ad7606 > includes some details. > > I'll leave it to the Lars or Michael to confirm what is going on here. Can someone (probably at Analog Devices) take a look at this? Thanks, Jonathan > > Jonathan > > > > > > > > > > select AD7606 > > > > help > > > > Say yes here to build parallel interface support for Analog Devices: > > > > > > Gr{oetje,eeting}s, > > > > > > Geert > > > > > > -- > > > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > > > > > In personal conversations with technical people, I call myself a hacker. But > > > when I'm talking to journalists I just say "programmer" or something like that. > > > -- Linus Torvalds > > >