From: Yang Li <yang.li85200@gmail.com>
To: guoren@kernel.org
Cc: linux-csky@vger.kernel.org, linux-kernel@vger.kernel.org,
Yang Li <yang.li85200@gmail.com>
Subject: [PATCH] csky: fix csky_cmpxchg_fixup not working
Date: Tue, 8 Oct 2024 13:46:15 +0800 [thread overview]
Message-ID: <20241008054615.43062-1-yang.li85200@gmail.com> (raw)
In the csky_cmpxchg_fixup function, using the global variable
csky_cmpxchg_stw to determine the address where the exception
occurred is incorrect. The global variable csky_cmpxchg_stw
stores the opcode at the time of the exception, while
&csky_cmpxchg_stw is the address where the exception occurred.
Signed-off-by: Yang Li <yang.li85200@gmail.com>
---
arch/csky/mm/fault.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/csky/mm/fault.c b/arch/csky/mm/fault.c
index a885518ce1dd..87ff26212261 100644
--- a/arch/csky/mm/fault.c
+++ b/arch/csky/mm/fault.c
@@ -45,8 +45,8 @@ static inline void csky_cmpxchg_fixup(struct pt_regs *regs)
if (trap_no(regs) != VEC_TLBMODIFIED)
return;
- if (instruction_pointer(regs) == csky_cmpxchg_stw)
- instruction_pointer_set(regs, csky_cmpxchg_ldw);
+ if (instruction_pointer(regs) == &csky_cmpxchg_stw)
+ instruction_pointer_set(regs, &csky_cmpxchg_ldw);
return;
}
#endif
--
2.34.1
next reply other threads:[~2024-10-08 5:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 5:46 Yang Li [this message]
2024-10-16 2:10 ` [PATCH] csky: fix csky_cmpxchg_fixup not working kernel test robot
2024-10-16 9:56 ` [PATCH v2] " Yang Li
2024-10-17 6:04 ` Guo Ren
[not found] ` <CA+N+=zu0=scmv9w7iZE2ZebxBVpvVb1eeoJ-qi=vhac-JhLthg@mail.gmail.com>
2024-10-18 8:46 ` yang li
2024-10-21 7:51 ` yang li
2024-10-28 2:54 ` Guo Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241008054615.43062-1-yang.li85200@gmail.com \
--to=yang.li85200@gmail.com \
--cc=guoren@kernel.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).