From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B84BEC4332F for ; Thu, 28 Oct 2021 21:59:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9FCD7610D2 for ; Thu, 28 Oct 2021 21:59:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231290AbhJ1WCT (ORCPT ); Thu, 28 Oct 2021 18:02:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230420AbhJ1WCS (ORCPT ); Thu, 28 Oct 2021 18:02:18 -0400 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26BA1C061745; Thu, 28 Oct 2021 14:59:51 -0700 (PDT) Received: by mail-lj1-x232.google.com with SMTP id q16so13195894ljg.3; Thu, 28 Oct 2021 14:59:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=7iQ4oU5lLihLvwqt++KnGQLKBiUKhW8mB9CMlvRrAlo=; b=A2gDnKnXbVmAEWSfC30h5AU4KgqctGREzx+w+qi3liDGTlzRRXf3E1jZyML8gNPqGK Li6mIZ0lXuGBdwOE60K0G95Tgukhjr9rRKc5cXQiD0w/VxhtL95meDusnxyabh4+EWGW r0TYt6OWs+PjfxzqoZ6eJ3DrcMZlu658BTNljXfs4JxLykUHrLNYB1GLE4vhnXR1mGD/ zsbBpAOKKFkkKsVx+h1bPiV6KMSfM+yc+Xd2DvoUE9RQ/ZfhiCHVvnICfk2iVe468EjX DSGsN20SLeM1V9+yNC6BNE7z4vvudCJzb443pi2WeFnCmYQbcFE9zeHCdAOjGieXrkv9 /UcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7iQ4oU5lLihLvwqt++KnGQLKBiUKhW8mB9CMlvRrAlo=; b=FvZdUfpTsH5BE2KB15qPwjJtVaXQkOf9wXEROZHAZPlbIibE/3RFskfC23YcbW0RiP eEvp5IJdUw/YEvFzJ/EWzBZfb50F52sNe2/VwZeJeIaNOoylqra1sKi0ZSbT8lb2gNRz Anyzotaq4/eFhP4iiOJ8X/zuAWjXXjMZ1WcYeEjcYgdlRWgpBRWFph0B6Fn7y1sa9/NH 21vLimdu0s0rS03GN+NytElILK8nGahJI+rlHAJjl2jF0IaGDOx9yPVRHR5Wg9kQvv95 uplZvk72lGmw4wacK7wTl0kKBp/auEvxcuh/lmW+/mFzerD1vuEVE+eA8PxxnliwPBrf jTOQ== X-Gm-Message-State: AOAM530JkNIs20xI+yv1zvjKU0p7ErOAXAbuWbt2Mu/gfg2SjalV1pPy T13EiwnOKjJc9AAB3CSEzIlUyF7cuoc= X-Google-Smtp-Source: ABdhPJxS5C9pTHHcX2SeZO1OzU/OwueG01d90Y/t9QArtk4xiAh7ZBD5U7QFitj+IF+gde/bz4TCKA== X-Received: by 2002:a2e:9d93:: with SMTP id c19mr7265789ljj.363.1635458389307; Thu, 28 Oct 2021 14:59:49 -0700 (PDT) Received: from [192.168.2.145] (46-138-44-18.dynamic.spd-mgts.ru. [46.138.44.18]) by smtp.googlemail.com with ESMTPSA id e12sm398160ljp.30.2021.10.28.14.59.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Oct 2021 14:59:49 -0700 (PDT) Subject: Re: [PATCH v2 08/45] kernel: Add combined power-off+restart handler call chain API To: "Rafael J. Wysocki" Cc: Thierry Reding , Jonathan Hunter , Lee Jones , Mark Brown , Andrew Morton , Guenter Roeck , Russell King , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , Catalin Marinas , Will Deacon , Guo Ren , Geert Uytterhoeven , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , the arch/x86 maintainers , "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Linus Walleij , Chen-Yu Tsai , =?UTF-8?Q?Jonathan_Neusch=c3=a4fer?= , Tony Lindgren , Liam Girdwood , Philipp Zabel , Vladimir Zapolskiy , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Pavel Machek , Linux ARM , Linux Kernel Mailing List , linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev , linux-riscv@lists.infradead.org, Linux-sh list , xen-devel@lists.xenproject.org, ACPI Devel Maling List , Linux OMAP Mailing List , openbmc@lists.ozlabs.org, linux-tegra , Linux PM References: <20211027211715.12671-1-digetx@gmail.com> <20211027211715.12671-9-digetx@gmail.com> From: Dmitry Osipenko Message-ID: <31547403-969e-91a9-0792-6fd657b78503@gmail.com> Date: Fri, 29 Oct 2021 00:59:46 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-csky@vger.kernel.org 28.10.2021 12:59, Rafael J. Wysocki пишет: >> +/** >> + * struct power_handler - Machine power-off + restart handler >> + * >> + * Describes power-off and restart handlers which are invoked by kernel >> + * to power off or restart this machine. Supports prioritized chaining for >> + * both restart and power-off handlers. Callback's priority must be unique. >> + * Intended to be used by device drivers that are responsible for restarting >> + * and powering off hardware which kernel is running on. >> + * >> + * Struct power_handler can be static. Members of this structure must not be >> + * altered while handler is registered. >> + * >> + * Fill the structure members and pass it to register_power_handler(). >> + */ >> +struct power_handler { >> + /** >> + * @cb_data: >> + * >> + * User data included in callback's argument. >> + */ > And here I would document the structure fields in the main kerneldoc > comment above. > > As is, it is a bit hard to grasp the whole definition. > I'll move the comments in v3, thanks.