From: Aradhya Bhatia <a-bhatia1@ti.com>
To: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Tomi Valkeinen <tomba@kernel.org>, Jyri Sarha <jyri.sarha@iki.fi>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Thierry Reding <thierry.reding@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>,
Maxime Ripard <maxime@cerno.tech>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Matthias Brugger <matthias.bgg@gmail.com>,
Guo Ren <guoren@kernel.org>
Cc: DRI Development List <dri-devel@lists.freedesktop.org>,
Devicetree List <devicetree@vger.kernel.org>,
Linux Kernel List <linux-kernel@vger.kernel.org>,
Linux RISC-V List <linux-riscv@lists.infradead.org>,
Linux ARM Kernel List <linux-arm-kernel@lists.infradead.org>,
Linux Mediatek List <linux-mediatek@lists.infradead.org>,
Linux C-SKY Arch List <linux-csky@vger.kernel.org>,
Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
Rahul T R <r-ravikumar@ti.com>, Devarsh Thakkar <devarsht@ti.com>,
Jai Luthra <j-luthra@ti.com>,
Jayesh Choudhary <j-choudhary@ti.com>
Subject: Re: [RFC PATCH 3/4] dt-bindings: panel: Introduce dual-link LVDS panel
Date: Mon, 9 Jan 2023 21:51:00 +0530 [thread overview]
Message-ID: <431ddd82-055b-2526-3d5e-f6563e48d264@ti.com> (raw)
In-Reply-To: <09f1ca83-c7d5-a186-6fa6-09cdd7a0b9cc@collabora.com>
Hi Angelo,
Thanks for taking a look at the patches!
On 03-Jan-23 17:21, AngeloGioacchino Del Regno wrote:
> Il 03/01/23 07:46, Aradhya Bhatia ha scritto:
>> Dual-link LVDS interfaces have 2 links, with even pixels traveling on
>> one link, and odd pixels on the other. These panels are also generic in
>> nature, with no documented constraints, much like their single-link
>> counterparts, "panel-lvds".
>>
>> Add a new compatible, "panel-dual-lvds", and a dt-binding document for
>> these panels.
>>
>> Signed-off-by: Aradhya Bhatia <a-bhatia1@ti.com>
>> ---
>> .../display/panel/panel-dual-lvds.yaml | 157 ++++++++++++++++++
>> MAINTAINERS | 1 +
>> 2 files changed, 158 insertions(+)
>> create mode 100644
>> Documentation/devicetree/bindings/display/panel/panel-dual-lvds.yaml
>>
>> diff --git
>> a/Documentation/devicetree/bindings/display/panel/panel-dual-lvds.yaml
>> b/Documentation/devicetree/bindings/display/panel/panel-dual-lvds.yaml
>> new file mode 100644
>> index 000000000000..88a7aa2410be
>> --- /dev/null
>> +++
>> b/Documentation/devicetree/bindings/display/panel/panel-dual-lvds.yaml
>> @@ -0,0 +1,157 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/display/panel/panel-dual-lvds.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Generic Dual-Link LVDS Display Panel
>> +
>> +maintainers:
>> + - Aradhya Bhatia <a-bhatia1@ti.com>
>> + - Thierry Reding <thierry.reding@gmail.com>
>> +
>> +description: |
>> + A dual-LVDS interface is a dual-link connection with the even pixels
>> + traveling on one link, and the odd pixels traveling on the other.
>> +
>> +allOf:
>> + - $ref: panel-common.yaml#
>> + - $ref: /schemas/display/lvds.yaml/#
>> +
>> +properties:
>> + compatible:
>> + oneOf:
>> + - items:
>> + - enum:
>> + - lincolntech,lcd185-101ct
>> + - microtips,13-101hieb0hf0-s
>> + - const: panel-dual-lvds
>> + - const: panel-dual-lvds
>> +
>> + ports:
>> + $ref: /schemas/graph.yaml#/properties/ports
>> +
>> + properties:
>> + port@0:
>> + $ref: /schemas/graph.yaml#/$defs/port-base
>> + unevaluatedProperties: false
>> + description: The sink for first set of LVDS pixels.
>> +
>> + properties:
>> + dual-lvds-odd-pixels:
>> + type: boolean
>> +
>> + dual-lvds-even-pixels:
>> + type: boolean
>> +
>> + oneOf:
>> + - required: [dual-lvds-odd-pixels]
>
> One question: why do we need a "panel-dual-lvds" compatible?
> A Dual-LVDS panel is a LVDS panel using two ports, hence still a panel-lvds.
>
> If you're doing this to clearly distinguish, for human readability purposes,
> single-link vs dual-link panels, I think that this would still be clear even
> if we use panel-lvds alone because dual-link panels, as you wrote in this
> binding, does *require* two ports, with "dual-lvds-{odd,even}-pixels" properties.
Yes, while they are both LVDS based panels the extra LVDS sink in these
panels, and the capability to decode and display the 2 sets of signals
are enough hardware differences that warrant for an addition of a new
compatible.
>
> So... the devicetree node would look like this:
>
> panel {
> compatible = "vendor,panel", "panel-lvds";
> ....
> ports {
> port@0 {
> .....
> -> dual-lvds-odd-pixels <-
> }
>
> port@1 {
> .....
> -> dual-lvds-even-pixels <-
> };
> };
> };
>
>> + - required: [dual-lvds-even-pixels]
>
> ...Though, if you expect dual-lvds panels to get other quirks in the future,
> that's a whole different story and you may actually need the panel-dual-lvds
> compatible.
Yes, exactly. Even while being non-smart, there are going to be more
quirks in future. And it would be better if they have their own
compatible/binding, and are not getting appended in an ever-growing
if-else ladder. :)
Regards
Aradhya
next prev parent reply other threads:[~2023-01-09 16:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 6:46 [RFC PATCH 0/4] dt-bindings: Introduce dual-link panels & panel-vendors Aradhya Bhatia
2023-01-03 6:46 ` [RFC PATCH 1/4] dt-bindings: vendor-prefixes: Add microtips Aradhya Bhatia
2023-01-03 8:21 ` Krzysztof Kozlowski
2023-01-08 7:02 ` Laurent Pinchart
2023-01-03 6:46 ` [RFC PATCH 2/4] dt-bindings: vendor-prefixes: Add lincolntech Aradhya Bhatia
2023-01-03 8:22 ` Krzysztof Kozlowski
2023-01-08 7:03 ` Laurent Pinchart
2023-01-03 6:46 ` [RFC PATCH 3/4] dt-bindings: panel: Introduce dual-link LVDS panel Aradhya Bhatia
2023-01-03 8:32 ` Krzysztof Kozlowski
2023-01-03 11:02 ` Aradhya Bhatia
2023-01-03 11:28 ` Krzysztof Kozlowski
2023-01-09 15:49 ` Aradhya Bhatia
2023-01-03 11:51 ` AngeloGioacchino Del Regno
2023-01-09 16:21 ` Aradhya Bhatia [this message]
2023-01-17 12:38 ` Tomi Valkeinen
2023-01-20 4:58 ` Aradhya Bhatia
2023-01-08 6:56 ` Laurent Pinchart
2023-01-09 16:44 ` Aradhya Bhatia
2023-01-03 6:46 ` [RFC PATCH 4/4] drm: panel-lvds: Introduce dual-link panels Aradhya Bhatia
2023-01-16 9:30 ` [RFC PATCH 0/4] dt-bindings: Introduce dual-link panels & panel-vendors Laurent Pinchart
2023-01-17 10:26 ` Aradhya Bhatia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=431ddd82-055b-2526-3d5e-f6563e48d264@ti.com \
--to=a-bhatia1@ti.com \
--cc=airlied@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=aou@eecs.berkeley.edu \
--cc=broonie@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devarsht@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=guoren@kernel.org \
--cc=j-choudhary@ti.com \
--cc=j-luthra@ti.com \
--cc=jyri.sarha@iki.fi \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-riscv@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=maxime@cerno.tech \
--cc=nm@ti.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=r-ravikumar@ti.com \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
--cc=tomba@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).