From: Guo Ren <guoren@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
"linux-csky@vger.kernel.org" <linux-csky@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] csky: fix old style declaration in module.c
Date: Sat, 29 Jul 2023 19:19:12 -0400 [thread overview]
Message-ID: <CAJF2gTRMZkT=CE0=g25Hfe7v9_GE8UmqhKBP1vsXd06w+9NBiQ@mail.gmail.com> (raw)
In-Reply-To: <fc2b139b-909b-46d7-abbc-7ab287c9d06d@app.fastmail.com>
On Sat, Jul 29, 2023 at 4:05 AM Arnd Bergmann <arnd@kernel.org> wrote:
>
> On Sat, Jul 29, 2023, at 09:06, Arnd Bergmann wrote:
> > On Sat, Jul 29, 2023, at 06:59, Guo Ren wrote:
>
> > I'd like to enable a few warning options (-Wextra, -Wrestrict,
> > -Wmissing-prototypes, ...) in the Kbuild for 6.6, but the Makefile
> > changes will probably go through the Kbuild tree or linux-mm,
> > and the fixes for existing warnings can just take their normal way.
>
> I just checked my log files again and I now see that there
> are actually a number of -Wcc warnings as well:
>
> csky/kernel/signal.c:255:17: error: no previous prototype for 'do_notify_resume' [-Werror=missing-prototypes]
> csky/mm/fault.c:187:17: error: no previous prototype for 'do_page_fault' [-Werror=missing-prototypes]
> csky/kernel/traps.c:57:13: error: no previous prototype for 'trap_init' [-Werror=missing-prototypes]
> csky/kernel/traps.c:150:15: error: no previous prototype for 'do_trap_unknown' [-Werror=missing-prototypes]
> csky/kernel/traps.c:152:15: error: no previous prototype for 'do_trap_zdiv' [-Werror=missing-prototypes]
> csky/kernel/traps.c:154:15: error: no previous prototype for 'do_trap_buserr' [-Werror=missing-prototypes]
> csky/kernel/traps.c:157:17: error: no previous prototype for 'do_trap_misaligned' [-Werror=missing-prototypes]
> csky/kernel/traps.c:168:17: error: no previous prototype for 'do_trap_bkpt' [-Werror=missing-prototypes]
> csky/kernel/traps.c:187:17: error: no previous prototype for 'do_trap_illinsn' [-Werror=missing-prototypes]
> csky/kernel/traps.c:210:17: error: no previous prototype for 'do_trap_fpe' [-Werror=missing-prototypes]
> csky/kernel/traps.c:220:17: error: no previous prototype for 'do_trap_priv' [-Werror=missing-prototypes]
> csky/kernel/traps.c:230:17: error: no previous prototype for 'trap_c' [-Werror=missing-prototypes]
> csky/kernel/vdso/vgettimeofday.c:6:5: error: no previous prototype for '__vdso_clock_gettime' [-Werror=missing-prototypes]
> csky/kernel/vdso/vgettimeofday.c:12:5: error: no previous prototype for '__vdso_clock_gettime64' [-Werror=missing-prototypes]
> csky/kernel/vdso/vgettimeofday.c:18:5: error: no previous prototype for '__vdso_gettimeofday' [-Werror=missing-prototypes]
> csky/kernel/vdso/vgettimeofday.c:24:5: error: no previous prototype for '__vdso_clock_getres' [-Werror=missing-prototypes]
> csky/kernel/setup.c:104:34: error: no previous prototype for 'csky_start' [-Werror=missing-prototypes]
> csky/kernel/ptrace.c:320:16: error: no previous prototype for 'syscall_trace_enter' [-Werror=missing-prototypes]
> csky/kernel/ptrace.c:336:17: error: no previous prototype for 'syscall_trace_exit' [-Werror=missing-prototypes]
>
> I missed these as I was first looking at everything except
> -Wmissing-prototypes that I want to enable. Can you perhaps
> help out and create a fix for these yourself?
Okay, I'll check
>
> Arnd
--
Best Regards
Guo Ren
next prev parent reply other threads:[~2023-07-29 23:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 14:57 [PATCH] csky: fix old style declaration in module.c Arnd Bergmann
2023-07-29 4:59 ` Guo Ren
2023-07-29 7:06 ` Arnd Bergmann
2023-07-29 8:04 ` Arnd Bergmann
2023-07-29 23:19 ` Guo Ren [this message]
2023-07-29 23:18 ` Guo Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJF2gTRMZkT=CE0=g25Hfe7v9_GE8UmqhKBP1vsXd06w+9NBiQ@mail.gmail.com' \
--to=guoren@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).