From: Fangrui Song <i@maskray.me>
To: Xi Ruoyao <xry111@xry111.site>
Cc: Huacai Chen <chenhuacai@kernel.org>, Guo Ren <guoren@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
WANG Xuerui <kernel@xen0n.name>,
Masahiro Yamada <masahiroy@kernel.org>,
Tiezhu Yang <yangtiezhu@loongson.cn>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
loongarch@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-csky@vger.kernel.org,
linux-arch@vger.kernel.org
Subject: Re: [PATCH] LoongArch: vDSO: Remove --hash-style=sysv
Date: Fri, 21 Feb 2025 09:45:40 -0800 [thread overview]
Message-ID: <CAN30aBEhnR1OJycVs+F43ocJ6Vyh=Et2r+wo5cWwrtV4x-+zcg@mail.gmail.com> (raw)
In-Reply-To: <CAAhV-H4rDXDnzJwUE6PXMyuNGTs1NwUzQDP5eAPMmaHpqftP-Q@mail.gmail.com>
On Fri, Feb 21, 2025 at 2:26 AM Huacai Chen <chenhuacai@kernel.org> wrote:
>
> On Fri, Feb 21, 2025 at 6:23 PM Xi Ruoyao <xry111@xry111.site> wrote:
> >
> > On Fri, 2025-02-21 at 17:47 +0800, Huacai Chen wrote:
> > > Hi, Ruoyao,
> > >
> > > On Fri, Feb 21, 2025 at 5:25 PM Xi Ruoyao <xry111@xry111.site> wrote:
> > > >
> > > > glibc added support for .gnu.hash in 2006 and .hash has been obsoleted
> > > > far before the first LoongArch CPU was taped. Using
> > > > --hash-style=sysv might imply unaddressed issues and confuse readers.
> > > >
> > > > In the past we really had an unaddressed issue: the vdso selftests did
> > > > not know how to process .gnu.hash. But it has been addressed by commit
> > > > e0746bde6f82 ("selftests/vDSO: support DT_GNU_HASH") now.
> > > >
> > > > Just drop the option and rely on the linker default, which is likely
> > > > "both" (AOSC) or "gnu" (Arch, Debian, Gentoo, LFS) on all LoongArch
> > > > distros.
> > > What about changing to "--hash-style=both" as most architectures do?
> >
> > IMO we are more close to ARM64 for the aspect that there are no libc
> > (glibc or musl) releases lacking GNU hash support, so I prefer the ARM64
> > way.
> >
> > Maybe this should be changed for some of other architectures (RISC-V and
> > C-SKY?) as well because I guess the only reason they used "both" was
> > "hey, without this the self tests don't work on Debian" but this is
> > resolved now. Adding a few recipients and Cc for discussion.
> OK, maybe we can change it for RISC-V/C-SKY and see what they will.
>
> Huacai
>
> >
> > --
> > Xi Ruoyao <xry111@xry111.site>
> > School of Aerospace Science and Technology, Xidian University
Agreed that as selftests has been fixed, --hash-style=sysv can be
removed from more arches.
arch/arm64/kernel/vdso/Makefile has already removed the option.
(
I probably should add more information to
https://maskray.me/blog/2022-08-21-glibc-and-dt-gnu-hash :)
)
prev parent reply other threads:[~2025-02-21 17:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250221092523.85632-1-xry111@xry111.site>
[not found] ` <CAAhV-H5_bKtO2mAFmfcZvD0pn9RhTA+UPjv7K574uPKxZbxX=g@mail.gmail.com>
2025-02-21 10:23 ` [PATCH] LoongArch: vDSO: Remove --hash-style=sysv Xi Ruoyao
2025-02-21 10:26 ` Huacai Chen
2025-02-21 17:45 ` Fangrui Song [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAN30aBEhnR1OJycVs+F43ocJ6Vyh=Et2r+wo5cWwrtV4x-+zcg@mail.gmail.com' \
--to=i@maskray.me \
--cc=Jason@zx2c4.com \
--cc=chenhuacai@kernel.org \
--cc=guoren@kernel.org \
--cc=kernel@xen0n.name \
--cc=linux-arch@vger.kernel.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=loongarch@lists.linux.dev \
--cc=masahiroy@kernel.org \
--cc=palmer@dabbelt.com \
--cc=xry111@xry111.site \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).