From: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
To: German Gomez <german.gomez@arm.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-perf-users@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@kernel.org>,
John Garry <john.garry@huawei.com>, Will Deacon <will@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Leo Yan <leo.yan@linaro.org>, Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH v2 0/3] Support register names of all architectures
Date: Tue, 14 Dec 2021 14:20:26 +0530 [thread overview]
Message-ID: <EAC4AC1D-A305-42E2-B22F-8B64B0968841@linux.vnet.ibm.com> (raw)
In-Reply-To: <20211207180653.1147374-1-german.gomez@arm.com>
> On 07-Dec-2021, at 11:36 PM, German Gomez <german.gomez@arm.com> wrote:
>
> The following changeset applies some corrections to the way system
> registers are processed and presented when reading perf.data files using
> the various perf tools.
>
> The commit message from [3/3] shows how register names aren't correctly
> presented when performing x-arch analysis of perf.data files (recording
> in one arch, then reading the file from a different arch).
>
> - [PATCH 1/3] Fixes a potential out-of-bounds access when reading the
> values of the registers in the perf.data file.
> - [PATCH 2/3] Fixes an issue of ARM and ARM64 registers having the
> same enum name.
> - [PATCH 3/3] Refactors the function "perf_reg_name" declared in the
> "tools/perf/util/perf_regs.h" header, in order to support every arch.
>
> Thanks,
> German
Looks good to me. Tested this patchset in powerpc by capturing regs in powerpc and doing
perf report to read the data from x86.
Reviewed-and-Tested-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
>
> --
> Changes since v1
>
> - Added "Reported-by" tags.
> - Removed [PATCH 2/4] because it's not needed (suggested by Athira
> Rajeev).
> - Removed [PATCH 3/4] which created additional header files with the
> register names of every arch.
> - Introduced [PATCH 2/3] to deal with ARM and ARM64 registers having the
> same enum name across "/tools/perf/".
> - Reworked the refactor of "perf_reg_name" function (now implemented in
> perf_regs.c, rather than in the header file) in [PATCH 3/3].
>
> German Gomez (3):
> perf tools: Prevent out-of-bounds access to registers
> perf tools: Rename perf_event_arm_regs for ARM64 registers
> perf tools: Support register names from all archs
>
> tools/perf/arch/arm/include/perf_regs.h | 42 --
> tools/perf/arch/arm64/include/perf_regs.h | 78 +-
> tools/perf/arch/csky/include/perf_regs.h | 82 ---
> tools/perf/arch/mips/include/perf_regs.h | 69 --
> tools/perf/arch/powerpc/include/perf_regs.h | 66 --
> tools/perf/arch/riscv/include/perf_regs.h | 74 --
> tools/perf/arch/s390/include/perf_regs.h | 78 --
> tools/perf/arch/x86/include/perf_regs.h | 82 ---
> tools/perf/builtin-script.c | 18 +-
> tools/perf/util/event.h | 5 +-
> tools/perf/util/libunwind/arm64.c | 2 +
> tools/perf/util/perf_regs.c | 671 +++++++++++++++++-
> tools/perf/util/perf_regs.h | 10 +-
> .../scripting-engines/trace-event-python.c | 10 +-
> tools/perf/util/session.c | 25 +-
> 15 files changed, 709 insertions(+), 603 deletions(-)
>
> --
> 2.25.1
>
next prev parent reply other threads:[~2021-12-14 8:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 18:06 [PATCH v2 0/3] Support register names of all architectures German Gomez
2021-12-07 18:06 ` [PATCH v2 1/3] perf tools: Prevent out-of-bounds access to registers German Gomez
2021-12-07 18:06 ` [PATCH v2 2/3] perf tools: Rename perf_event_arm_regs for ARM64 registers German Gomez
2021-12-07 18:06 ` [PATCH v2 3/3] perf tools: Support register names from all archs German Gomez
2021-12-08 11:51 ` John Garry
2021-12-08 13:55 ` German Gomez
2021-12-10 15:21 ` German Gomez
2021-12-14 8:50 ` Athira Rajeev [this message]
2021-12-14 13:26 ` [PATCH v2 0/3] Support register names of all architectures Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EAC4AC1D-A305-42E2-B22F-8B64B0968841@linux.vnet.ibm.com \
--to=atrajeev@linux.vnet.ibm.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=german.gomez@arm.com \
--cc=john.garry@huawei.com \
--cc=jolsa@redhat.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=namhyung@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).