From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC9C6C4332F for ; Fri, 10 Dec 2021 18:56:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245502AbhLJTAM (ORCPT ); Fri, 10 Dec 2021 14:00:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241978AbhLJTAL (ORCPT ); Fri, 10 Dec 2021 14:00:11 -0500 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF957C0617A1; Fri, 10 Dec 2021 10:56:35 -0800 (PST) Received: by mail-lf1-x134.google.com with SMTP id l22so19685256lfg.7; Fri, 10 Dec 2021 10:56:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=OLTFQmX2Kf2e3cZmLG4jxsS1bq2aSoDXpxl5QnKq9FU=; b=lRJVrFA11Fu94g9aC4quIzKTIJBQHb56jvC3UHQRYxQnYMhhiqHXe+HNIaU6izZboH h0BDFCIwI4bVAz64DQVVsH0MSKsIo5r3rhYcpSgEs+F8SRLOvGUk6MezYqtprOuHSHY+ xZjhnDgdSP0x9ihrSMtshGYvbNVvxVMeCabfWJNzXp5+bcL+U+5yCBZgtjUoQy5c5Srk XvThuXHF65j6/Qpyivd03hsOvMnXYmDchKWNvnb9km4xj+cql2CnI3JZSdhbiWgBDsX+ pJV/q1mj1vSBgnFw5Nf3SQ1PcuWrLHkWB0ABMsx7hJcTqhLbY3gqIMN0WZdDvJ/sUnhK zo7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=OLTFQmX2Kf2e3cZmLG4jxsS1bq2aSoDXpxl5QnKq9FU=; b=Q1GLxFfAUEPBIIhuM8TEPDqE2XBQpUMpmIIlurLGQNZaJ93U8VmIIhzpfFXcIrR+vg 5daJGT8PnPDcFEBr897JOQ+U8X3Th2t6utx1WH8NiV6H6/yxeNeXnvys/R5MJmulgM2A 3FsGM2Qsf0AowfljlHMUkMFvQQk91Qi9Gryj6gL0vM5TXHlUbULgeVeNbSROwrRtYgsj X3oi3BmGRBzFvLAbbkt1oqV7y34lsDtEIL2XDUQMr2Re9RyIXV5gImGpEGpVHMIsgQSG tgPURlArPITBdm89JnMD8Rc4GDaSCSAvlZgPyk6xtlADPpE5BoM6zspzlkqecY3DUBbo jD4g== X-Gm-Message-State: AOAM530IgeiafV2hhU29QZNMQqpQy75i4GFqaB4j2Emiiz3EmlVoYj4C 5fRrBZCZCG8b6JOcH7h4YkkHzRvIjfk= X-Google-Smtp-Source: ABdhPJx4BKlEbZ+Eghk+XJYmXdOJaHtYRLuIKsc/RB19AF8hnZocVzO0VkIjSpmfvEqny0BWm7yDgw== X-Received: by 2002:ac2:5101:: with SMTP id q1mr8849810lfb.319.1639162594092; Fri, 10 Dec 2021 10:56:34 -0800 (PST) Received: from [192.168.2.145] (94-29-46-111.dynamic.spd-mgts.ru. [94.29.46.111]) by smtp.googlemail.com with ESMTPSA id b10sm416126lfj.230.2021.12.10.10.56.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Dec 2021 10:56:33 -0800 (PST) Subject: Re: [PATCH v4 07/25] reboot: Remove extern annotation from function prototypes To: "Rafael J. Wysocki" Cc: Thierry Reding , Jonathan Hunter , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Geert Uytterhoeven , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Sebastian Reichel , Linus Walleij , Philipp Zabel , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , the arch/x86 maintainers , "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Pavel Machek , Lee Jones , Andrew Morton , Guenter Roeck , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , alankao@andestech.com, "K . C . Kuen-Chern Lin" , Linux ARM , Linux Kernel Mailing List , linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev , linux-riscv@lists.infradead.org, Linux-sh list , xen-devel@lists.xenproject.org, ACPI Devel Maling List , Linux PM , linux-tegra References: <20211126180101.27818-1-digetx@gmail.com> <20211126180101.27818-8-digetx@gmail.com> From: Dmitry Osipenko Message-ID: Date: Fri, 10 Dec 2021 21:56:31 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-csky@vger.kernel.org 10.12.2021 21:35, Rafael J. Wysocki пишет: > On Fri, Dec 10, 2021 at 7:16 PM Dmitry Osipenko wrote: >> >> 10.12.2021 21:09, Rafael J. Wysocki пишет: >>> On Fri, Nov 26, 2021 at 7:02 PM Dmitry Osipenko wrote: >>>> >>>> There is no need to annotate function prototypes with 'extern', it makes >>>> code less readable. Remove unnecessary annotations from . >>>> >>>> Signed-off-by: Dmitry Osipenko >>> >>> I'm not sure that this is really useful. >>> >>> Personally, I tend to respect the existing conventions like this. >>> >>> Surely, this change is not required for the rest of the series to work. >> >> Problem that such things start to spread all over the kernel with a >> copy-paste approach if there is nobody to clean up the code. >> >> This is not a common convention and sometimes it's getting corrected [1]. >> >> [1] https://git.kernel.org/linus/6d7434931 > > In separate patches outside of series adding new features, if one is > so inclined. > Alright, I'll drop this patch then because it can't be done in parallel without creating the merge conflict. I'll try not to forget to come back to this later on.