* [PATCH] cxl/cxl-event: include missing <linux/types.h> and <linux/uuid.h>
@ 2024-04-17 3:50 Sangyun Kim
2024-04-18 22:02 ` Ira Weiny
0 siblings, 1 reply; 2+ messages in thread
From: Sangyun Kim @ 2024-04-17 3:50 UTC (permalink / raw
To: linux-cxl
Cc: Davidlohr Bueso, Jonathan Cameron, Dave Jiang, Alison Schofield,
Vishal Verma, Ira Weiny, Dan Williams, Sangyun Kim
The linux/cxl-event.h header file uses the u8, u16, and uuid_t types,
but it doesn't include the necessary header files,
<linux/types.h> and <linux/uuid.h>.
Currently, cxl-event.h is only used by drivers/cxl/cxlmem.h,
and it doesn't cause any errors because cxlmem.h indirectly
includes the required types.
However, cxl-event.h may be used by other CXL-related code in the future,
so it's important to fix this issue by including the missing header files
directly in cxl-event.h.
Signed-off-by: Sangyun Kim <sangyun.kim@snu.ac.kr>
---
include/linux/cxl-event.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/linux/cxl-event.h b/include/linux/cxl-event.h
index 03fa6d50d46f..812ed16ffc2f 100644
--- a/include/linux/cxl-event.h
+++ b/include/linux/cxl-event.h
@@ -3,6 +3,9 @@
#ifndef _LINUX_CXL_EVENT_H
#define _LINUX_CXL_EVENT_H
+#include <linux/types.h>
+#include <linux/uuid.h>
+
/*
* Common Event Record Format
* CXL rev 3.0 section 8.2.9.2.1; Table 8-42
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] cxl/cxl-event: include missing <linux/types.h> and <linux/uuid.h>
2024-04-17 3:50 [PATCH] cxl/cxl-event: include missing <linux/types.h> and <linux/uuid.h> Sangyun Kim
@ 2024-04-18 22:02 ` Ira Weiny
0 siblings, 0 replies; 2+ messages in thread
From: Ira Weiny @ 2024-04-18 22:02 UTC (permalink / raw
To: Sangyun Kim, linux-cxl
Cc: Davidlohr Bueso, Jonathan Cameron, Dave Jiang, Alison Schofield,
Vishal Verma, Ira Weiny, Dan Williams, Sangyun Kim
Sangyun Kim wrote:
> The linux/cxl-event.h header file uses the u8, u16, and uuid_t types,
> but it doesn't include the necessary header files,
> <linux/types.h> and <linux/uuid.h>.
>
> Currently, cxl-event.h is only used by drivers/cxl/cxlmem.h,
> and it doesn't cause any errors because cxlmem.h indirectly
> includes the required types.
>
> However, cxl-event.h may be used by other CXL-related code in the future,
> so it's important to fix this issue by including the missing header files
> directly in cxl-event.h.
>
> Signed-off-by: Sangyun Kim <sangyun.kim@snu.ac.kr>
I pointed this out before.
https://lore.kernel.org/all/20240228-cxl-cper3-v1-1-6aa3f1343c6c@intel.com/
Dan suggested a fixes tag. I did not think it was technically required
but it would be nice. Regardless.
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> ---
> include/linux/cxl-event.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/linux/cxl-event.h b/include/linux/cxl-event.h
> index 03fa6d50d46f..812ed16ffc2f 100644
> --- a/include/linux/cxl-event.h
> +++ b/include/linux/cxl-event.h
> @@ -3,6 +3,9 @@
> #ifndef _LINUX_CXL_EVENT_H
> #define _LINUX_CXL_EVENT_H
>
> +#include <linux/types.h>
> +#include <linux/uuid.h>
> +
> /*
> * Common Event Record Format
> * CXL rev 3.0 section 8.2.9.2.1; Table 8-42
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-18 22:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-17 3:50 [PATCH] cxl/cxl-event: include missing <linux/types.h> and <linux/uuid.h> Sangyun Kim
2024-04-18 22:02 ` Ira Weiny
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).