* Re:
2023-01-27 1:59 ` Dan Williams
@ 2023-01-27 16:10 ` Alison Schofield
2023-01-27 19:16 ` Re: Dan Williams
0 siblings, 1 reply; 16+ messages in thread
From: Alison Schofield @ 2023-01-27 16:10 UTC (permalink / raw
To: Dan Williams
Cc: Ira Weiny, Vishal Verma, Dave Jiang, Ben Widawsky, Steven Rostedt,
linux-cxl, linux-kernel
On Thu, Jan 26, 2023 at 05:59:03PM -0800, Dan Williams wrote:
> alison.schofield@ wrote:
> > From: Alison Schofield <alison.schofield@intel.com>
> >
> > Subject: [PATCH v5 0/5] CXL Poison List Retrieval & Tracing
> >
> > Changes in v5:
> > - Rebase on cxl/next
> > - Use struct_size() to calc mbox cmd payload .min_out
> > - s/INTERNAL/INJECTED mocked poison record source
> > - Added Jonathan Reviewed-by tag on Patch 3
> >
> > Link to v4:
> > https://lore.kernel.org/linux-cxl/cover.1671135967.git.alison.schofield@intel.com/
> >
> > Add support for retrieving device poison lists and store the returned
> > error records as kernel trace events.
> >
> > The handling of the poison list is guided by the CXL 3.0 Specification
> > Section 8.2.9.8.4.1. [1]
> >
> > Example, triggered by memdev:
> > $ echo 1 > /sys/bus/cxl/devices/mem3/trigger_poison_list
> > cxl_poison: memdev=mem3 pcidev=cxl_mem.3 region= region_uuid=00000000-0000-0000-0000-000000000000 dpa=0x0 length=0x40 source=Internal flags= overflow_time=0
>
> I think the pcidev= field wants to be called something like "host" or
> "parent", because there is no strict requirement that a 'struct
> cxl_memdev' is related to a 'struct pci_dev'. In fact in that example
> "cxl_mem.3" is a 'struct platform_device'. Now that I think about it, I
> think all CXL device events should be emitting the PCIe serial number
> for the memdev.
]
Will do, 'host' and add PCIe serial no.
>
> I will look in the implementation, but do region= and region_uuid= get
> populated when mem3 is a member of the region?
Not always.
In the case above, where the trigger was by memdev, no.
Region= and region_uuid= (and in the follow-on patch, hpa=) only get
populated if the poison was triggered by region, like the case below.
It could be looked up for the by memdev cases. Is that wanted?
Thanks for the reviews Dan!
>
> >
> > Example, triggered by region:
> > $ echo 1 > /sys/bus/cxl/devices/region5/trigger_poison_list
> > cxl_poison: memdev=mem0 pcidev=cxl_mem.0 region=region5 region_uuid=bfcb7a29-890e-4a41-8236-fe22221fc75c dpa=0x0 length=0x40 source=Internal flags= overflow_time=0
> > cxl_poison: memdev=mem1 pcidev=cxl_mem.1 region=region5 region_uuid=bfcb7a29-890e-4a41-8236-fe22221fc75c dpa=0x0 length=0x40 source=Internal flags= overflow_time=0
> >
> > [1]: https://www.computeexpresslink.org/download-the-specification
> >
> > Alison Schofield (5):
> > cxl/mbox: Add GET_POISON_LIST mailbox command
> > cxl/trace: Add TRACE support for CXL media-error records
> > cxl/memdev: Add trigger_poison_list sysfs attribute
> > cxl/region: Add trigger_poison_list sysfs attribute
> > tools/testing/cxl: Mock support for Get Poison List
> >
> > Documentation/ABI/testing/sysfs-bus-cxl | 28 +++++++++
> > drivers/cxl/core/mbox.c | 78 +++++++++++++++++++++++
> > drivers/cxl/core/memdev.c | 45 ++++++++++++++
> > drivers/cxl/core/region.c | 33 ++++++++++
> > drivers/cxl/core/trace.h | 83 +++++++++++++++++++++++++
> > drivers/cxl/cxlmem.h | 69 +++++++++++++++++++-
> > drivers/cxl/pci.c | 4 ++
> > tools/testing/cxl/test/mem.c | 42 +++++++++++++
> > 8 files changed, 381 insertions(+), 1 deletion(-)
> >
> >
> > base-commit: 589c3357370a596ef7c99c00baca8ac799fce531
> > --
> > 2.37.3
> >
>
>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re:
2023-01-27 16:10 ` Alison Schofield
@ 2023-01-27 19:16 ` Dan Williams
2023-01-27 21:36 ` Re: Alison Schofield
0 siblings, 1 reply; 16+ messages in thread
From: Dan Williams @ 2023-01-27 19:16 UTC (permalink / raw
To: Alison Schofield, Dan Williams
Cc: Ira Weiny, Vishal Verma, Dave Jiang, Ben Widawsky, Steven Rostedt,
linux-cxl, linux-kernel
Alison Schofield wrote:
> On Thu, Jan 26, 2023 at 05:59:03PM -0800, Dan Williams wrote:
> > alison.schofield@ wrote:
> > > From: Alison Schofield <alison.schofield@intel.com>
> > >
> > > Subject: [PATCH v5 0/5] CXL Poison List Retrieval & Tracing
> > >
> > > Changes in v5:
> > > - Rebase on cxl/next
> > > - Use struct_size() to calc mbox cmd payload .min_out
> > > - s/INTERNAL/INJECTED mocked poison record source
> > > - Added Jonathan Reviewed-by tag on Patch 3
> > >
> > > Link to v4:
> > > https://lore.kernel.org/linux-cxl/cover.1671135967.git.alison.schofield@intel.com/
> > >
> > > Add support for retrieving device poison lists and store the returned
> > > error records as kernel trace events.
> > >
> > > The handling of the poison list is guided by the CXL 3.0 Specification
> > > Section 8.2.9.8.4.1. [1]
> > >
> > > Example, triggered by memdev:
> > > $ echo 1 > /sys/bus/cxl/devices/mem3/trigger_poison_list
> > > cxl_poison: memdev=mem3 pcidev=cxl_mem.3 region= region_uuid=00000000-0000-0000-0000-000000000000 dpa=0x0 length=0x40 source=Internal flags= overflow_time=0
> >
> > I think the pcidev= field wants to be called something like "host" or
> > "parent", because there is no strict requirement that a 'struct
> > cxl_memdev' is related to a 'struct pci_dev'. In fact in that example
> > "cxl_mem.3" is a 'struct platform_device'. Now that I think about it, I
> > think all CXL device events should be emitting the PCIe serial number
> > for the memdev.
> ]
>
> Will do, 'host' and add PCIe serial no.
>
> >
> > I will look in the implementation, but do region= and region_uuid= get
> > populated when mem3 is a member of the region?
>
> Not always.
> In the case above, where the trigger was by memdev, no.
> Region= and region_uuid= (and in the follow-on patch, hpa=) only get
> populated if the poison was triggered by region, like the case below.
>
> It could be looked up for the by memdev cases. Is that wanted?
Just trying to understand the semantics. However, I do think it makes sense
for a memdev trigger to lookup information on all impacted regions
across all of the device's DPA and the region trigger makes sense to
lookup all memdevs, but bounded by the DPA that contributes to that
region. I just want to avoid someone having to trigger the region to get
extra information that was readily available from a memdev listing.
>
> Thanks for the reviews Dan!
> >
> > >
> > > Example, triggered by region:
> > > $ echo 1 > /sys/bus/cxl/devices/region5/trigger_poison_list
> > > cxl_poison: memdev=mem0 pcidev=cxl_mem.0 region=region5 region_uuid=bfcb7a29-890e-4a41-8236-fe22221fc75c dpa=0x0 length=0x40 source=Internal flags= overflow_time=0
> > > cxl_poison: memdev=mem1 pcidev=cxl_mem.1 region=region5 region_uuid=bfcb7a29-890e-4a41-8236-fe22221fc75c dpa=0x0 length=0x40 source=Internal flags= overflow_time=0
> > >
> > > [1]: https://www.computeexpresslink.org/download-the-specification
> > >
> > > Alison Schofield (5):
> > > cxl/mbox: Add GET_POISON_LIST mailbox command
> > > cxl/trace: Add TRACE support for CXL media-error records
> > > cxl/memdev: Add trigger_poison_list sysfs attribute
> > > cxl/region: Add trigger_poison_list sysfs attribute
> > > tools/testing/cxl: Mock support for Get Poison List
> > >
> > > Documentation/ABI/testing/sysfs-bus-cxl | 28 +++++++++
> > > drivers/cxl/core/mbox.c | 78 +++++++++++++++++++++++
> > > drivers/cxl/core/memdev.c | 45 ++++++++++++++
> > > drivers/cxl/core/region.c | 33 ++++++++++
> > > drivers/cxl/core/trace.h | 83 +++++++++++++++++++++++++
> > > drivers/cxl/cxlmem.h | 69 +++++++++++++++++++-
> > > drivers/cxl/pci.c | 4 ++
> > > tools/testing/cxl/test/mem.c | 42 +++++++++++++
> > > 8 files changed, 381 insertions(+), 1 deletion(-)
> > >
> > >
> > > base-commit: 589c3357370a596ef7c99c00baca8ac799fce531
> > > --
> > > 2.37.3
> > >
> >
> >
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re:
2023-01-27 19:16 ` Re: Dan Williams
@ 2023-01-27 21:36 ` Alison Schofield
2023-01-27 22:04 ` Re: Dan Williams
0 siblings, 1 reply; 16+ messages in thread
From: Alison Schofield @ 2023-01-27 21:36 UTC (permalink / raw
To: Dan Williams
Cc: Ira Weiny, Vishal Verma, Dave Jiang, Ben Widawsky, Steven Rostedt,
linux-cxl, linux-kernel
On Fri, Jan 27, 2023 at 11:16:49AM -0800, Dan Williams wrote:
> Alison Schofield wrote:
> > On Thu, Jan 26, 2023 at 05:59:03PM -0800, Dan Williams wrote:
> > > alison.schofield@ wrote:
> > > > From: Alison Schofield <alison.schofield@intel.com>
> > > >
> > > > Subject: [PATCH v5 0/5] CXL Poison List Retrieval & Tracing
> > > >
> > > > Changes in v5:
> > > > - Rebase on cxl/next
> > > > - Use struct_size() to calc mbox cmd payload .min_out
> > > > - s/INTERNAL/INJECTED mocked poison record source
> > > > - Added Jonathan Reviewed-by tag on Patch 3
> > > >
> > > > Link to v4:
> > > > https://lore.kernel.org/linux-cxl/cover.1671135967.git.alison.schofield@intel.com/
> > > >
> > > > Add support for retrieving device poison lists and store the returned
> > > > error records as kernel trace events.
> > > >
> > > > The handling of the poison list is guided by the CXL 3.0 Specification
> > > > Section 8.2.9.8.4.1. [1]
> > > >
> > > > Example, triggered by memdev:
> > > > $ echo 1 > /sys/bus/cxl/devices/mem3/trigger_poison_list
> > > > cxl_poison: memdev=mem3 pcidev=cxl_mem.3 region= region_uuid=00000000-0000-0000-0000-000000000000 dpa=0x0 length=0x40 source=Internal flags= overflow_time=0
> > >
> > > I think the pcidev= field wants to be called something like "host" or
> > > "parent", because there is no strict requirement that a 'struct
> > > cxl_memdev' is related to a 'struct pci_dev'. In fact in that example
> > > "cxl_mem.3" is a 'struct platform_device'. Now that I think about it, I
> > > think all CXL device events should be emitting the PCIe serial number
> > > for the memdev.
> > ]
> >
> > Will do, 'host' and add PCIe serial no.
> >
> > >
> > > I will look in the implementation, but do region= and region_uuid= get
> > > populated when mem3 is a member of the region?
> >
> > Not always.
> > In the case above, where the trigger was by memdev, no.
> > Region= and region_uuid= (and in the follow-on patch, hpa=) only get
> > populated if the poison was triggered by region, like the case below.
> >
> > It could be looked up for the by memdev cases. Is that wanted?
>
> Just trying to understand the semantics. However, I do think it makes sense
> for a memdev trigger to lookup information on all impacted regions
> across all of the device's DPA and the region trigger makes sense to
> lookup all memdevs, but bounded by the DPA that contributes to that
> region. I just want to avoid someone having to trigger the region to get
> extra information that was readily available from a memdev listing.
>
Dan -
Confirming my take-away from this email, and our chat:
Remove the by-region trigger_poison_list option entirely. User space
needs to trigger by-memdev the memdevs participating in the region and
filter those events by region.
Add the region info (region name, uuid) to the TRACE_EVENTs when the
poisoned DPA is part of any region.
Alison
> >
> > Thanks for the reviews Dan!
> > >
> > > >
> > > > Example, triggered by region:
> > > > $ echo 1 > /sys/bus/cxl/devices/region5/trigger_poison_list
> > > > cxl_poison: memdev=mem0 pcidev=cxl_mem.0 region=region5 region_uuid=bfcb7a29-890e-4a41-8236-fe22221fc75c dpa=0x0 length=0x40 source=Internal flags= overflow_time=0
> > > > cxl_poison: memdev=mem1 pcidev=cxl_mem.1 region=region5 region_uuid=bfcb7a29-890e-4a41-8236-fe22221fc75c dpa=0x0 length=0x40 source=Internal flags= overflow_time=0
> > > >
> > > > [1]: https://www.computeexpresslink.org/download-the-specification
> > > >
> > > > Alison Schofield (5):
> > > > cxl/mbox: Add GET_POISON_LIST mailbox command
> > > > cxl/trace: Add TRACE support for CXL media-error records
> > > > cxl/memdev: Add trigger_poison_list sysfs attribute
> > > > cxl/region: Add trigger_poison_list sysfs attribute
> > > > tools/testing/cxl: Mock support for Get Poison List
> > > >
> > > > Documentation/ABI/testing/sysfs-bus-cxl | 28 +++++++++
> > > > drivers/cxl/core/mbox.c | 78 +++++++++++++++++++++++
> > > > drivers/cxl/core/memdev.c | 45 ++++++++++++++
> > > > drivers/cxl/core/region.c | 33 ++++++++++
> > > > drivers/cxl/core/trace.h | 83 +++++++++++++++++++++++++
> > > > drivers/cxl/cxlmem.h | 69 +++++++++++++++++++-
> > > > drivers/cxl/pci.c | 4 ++
> > > > tools/testing/cxl/test/mem.c | 42 +++++++++++++
> > > > 8 files changed, 381 insertions(+), 1 deletion(-)
> > > >
> > > >
> > > > base-commit: 589c3357370a596ef7c99c00baca8ac799fce531
> > > > --
> > > > 2.37.3
> > > >
> > >
> > >
>
>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re:
2023-01-27 21:36 ` Re: Alison Schofield
@ 2023-01-27 22:04 ` Dan Williams
0 siblings, 0 replies; 16+ messages in thread
From: Dan Williams @ 2023-01-27 22:04 UTC (permalink / raw
To: Alison Schofield, Dan Williams
Cc: Ira Weiny, Vishal Verma, Dave Jiang, Ben Widawsky, Steven Rostedt,
linux-cxl, linux-kernel
Alison Schofield wrote:
> On Fri, Jan 27, 2023 at 11:16:49AM -0800, Dan Williams wrote:
> > Alison Schofield wrote:
> > > On Thu, Jan 26, 2023 at 05:59:03PM -0800, Dan Williams wrote:
> > > > alison.schofield@ wrote:
> > > > > From: Alison Schofield <alison.schofield@intel.com>
> > > > >
> > > > > Subject: [PATCH v5 0/5] CXL Poison List Retrieval & Tracing
> > > > >
> > > > > Changes in v5:
> > > > > - Rebase on cxl/next
> > > > > - Use struct_size() to calc mbox cmd payload .min_out
> > > > > - s/INTERNAL/INJECTED mocked poison record source
> > > > > - Added Jonathan Reviewed-by tag on Patch 3
> > > > >
> > > > > Link to v4:
> > > > > https://lore.kernel.org/linux-cxl/cover.1671135967.git.alison.schofield@intel.com/
> > > > >
> > > > > Add support for retrieving device poison lists and store the returned
> > > > > error records as kernel trace events.
> > > > >
> > > > > The handling of the poison list is guided by the CXL 3.0 Specification
> > > > > Section 8.2.9.8.4.1. [1]
> > > > >
> > > > > Example, triggered by memdev:
> > > > > $ echo 1 > /sys/bus/cxl/devices/mem3/trigger_poison_list
> > > > > cxl_poison: memdev=mem3 pcidev=cxl_mem.3 region= region_uuid=00000000-0000-0000-0000-000000000000 dpa=0x0 length=0x40 source=Internal flags= overflow_time=0
> > > >
> > > > I think the pcidev= field wants to be called something like "host" or
> > > > "parent", because there is no strict requirement that a 'struct
> > > > cxl_memdev' is related to a 'struct pci_dev'. In fact in that example
> > > > "cxl_mem.3" is a 'struct platform_device'. Now that I think about it, I
> > > > think all CXL device events should be emitting the PCIe serial number
> > > > for the memdev.
> > > ]
> > >
> > > Will do, 'host' and add PCIe serial no.
> > >
> > > >
> > > > I will look in the implementation, but do region= and region_uuid= get
> > > > populated when mem3 is a member of the region?
> > >
> > > Not always.
> > > In the case above, where the trigger was by memdev, no.
> > > Region= and region_uuid= (and in the follow-on patch, hpa=) only get
> > > populated if the poison was triggered by region, like the case below.
> > >
> > > It could be looked up for the by memdev cases. Is that wanted?
> >
> > Just trying to understand the semantics. However, I do think it makes sense
> > for a memdev trigger to lookup information on all impacted regions
> > across all of the device's DPA and the region trigger makes sense to
> > lookup all memdevs, but bounded by the DPA that contributes to that
> > region. I just want to avoid someone having to trigger the region to get
> > extra information that was readily available from a memdev listing.
> >
>
> Dan -
>
> Confirming my take-away from this email, and our chat:
>
> Remove the by-region trigger_poison_list option entirely. User space
> needs to trigger by-memdev the memdevs participating in the region and
> filter those events by region.
>
> Add the region info (region name, uuid) to the TRACE_EVENTs when the
> poisoned DPA is part of any region.
That's what I was thinking, yes. So the internals of
cxl_mem_get_poison() will take the cxl_region_rwsem for read and compare
the device's endpoint decoder settings against the media error records
to do the region (and later HPA) lookup.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [NDCTL PATCH v2 1/2] cxl: Save the number of decoders committed to a port
@ 2023-11-28 20:43 Dave Jiang
2023-11-28 20:43 ` [NDCTL PATCH v2 2/2] cxl: Add check for regions before disabling memdev Dave Jiang
0 siblings, 1 reply; 16+ messages in thread
From: Dave Jiang @ 2023-11-28 20:43 UTC (permalink / raw
To: linux-cxl, nvdimm; +Cc: vishal.l.verma, alison.schofield, caoqq
Save the number of decoders committed to a port exposed by the kernel to the
libcxl cxl_port context. The attribute is helpful for determing if a region is
active. Add libcxl API to retrieve the number of decoders committed.
Add the decoders_committed attribute to the port for cxl list command.
Link: https://lore.kernel.org/linux-cxl/169645700414.623072.3893376765415910289.stgit@djiang5-mobl3/T/#t
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
---
v2:
- Rebase against latest pending branch
---
Documentation/cxl/lib/libcxl.txt | 1 +
cxl/json.c | 4 ++++
cxl/lib/libcxl.c | 9 +++++++++
cxl/lib/libcxl.sym | 1 +
cxl/lib/private.h | 1 +
cxl/libcxl.h | 1 +
6 files changed, 17 insertions(+)
diff --git a/Documentation/cxl/lib/libcxl.txt b/Documentation/cxl/lib/libcxl.txt
index bcb89288afaf..93c32b54f19e 100644
--- a/Documentation/cxl/lib/libcxl.txt
+++ b/Documentation/cxl/lib/libcxl.txt
@@ -295,6 +295,7 @@ bool cxl_port_is_endpoint(struct cxl_port *port);
int cxl_port_get_depth(struct cxl_port *port);
bool cxl_port_hosts_memdev(struct cxl_port *port, struct cxl_memdev *memdev);
int cxl_port_get_nr_dports(struct cxl_port *port);
+struct cxl_port *cxl_port_decoders_committed(struct cxl_port *port);
----
The port type is communicated via cxl_port_is_<type>(). An 'enabled' port
is one that has succeeded in discovering the CXL component registers in
diff --git a/cxl/json.c b/cxl/json.c
index 6fb17582a1cb..477e35a5157a 100644
--- a/cxl/json.c
+++ b/cxl/json.c
@@ -1331,6 +1331,10 @@ static struct json_object *__util_cxl_port_to_json(struct cxl_port *port,
json_object_object_add(jport, "state", jobj);
}
+ jobj = json_object_new_int(cxl_port_decoders_committed(port));
+ if (jobj)
+ json_object_object_add(jport, "decoders_committed", jobj);
+
json_object_set_userdata(jport, port, NULL);
return jport;
}
diff --git a/cxl/lib/libcxl.c b/cxl/lib/libcxl.c
index bdec2959508b..c1a127f66a1d 100644
--- a/cxl/lib/libcxl.c
+++ b/cxl/lib/libcxl.c
@@ -1880,6 +1880,10 @@ static int cxl_port_init(struct cxl_port *port, struct cxl_port *parent_port,
if (sysfs_read_attr(ctx, path, buf) == 0)
port->module = util_modalias_to_module(ctx, buf);
+ sprintf(path, "%s/decoders_committed", cxlport_base);
+ if (sysfs_read_attr(ctx, path, buf) == 0)
+ port->decoders_committed = strtoul(buf, NULL, 0);
+
free(path);
return 0;
err:
@@ -3121,6 +3125,11 @@ cxl_port_get_dport_by_memdev(struct cxl_port *port, struct cxl_memdev *memdev)
return NULL;
}
+CXL_EXPORT int cxl_port_decoders_committed(struct cxl_port *port)
+{
+ return port->decoders_committed;
+}
+
static void *add_cxl_bus(void *parent, int id, const char *cxlbus_base)
{
const char *devname = devpath_to_devname(cxlbus_base);
diff --git a/cxl/lib/libcxl.sym b/cxl/lib/libcxl.sym
index 42f523fda16d..16eca09b3d8b 100644
--- a/cxl/lib/libcxl.sym
+++ b/cxl/lib/libcxl.sym
@@ -277,4 +277,5 @@ global:
cxl_cmd_new_set_alert_config;
cxl_memdev_trigger_poison_list;
cxl_region_trigger_poison_list;
+ cxl_port_decoders_committed;
} LIBCXL_6;
diff --git a/cxl/lib/private.h b/cxl/lib/private.h
index b26a8629e047..30c898940dec 100644
--- a/cxl/lib/private.h
+++ b/cxl/lib/private.h
@@ -87,6 +87,7 @@ struct cxl_port {
int dports_init;
int nr_dports;
int depth;
+ int decoders_committed;
struct cxl_ctx *ctx;
struct cxl_bus *bus;
enum cxl_port_type type;
diff --git a/cxl/libcxl.h b/cxl/libcxl.h
index 1154f4ce34d1..f7db400f574a 100644
--- a/cxl/libcxl.h
+++ b/cxl/libcxl.h
@@ -145,6 +145,7 @@ bool cxl_port_hosts_memdev(struct cxl_port *port, struct cxl_memdev *memdev);
int cxl_port_get_nr_dports(struct cxl_port *port);
int cxl_port_disable_invalidate(struct cxl_port *port);
int cxl_port_enable(struct cxl_port *port);
+int cxl_port_decoders_committed(struct cxl_port *port);
struct cxl_port *cxl_port_get_next_all(struct cxl_port *port,
const struct cxl_port *top);
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [NDCTL PATCH v2 2/2] cxl: Add check for regions before disabling memdev
2023-11-28 20:43 [NDCTL PATCH v2 1/2] cxl: Save the number of decoders committed to a port Dave Jiang
@ 2023-11-28 20:43 ` Dave Jiang
2023-11-30 1:41 ` Cao, Quanquan/曹 全全
2023-11-30 8:29 ` Cao, Quanquan/曹 全全
0 siblings, 2 replies; 16+ messages in thread
From: Dave Jiang @ 2023-11-28 20:43 UTC (permalink / raw
To: linux-cxl, nvdimm; +Cc: vishal.l.verma, alison.schofield, caoqq
Add a check for memdev disable to see if there are active regions present
before disabling the device. This is necessary now regions are present to
fulfill the TODO that was left there. The best way to determine if a
region is active is to see if there are decoders enabled for the mem
device. This is also best effort as the state is only a snapshot the
kernel provides and is not atomic WRT the memdev disable operation. The
expectation is the admin issuing the command has full control of the mem
device and there are no other agents also attempt to control the device.
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
---
v2:
- Warn if active region regardless of -f. (Alison)
- Expound on -f behavior in man page. (Vishal)
---
Documentation/cxl/cxl-disable-memdev.txt | 4 +++-
cxl/memdev.c | 17 ++++++++++++++---
2 files changed, 17 insertions(+), 4 deletions(-)
diff --git a/Documentation/cxl/cxl-disable-memdev.txt b/Documentation/cxl/cxl-disable-memdev.txt
index c4edb93ee94a..34b720288705 100644
--- a/Documentation/cxl/cxl-disable-memdev.txt
+++ b/Documentation/cxl/cxl-disable-memdev.txt
@@ -27,7 +27,9 @@ include::bus-option.txt[]
a device if the tool determines the memdev is in active usage. Recall
that CXL memory ranges might have been established by platform
firmware and disabling an active device is akin to force removing
- memory from a running system.
+ memory from a running system. Going down this path does not offline
+ active memory if they are currently online. User is recommended to
+ offline and disable the appropriate regions before disabling the memdevs.
-v::
Turn on verbose debug messages in the library (if libcxl was built with
diff --git a/cxl/memdev.c b/cxl/memdev.c
index 2dd2e7fcc4dd..1d3121915284 100644
--- a/cxl/memdev.c
+++ b/cxl/memdev.c
@@ -437,14 +437,25 @@ static int action_free_dpa(struct cxl_memdev *memdev,
static int action_disable(struct cxl_memdev *memdev, struct action_context *actx)
{
+ struct cxl_endpoint *ep;
+ struct cxl_port *port;
+
if (!cxl_memdev_is_enabled(memdev))
return 0;
- if (!param.force) {
- /* TODO: actually detect rather than assume active */
+ ep = cxl_memdev_get_endpoint(memdev);
+ if (!ep)
+ return -ENODEV;
+
+ port = cxl_endpoint_get_port(ep);
+ if (!port)
+ return -ENODEV;
+
+ if (cxl_port_decoders_committed(port)) {
log_err(&ml, "%s is part of an active region\n",
cxl_memdev_get_devname(memdev));
- return -EBUSY;
+ if (!param.force)
+ return -EBUSY;
}
return cxl_memdev_disable_invalidate(memdev);
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [NDCTL PATCH v2 2/2] cxl: Add check for regions before disabling memdev
2023-11-28 20:43 ` [NDCTL PATCH v2 2/2] cxl: Add check for regions before disabling memdev Dave Jiang
@ 2023-11-30 1:41 ` Cao, Quanquan/曹 全全
2023-11-30 8:29 ` Cao, Quanquan/曹 全全
1 sibling, 0 replies; 16+ messages in thread
From: Cao, Quanquan/曹 全全 @ 2023-11-30 1:41 UTC (permalink / raw
To: Dave Jiang, linux-cxl, nvdimm; +Cc: vishal.l.verma, alison.schofield
> Add a check for memdev disable to see if there are active regions present
> before disabling the device. This is necessary now regions are present to
> fulfill the TODO that was left there. The best way to determine if a
> region is active is to see if there are decoders enabled for the mem
> device. This is also best effort as the state is only a snapshot the
> kernel provides and is not atomic WRT the memdev disable operation. The
> expectation is the admin issuing the command has full control of the mem
> device and there are no other agents also attempt to control the device.
>
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> ---
> v2:
> - Warn if active region regardless of -f. (Alison)
> - Expound on -f behavior in man page. (Vishal)
> ---
> Documentation/cxl/cxl-disable-memdev.txt | 4 +++-
> cxl/memdev.c | 17 ++++++++++++++---
> 2 files changed, 17 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/cxl/cxl-disable-memdev.txt b/Documentation/cxl/cxl-disable-memdev.txt
> index c4edb93ee94a..34b720288705 100644
> --- a/Documentation/cxl/cxl-disable-memdev.txt
> +++ b/Documentation/cxl/cxl-disable-memdev.txt
> @@ -27,7 +27,9 @@ include::bus-option.txt[]
> a device if the tool determines the memdev is in active usage. Recall
> that CXL memory ranges might have been established by platform
> firmware and disabling an active device is akin to force removing
> - memory from a running system.
> + memory from a running system. Going down this path does not offline
> + active memory if they are currently online. User is recommended to
> + offline and disable the appropriate regions before disabling the memdevs.
>
> -v::
> Turn on verbose debug messages in the library (if libcxl was built with
> diff --git a/cxl/memdev.c b/cxl/memdev.c
> index 2dd2e7fcc4dd..1d3121915284 100644
> --- a/cxl/memdev.c
> +++ b/cxl/memdev.c
> @@ -437,14 +437,25 @@ static int action_free_dpa(struct cxl_memdev *memdev,
>
> static int action_disable(struct cxl_memdev *memdev, struct action_context *actx)
> {
> + struct cxl_endpoint *ep;
> + struct cxl_port *port;
> +
> if (!cxl_memdev_is_enabled(memdev))
> return 0;
>
> - if (!param.force) {
> - /* TODO: actually detect rather than assume active */
> + ep = cxl_memdev_get_endpoint(memdev);
> + if (!ep)
> + return -ENODEV;
> +
> + port = cxl_endpoint_get_port(ep);
> + if (!port)
> + return -ENODEV;
> +
> + if (cxl_port_decoders_committed(port)) {
> log_err(&ml, "%s is part of an active region\n",
> cxl_memdev_get_devname(memdev));
> - return -EBUSY;
> + if (!param.force)
> + return -EBUSY;
> }
>
> return cxl_memdev_disable_invalidate(memdev);
>
>
Reviewed-by: Quanquan Cao <caoqq@fujitsu.com>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [NDCTL PATCH v2 2/2] cxl: Add check for regions before disabling memdev
2023-11-28 20:43 ` [NDCTL PATCH v2 2/2] cxl: Add check for regions before disabling memdev Dave Jiang
2023-11-30 1:41 ` Cao, Quanquan/曹 全全
@ 2023-11-30 8:29 ` Cao, Quanquan/曹 全全
2023-11-30 16:07 ` Dave Jiang
2023-11-30 21:51 ` [NDCTL PATCH v3 " Dave Jiang
1 sibling, 2 replies; 16+ messages in thread
From: Cao, Quanquan/曹 全全 @ 2023-11-30 8:29 UTC (permalink / raw
To: Dave Jiang, linux-cxl, nvdimm; +Cc: vishal.l.verma, alison.schofield
> static int action_disable(struct cxl_memdev *memdev, struct action_context *actx)
> {
> + struct cxl_endpoint *ep;
> + struct cxl_port *port;
> +
> if (!cxl_memdev_is_enabled(memdev))
> return 0;
>
> - if (!param.force) {
> - /* TODO: actually detect rather than assume active */
> + ep = cxl_memdev_get_endpoint(memdev);
> + if (!ep)
> + return -ENODEV;
> +
> + port = cxl_endpoint_get_port(ep);
> + if (!port)
> + return -ENODEV;
> +
> + if (cxl_port_decoders_committed(port)) {
> log_err(&ml, "%s is part of an active region\n",
> cxl_memdev_get_devname(memdev));
> - return -EBUSY;
> + if (!param.force)
> + return -EBUSY;
> }
>
> return cxl_memdev_disable_invalidate(memdev);
>
>
Hi Dave,
Do you think adding one more prompt message would be more user-friendly?
code:
if (cxl_port_decoders_committed(port)) {
log_err(&ml, "%s is part of an active region\n",
cxl_memdev_get_devname(memdev));
if (!param.force)
return -EBUSY;
else
log_err(&ml,"Forcing memdev disable with an
active region\n");
}
output:
[root@fedora-37-client ndctl]# cxl disable-memdev mem0 -f
cxl memdev: action_disable: mem0 is part of an active region
cxl memdev: action_disable: Forcing memdev disable with an active region
cxl memdev: cmd_disable_memdev: disabled 1 mem
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [NDCTL PATCH v2 2/2] cxl: Add check for regions before disabling memdev
2023-11-30 8:29 ` Cao, Quanquan/曹 全全
@ 2023-11-30 16:07 ` Dave Jiang
2023-11-30 21:51 ` [NDCTL PATCH v3 " Dave Jiang
1 sibling, 0 replies; 16+ messages in thread
From: Dave Jiang @ 2023-11-30 16:07 UTC (permalink / raw
To: Cao, Quanquan/曹 全全, linux-cxl, nvdimm
Cc: vishal.l.verma, alison.schofield
On 11/30/23 01:29, Cao, Quanquan/曹 全全 wrote:
>
>> static int action_disable(struct cxl_memdev *memdev, struct action_context *actx)
>> {
>> + struct cxl_endpoint *ep;
>> + struct cxl_port *port;
>> +
>> if (!cxl_memdev_is_enabled(memdev))
>> return 0;
>> - if (!param.force) {
>> - /* TODO: actually detect rather than assume active */
>> + ep = cxl_memdev_get_endpoint(memdev);
>> + if (!ep)
>> + return -ENODEV;
>> +
>> + port = cxl_endpoint_get_port(ep);
>> + if (!port)
>> + return -ENODEV;
>> +
>> + if (cxl_port_decoders_committed(port)) {
>> log_err(&ml, "%s is part of an active region\n",
>> cxl_memdev_get_devname(memdev));
>> - return -EBUSY;
>> + if (!param.force)
>> + return -EBUSY;
>> }
>> return cxl_memdev_disable_invalidate(memdev);
>>
>>
> Hi Dave,
> Do you think adding one more prompt message would be more user-friendly?
Yes good idea. I'll add.
>
> code:
> if (cxl_port_decoders_committed(port)) {
> log_err(&ml, "%s is part of an active region\n",
> cxl_memdev_get_devname(memdev));
> if (!param.force)
> return -EBUSY;
> else
> log_err(&ml,"Forcing memdev disable with an active region\n");
> }
>
> output:
> [root@fedora-37-client ndctl]# cxl disable-memdev mem0 -f
> cxl memdev: action_disable: mem0 is part of an active region
> cxl memdev: action_disable: Forcing memdev disable with an active region
> cxl memdev: cmd_disable_memdev: disabled 1 mem
>
^ permalink raw reply [flat|nested] 16+ messages in thread
* [NDCTL PATCH v3 2/2] cxl: Add check for regions before disabling memdev
2023-11-30 8:29 ` Cao, Quanquan/曹 全全
2023-11-30 16:07 ` Dave Jiang
@ 2023-11-30 21:51 ` Dave Jiang
2024-04-17 6:46 ` Yao Xingtao
1 sibling, 1 reply; 16+ messages in thread
From: Dave Jiang @ 2023-11-30 21:51 UTC (permalink / raw
To: linux-cxl, nvdimm; +Cc: vishal.l.verma, caoqq
Add a check for memdev disable to see if there are active regions present
before disabling the device. This is necessary now regions are present to
fulfill the TODO that was left there. The best way to determine if a
region is active is to see if there are decoders enabled for the mem
device. This is also best effort as the state is only a snapshot the
kernel provides and is not atomic WRT the memdev disable operation. The
expectation is the admin issuing the command has full control of the mem
device and there are no other agents also attempt to control the device.
Reviewed-by: Quanquan Cao <caoqq@fujitsu.com>
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
---
v3:
- Add emission of warning for forcing operation. (Quanquan)
v2:
- Warn if active region regardless of -f. (Alison)
- Expound on -f behavior in man page. (Vishal)
---
Documentation/cxl/cxl-disable-memdev.txt | 4 +++-
cxl/memdev.c | 20 +++++++++++++++++---
2 files changed, 20 insertions(+), 4 deletions(-)
diff --git a/Documentation/cxl/cxl-disable-memdev.txt b/Documentation/cxl/cxl-disable-memdev.txt
index c4edb93ee94a..34b720288705 100644
--- a/Documentation/cxl/cxl-disable-memdev.txt
+++ b/Documentation/cxl/cxl-disable-memdev.txt
@@ -27,7 +27,9 @@ include::bus-option.txt[]
a device if the tool determines the memdev is in active usage. Recall
that CXL memory ranges might have been established by platform
firmware and disabling an active device is akin to force removing
- memory from a running system.
+ memory from a running system. Going down this path does not offline
+ active memory if they are currently online. User is recommended to
+ offline and disable the appropriate regions before disabling the memdevs.
-v::
Turn on verbose debug messages in the library (if libcxl was built with
diff --git a/cxl/memdev.c b/cxl/memdev.c
index 2dd2e7fcc4dd..ed962d478048 100644
--- a/cxl/memdev.c
+++ b/cxl/memdev.c
@@ -437,14 +437,28 @@ static int action_free_dpa(struct cxl_memdev *memdev,
static int action_disable(struct cxl_memdev *memdev, struct action_context *actx)
{
+ struct cxl_endpoint *ep;
+ struct cxl_port *port;
+
if (!cxl_memdev_is_enabled(memdev))
return 0;
- if (!param.force) {
- /* TODO: actually detect rather than assume active */
+ ep = cxl_memdev_get_endpoint(memdev);
+ if (!ep)
+ return -ENODEV;
+
+ port = cxl_endpoint_get_port(ep);
+ if (!port)
+ return -ENODEV;
+
+ if (cxl_port_decoders_committed(port)) {
log_err(&ml, "%s is part of an active region\n",
cxl_memdev_get_devname(memdev));
- return -EBUSY;
+ if (!param.force)
+ return -EBUSY;
+
+ log_err(&ml, "Forcing %s disable with an active region!\n",
+ cxl_memdev_get_devname(memdev));
}
return cxl_memdev_disable_invalidate(memdev);
^ permalink raw reply related [flat|nested] 16+ messages in thread
* (no subject)
2023-11-30 21:51 ` [NDCTL PATCH v3 " Dave Jiang
@ 2024-04-17 6:46 ` Yao Xingtao
2024-04-17 18:14 ` Verma, Vishal L
0 siblings, 1 reply; 16+ messages in thread
From: Yao Xingtao @ 2024-04-17 6:46 UTC (permalink / raw
To: dave.jiang; +Cc: caoqq, linux-cxl, nvdimm, vishal.l.verma
Hi Dave,
I have applied this patch in my env, and done a lot of testing, this
feature is currently working fine.
But it is not merged into master branch yet, are there any updates
on this feature?
Associated patches:
https://lore.kernel.org/linux-cxl/170112921107.2687457.2741231995154639197.stgit@djiang5-mobl3/
https://lore.kernel.org/linux-cxl/170120423159.2725915.14670830315829916850.stgit@djiang5-mobl3/
Thanks
Xingtao
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re:
2024-04-17 6:46 ` Yao Xingtao
@ 2024-04-17 18:14 ` Verma, Vishal L
2024-04-22 7:26 ` Re: Xingtao Yao (Fujitsu)
2024-04-25 5:30 ` [NDCTL PATCH v3 2/2] cxl: Add check for regions before disabling memdev Zhijian Li (Fujitsu)
0 siblings, 2 replies; 16+ messages in thread
From: Verma, Vishal L @ 2024-04-17 18:14 UTC (permalink / raw
To: Jiang, Dave, yaoxt.fnst@fujitsu.com
Cc: caoqq@fujitsu.com, linux-cxl@vger.kernel.org,
nvdimm@lists.linux.dev
On Wed, 2024-04-17 at 02:46 -0400, Yao Xingtao wrote:
>
> Hi Dave,
> I have applied this patch in my env, and done a lot of testing,
> this
> feature is currently working fine.
> But it is not merged into master branch yet, are there any updates
> on this feature?
Hi Xingtao,
Turns out that I had applied this to a branch but forgot to merge and
push it. Thanks for the ping - done now, and pushed to pending.
>
> Associated patches:
> https://lore.kernel.org/linux-cxl/170112921107.2687457.2741231995154639197.stgit@djiang5-mobl3/
> https://lore.kernel.org/linux-cxl/170120423159.2725915.14670830315829916850.stgit@djiang5-mobl3/
>
> Thanks
> Xingtao
^ permalink raw reply [flat|nested] 16+ messages in thread
* RE: Re:
2024-04-17 18:14 ` Verma, Vishal L
@ 2024-04-22 7:26 ` Xingtao Yao (Fujitsu)
2024-04-25 5:30 ` [NDCTL PATCH v3 2/2] cxl: Add check for regions before disabling memdev Zhijian Li (Fujitsu)
1 sibling, 0 replies; 16+ messages in thread
From: Xingtao Yao (Fujitsu) @ 2024-04-22 7:26 UTC (permalink / raw
To: Verma, Vishal L, Jiang, Dave
Cc: Quanquan Cao (Fujitsu), linux-cxl@vger.kernel.org,
nvdimm@lists.linux.dev
> -----Original Message-----
> From: Verma, Vishal L <vishal.l.verma@intel.com>
> Sent: Thursday, April 18, 2024 2:14 AM
> To: Jiang, Dave <dave.jiang@intel.com>; Yao, Xingtao/姚 幸涛
> <yaoxt.fnst@fujitsu.com>
> Cc: Cao, Quanquan/曹 全全 <caoqq@fujitsu.com>; linux-cxl@vger.kernel.org;
> nvdimm@lists.linux.dev
> Subject: Re:
>
> On Wed, 2024-04-17 at 02:46 -0400, Yao Xingtao wrote:
> >
> > Hi Dave,
> > I have applied this patch in my env, and done a lot of testing,
> > this
> > feature is currently working fine.
> > But it is not merged into master branch yet, are there any updates
> > on this feature?
>
> Hi Xingtao,
>
> Turns out that I had applied this to a branch but forgot to merge and
> push it. Thanks for the ping - done now, and pushed to pending.
Awesome, many thanks!!!
>
> >
> > Associated patches:
> >
> https://lore.kernel.org/linux-cxl/170112921107.2687457.2741231995154639197.st
> git@djiang5-mobl3/
> >
> https://lore.kernel.org/linux-cxl/170120423159.2725915.14670830315829916850.s
> tgit@djiang5-mobl3/
> >
> > Thanks
> > Xingtao
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [NDCTL PATCH v3 2/2] cxl: Add check for regions before disabling memdev
2024-04-17 18:14 ` Verma, Vishal L
2024-04-22 7:26 ` Re: Xingtao Yao (Fujitsu)
@ 2024-04-25 5:30 ` Zhijian Li (Fujitsu)
2024-04-25 16:52 ` Alison Schofield
1 sibling, 1 reply; 16+ messages in thread
From: Zhijian Li (Fujitsu) @ 2024-04-25 5:30 UTC (permalink / raw
To: Verma, Vishal L, Jiang, Dave, Xingtao Yao (Fujitsu)
Cc: Quanquan Cao (Fujitsu), linux-cxl@vger.kernel.org,
nvdimm@lists.linux.dev
Hi Verma,
On 18/04/2024 02:14, Verma, Vishal L wrote:
> On Wed, 2024-04-17 at 02:46 -0400, Yao Xingtao wrote:
>>
>> Hi Dave,
>> I have applied this patch in my env, and done a lot of testing,
>> this
>> feature is currently working fine.
>> But it is not merged into master branch yet, are there any updates
>> on this feature?
>
> Hi Xingtao,
>
> Turns out that I had applied this to a branch but forgot to merge and
> push it. Thanks for the ping - done now, and pushed to pending.
May I know when the next version of NDCTL will be released. It seems like
it's been a very long time since the last release.
Thanks
Zhijian
>
>>
>> Associated patches:
>> https://lore.kernel.org/linux-cxl/170112921107.2687457.2741231995154639197.stgit@djiang5-mobl3/
>> https://lore.kernel.org/linux-cxl/170120423159.2725915.14670830315829916850.stgit@djiang5-mobl3/
>>
>> Thanks
>> Xingtao
>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [NDCTL PATCH v3 2/2] cxl: Add check for regions before disabling memdev
2024-04-25 5:30 ` [NDCTL PATCH v3 2/2] cxl: Add check for regions before disabling memdev Zhijian Li (Fujitsu)
@ 2024-04-25 16:52 ` Alison Schofield
2024-04-26 1:57 ` Zhijian Li (Fujitsu)
0 siblings, 1 reply; 16+ messages in thread
From: Alison Schofield @ 2024-04-25 16:52 UTC (permalink / raw
To: Zhijian Li (Fujitsu)
Cc: Verma, Vishal L, Jiang, Dave, Xingtao Yao (Fujitsu),
Quanquan Cao (Fujitsu), linux-cxl@vger.kernel.org,
nvdimm@lists.linux.dev
On Thu, Apr 25, 2024 at 05:30:40AM +0000, Zhijian Li (Fujitsu) wrote:
> Hi Verma,
>
>
> On 18/04/2024 02:14, Verma, Vishal L wrote:
> > On Wed, 2024-04-17 at 02:46 -0400, Yao Xingtao wrote:
> >>
> >> Hi Dave,
> >> I have applied this patch in my env, and done a lot of testing,
> >> this
> >> feature is currently working fine.
> >> But it is not merged into master branch yet, are there any updates
> >> on this feature?
> >
> > Hi Xingtao,
> >
> > Turns out that I had applied this to a branch but forgot to merge and
> > push it. Thanks for the ping - done now, and pushed to pending.
>
>
> May I know when the next version of NDCTL will be released. It seems like
> it's been a very long time since the last release.
Hi Zhijian,
We appreciate you working with the pending branch while waiting
for the next release. We are aiming to get the poison list feature
merged in the next release, and are getting closer. That's all I
can offer, no date prediction.
-- Alison
>
>
> Thanks
> Zhijian
>
>
>
>
> >
> >>
> >> Associated patches:
> >> https://lore.kernel.org/linux-cxl/170112921107.2687457.2741231995154639197.stgit@djiang5-mobl3/
> >> https://lore.kernel.org/linux-cxl/170120423159.2725915.14670830315829916850.stgit@djiang5-mobl3/
> >>
> >> Thanks
> >> Xingtao
> >
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [NDCTL PATCH v3 2/2] cxl: Add check for regions before disabling memdev
2024-04-25 16:52 ` Alison Schofield
@ 2024-04-26 1:57 ` Zhijian Li (Fujitsu)
0 siblings, 0 replies; 16+ messages in thread
From: Zhijian Li (Fujitsu) @ 2024-04-26 1:57 UTC (permalink / raw
To: Alison Schofield
Cc: Verma, Vishal L, Jiang, Dave, Xingtao Yao (Fujitsu),
Quanquan Cao (Fujitsu), linux-cxl@vger.kernel.org,
nvdimm@lists.linux.dev
On 26/04/2024 00:52, Alison Schofield wrote:
> On Thu, Apr 25, 2024 at 05:30:40AM +0000, Zhijian Li (Fujitsu) wrote:
>> Hi Verma,
>>
>>
>> On 18/04/2024 02:14, Verma, Vishal L wrote:
>>> On Wed, 2024-04-17 at 02:46 -0400, Yao Xingtao wrote:
>>>>
>>>> Hi Dave,
>>>> I have applied this patch in my env, and done a lot of testing,
>>>> this
>>>> feature is currently working fine.
>>>> But it is not merged into master branch yet, are there any updates
>>>> on this feature?
>>>
>>> Hi Xingtao,
>>>
>>> Turns out that I had applied this to a branch but forgot to merge and
>>> push it. Thanks for the ping - done now, and pushed to pending.
>>
>>
>> May I know when the next version of NDCTL will be released. It seems like
>> it's been a very long time since the last release.
>
> Hi Zhijian,
>
> We appreciate you working with the pending branch while waiting
> for the next release. We are aiming to get the poison list feature
> merged in the next release, and are getting closer. That's all I
> can offer, no date prediction.
Understood, thanks for your information.
Thanks
Zhijian
>
> -- Alison
>
>>
>>
>> Thanks
>> Zhijian
>>
>>
>>
>>
>>>
>>>>
>>>> Associated patches:
>>>> https://lore.kernel.org/linux-cxl/170112921107.2687457.2741231995154639197.stgit@djiang5-mobl3/
>>>> https://lore.kernel.org/linux-cxl/170120423159.2725915.14670830315829916850.stgit@djiang5-mobl3/
>>>>
>>>> Thanks
>>>> Xingtao
>>>
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2024-04-26 1:58 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-28 20:43 [NDCTL PATCH v2 1/2] cxl: Save the number of decoders committed to a port Dave Jiang
2023-11-28 20:43 ` [NDCTL PATCH v2 2/2] cxl: Add check for regions before disabling memdev Dave Jiang
2023-11-30 1:41 ` Cao, Quanquan/曹 全全
2023-11-30 8:29 ` Cao, Quanquan/曹 全全
2023-11-30 16:07 ` Dave Jiang
2023-11-30 21:51 ` [NDCTL PATCH v3 " Dave Jiang
2024-04-17 6:46 ` Yao Xingtao
2024-04-17 18:14 ` Verma, Vishal L
2024-04-22 7:26 ` Re: Xingtao Yao (Fujitsu)
2024-04-25 5:30 ` [NDCTL PATCH v3 2/2] cxl: Add check for regions before disabling memdev Zhijian Li (Fujitsu)
2024-04-25 16:52 ` Alison Schofield
2024-04-26 1:57 ` Zhijian Li (Fujitsu)
-- strict thread matches above, loose matches on Subject: below --
2023-01-18 20:59 [PATCH v5 0/5] CXL Poison List Retrieval & Tracing alison.schofield
2023-01-27 1:59 ` Dan Williams
2023-01-27 16:10 ` Alison Schofield
2023-01-27 19:16 ` Re: Dan Williams
2023-01-27 21:36 ` Re: Alison Schofield
2023-01-27 22:04 ` Re: Dan Williams
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).