* [PATCH] MAINTAINERS: repair file entry in COMPUTE EXPRESS LINK
@ 2024-04-11 6:24 Lukas Bulwahn
2024-04-11 16:27 ` Alison Schofield
0 siblings, 1 reply; 3+ messages in thread
From: Lukas Bulwahn @ 2024-04-11 6:24 UTC (permalink / raw
To: Ben Cheatham, Dan Williams, linux-cxl, linux-acpi
Cc: kernel-janitors, linux-kernel, Lukas Bulwahn
Commit 12fb28ea6b1c ("EINJ: Add CXL error type support") adds the header
file include/linux/einj-cxl.h, but then adds a file entry with cxl-einj.h
(note the swapping of words) to the COMPUTE EXPRESS LINK (CXL) section.
Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about a
broken reference.
Repair the file entry in COMPUTE EXPRESS LINK (CXL).
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@redhat.com>
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index edf6176a5530..03204db05027 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5415,7 +5415,7 @@ M: Dan Williams <dan.j.williams@intel.com>
L: linux-cxl@vger.kernel.org
S: Maintained
F: drivers/cxl/
-F: include/linux/cxl-einj.h
+F: include/linux/einj-cxl.h
F: include/linux/cxl-event.h
F: include/uapi/linux/cxl_mem.h
F: tools/testing/cxl/
--
2.44.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] MAINTAINERS: repair file entry in COMPUTE EXPRESS LINK
2024-04-11 6:24 [PATCH] MAINTAINERS: repair file entry in COMPUTE EXPRESS LINK Lukas Bulwahn
@ 2024-04-11 16:27 ` Alison Schofield
2024-04-30 19:00 ` Alison Schofield
0 siblings, 1 reply; 3+ messages in thread
From: Alison Schofield @ 2024-04-11 16:27 UTC (permalink / raw
To: Lukas Bulwahn
Cc: Ben Cheatham, Dan Williams, linux-cxl, linux-acpi,
kernel-janitors, linux-kernel, Lukas Bulwahn
On Thu, Apr 11, 2024 at 08:24:43AM +0200, Lukas Bulwahn wrote:
> Commit 12fb28ea6b1c ("EINJ: Add CXL error type support") adds the header
> file include/linux/einj-cxl.h, but then adds a file entry with cxl-einj.h
> (note the swapping of words) to the COMPUTE EXPRESS LINK (CXL) section.
>
> Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about a
> broken reference.
>
> Repair the file entry in COMPUTE EXPRESS LINK (CXL).
How about stating the impact, something like:
get_maintainer.pl can only return commit_signer history for file
include/linux/einj-cxl.h because the entry in MAINTAINERS is wrong.
Correct the entry so that the full MAINTAINER list is returned.
It is interesting how you found it and I'm not suggesting deleting
that.
Thanks,
Alison
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@redhat.com>
> ---
> MAINTAINERS | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index edf6176a5530..03204db05027 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -5415,7 +5415,7 @@ M: Dan Williams <dan.j.williams@intel.com>
> L: linux-cxl@vger.kernel.org
> S: Maintained
> F: drivers/cxl/
> -F: include/linux/cxl-einj.h
> +F: include/linux/einj-cxl.h
> F: include/linux/cxl-event.h
> F: include/uapi/linux/cxl_mem.h
> F: tools/testing/cxl/
> --
> 2.44.0
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] MAINTAINERS: repair file entry in COMPUTE EXPRESS LINK
2024-04-11 16:27 ` Alison Schofield
@ 2024-04-30 19:00 ` Alison Schofield
0 siblings, 0 replies; 3+ messages in thread
From: Alison Schofield @ 2024-04-30 19:00 UTC (permalink / raw
To: Dave Jiang
Cc: Ben Cheatham, Dan Williams, linux-cxl, linux-acpi,
kernel-janitors, linux-kernel, Lukas Bulwahn
On Thu, Apr 11, 2024 at 09:27:39AM -0700, Alison Schofield wrote:
> On Thu, Apr 11, 2024 at 08:24:43AM +0200, Lukas Bulwahn wrote:
> > Commit 12fb28ea6b1c ("EINJ: Add CXL error type support") adds the header
> > file include/linux/einj-cxl.h, but then adds a file entry with cxl-einj.h
> > (note the swapping of words) to the COMPUTE EXPRESS LINK (CXL) section.
> >
> > Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about a
> > broken reference.
> >
> > Repair the file entry in COMPUTE EXPRESS LINK (CXL).
>
> How about stating the impact, something like:
>
> get_maintainer.pl can only return commit_signer history for file
> include/linux/einj-cxl.h because the entry in MAINTAINERS is wrong.
> Correct the entry so that the full MAINTAINER list is returned.
Hi Dave,
Perhaps you can amend the commit log with this suggestion upon applying.
With that done, you can add:
Reviewed-by: Alison Schofield <alison.schofield@intel.com>
>
> It is interesting how you found it and I'm not suggesting deleting
> that.
>
> Thanks,
> Alison
>
>
> >
> > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@redhat.com>
> > ---
> > MAINTAINERS | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index edf6176a5530..03204db05027 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -5415,7 +5415,7 @@ M: Dan Williams <dan.j.williams@intel.com>
> > L: linux-cxl@vger.kernel.org
> > S: Maintained
> > F: drivers/cxl/
> > -F: include/linux/cxl-einj.h
> > +F: include/linux/einj-cxl.h
> > F: include/linux/cxl-event.h
> > F: include/uapi/linux/cxl_mem.h
> > F: tools/testing/cxl/
> > --
> > 2.44.0
> >
> >
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-30 19:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-11 6:24 [PATCH] MAINTAINERS: repair file entry in COMPUTE EXPRESS LINK Lukas Bulwahn
2024-04-11 16:27 ` Alison Schofield
2024-04-30 19:00 ` Alison Schofield
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).