From: Dave Jiang <dave.jiang@intel.com>
To: Dan Williams <dan.j.williams@intel.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Yuquan Wang <wangyuquan1236@phytium.com.cn>
Cc: ira.weiny@intel.com, linux-cxl@vger.kernel.org,
linux-kernel@vger.kernel.org, qemu-devel@nongnu.org,
chenbaozi@phytium.com.cn
Subject: Re: [PATCH v2 1/1] cxl/mem: Fix for the index of Clear Event Record Handle
Date: Tue, 19 Mar 2024 11:31:38 -0700 [thread overview]
Message-ID: <e589e7d5-c83a-4b33-8504-e3174cc4e534@intel.com> (raw)
In-Reply-To: <65f8de878e8e1_7702a294f4@dwillia2-xfh.jf.intel.com.notmuch>
On 3/18/24 5:38 PM, Dan Williams wrote:
> Jonathan Cameron wrote:
>> On Mon, 18 Mar 2024 10:29:28 +0800
>> Yuquan Wang <wangyuquan1236@phytium.com.cn> wrote:
>>
>>> The dev_dbg info for Clear Event Records mailbox command would report
>>> the handle of the next record to clear not the current one.
>>>
>>> This was because the index 'i' had incremented before printing the
>>> current handle value.
>>>
>>> Signed-off-by: Yuquan Wang <wangyuquan1236@phytium.com.cn>
>>> ---
>>> drivers/cxl/core/mbox.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c
>>> index 9adda4795eb7..b810a6aa3010 100644
>>> --- a/drivers/cxl/core/mbox.c
>>> +++ b/drivers/cxl/core/mbox.c
>>> @@ -915,7 +915,7 @@ static int cxl_clear_event_record(struct cxl_memdev_state *mds,
>>>
>>> payload->handles[i++] = gen->hdr.handle;
>>> dev_dbg(mds->cxlds.dev, "Event log '%d': Clearing %u\n", log,
>>> - le16_to_cpu(payload->handles[i]));
>>> + le16_to_cpu(payload->handles[i-1]));
>> Trivial but needs spaces around the -. e.g. [i - 1]
>>
>> Maybe Dan can fix up whilst applying.
>>
>> Otherwise
>>
>> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> I have enlisted Dave to start wrangling CXL kernel patches upstream, and
> I will fall back to just reviewing.
>
> Dave, you can add my:
>
> Reviewed-by: Dan Williams <dan.j.williams@intel.com>
>
> ...with the same caveat as above.
Applied, updated, and added
Fixes: 6ebe28f9ec72 ("cxl/mem: Read, trace, and clear events on driver load")
>
next prev parent reply other threads:[~2024-03-19 18:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-18 2:29 [PATCH v2 0/1] cxl/mem: Fix for the index of Clear Event Record Handle Yuquan Wang
2024-03-18 2:29 ` [PATCH v2 1/1] " Yuquan Wang
2024-03-18 10:57 ` Jonathan Cameron
2024-03-19 0:38 ` Dan Williams
2024-03-19 18:31 ` Dave Jiang [this message]
2024-03-18 16:51 ` fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e589e7d5-c83a-4b33-8504-e3174cc4e534@intel.com \
--to=dave.jiang@intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=chenbaozi@phytium.com.cn \
--cc=dan.j.williams@intel.com \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=wangyuquan1236@phytium.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).