* [PATCH v2] ASoC: dt-bindings: nvidia,tegra210-ahub: Add missing child nodes
@ 2021-03-26 19:50 Rob Herring
2021-03-29 6:49 ` Thierry Reding
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Rob Herring @ 2021-03-26 19:50 UTC (permalink / raw
To: Mark Brown
Cc: devicetree, linux-kernel, Liam Girdwood, Thierry Reding,
Jonathan Hunter, Sameer Pujar, alsa-devel, linux-tegra
The nvidia,tegra210-ahub binding is missing schema for child nodes. This
results in warnings if 'additionalProperties: false' is set (or when the
tools implement 'unevaluatedProperties' support). Add the child nodes
and reference their schema if one exists.
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: Sameer Pujar <spujar@nvidia.com>
Cc: alsa-devel@alsa-project.org
Cc: linux-tegra@vger.kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
v2:
- Also add 'dspk' child node
This patch ideally should be applied before this series[1].
[1] https://lore.kernel.org/r/20210323163634.877511-1-robh@kernel.org/
---
.../bindings/sound/nvidia,tegra210-ahub.yaml | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml
index e568d6c7dddd..1118a9488345 100644
--- a/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml
+++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml
@@ -69,6 +69,22 @@ properties:
$ref: audio-graph-port.yaml#
unevaluatedProperties: false
+patternProperties:
+ '^i2s@[0-9a-f]+$':
+ type: object
+
+ '^dmic@[0-9a-f]+$':
+ type: object
+ $ref: nvidia,tegra210-dmic.yaml#
+
+ '^admaif@[0-9a-f]+$':
+ type: object
+ $ref: nvidia,tegra210-admaif.yaml#
+
+ '^dspk@[0-9a-f]+$':
+ type: object
+ $ref: nvidia,tegra186-dspk.yaml#
+
required:
- compatible
- reg
--
2.27.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] ASoC: dt-bindings: nvidia,tegra210-ahub: Add missing child nodes
2021-03-26 19:50 [PATCH v2] ASoC: dt-bindings: nvidia,tegra210-ahub: Add missing child nodes Rob Herring
@ 2021-03-29 6:49 ` Thierry Reding
2021-03-29 6:53 ` Sameer Pujar
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Thierry Reding @ 2021-03-29 6:49 UTC (permalink / raw
To: Rob Herring
Cc: Mark Brown, devicetree, linux-kernel, Liam Girdwood,
Jonathan Hunter, Sameer Pujar, alsa-devel, linux-tegra
[-- Attachment #1: Type: text/plain, Size: 1031 bytes --]
On Fri, Mar 26, 2021 at 01:50:03PM -0600, Rob Herring wrote:
> The nvidia,tegra210-ahub binding is missing schema for child nodes. This
> results in warnings if 'additionalProperties: false' is set (or when the
> tools implement 'unevaluatedProperties' support). Add the child nodes
> and reference their schema if one exists.
>
> Cc: Liam Girdwood <lgirdwood@gmail.com>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Jonathan Hunter <jonathanh@nvidia.com>
> Cc: Sameer Pujar <spujar@nvidia.com>
> Cc: alsa-devel@alsa-project.org
> Cc: linux-tegra@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> v2:
> - Also add 'dspk' child node
>
> This patch ideally should be applied before this series[1].
>
> [1] https://lore.kernel.org/r/20210323163634.877511-1-robh@kernel.org/
> ---
> .../bindings/sound/nvidia,tegra210-ahub.yaml | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] ASoC: dt-bindings: nvidia,tegra210-ahub: Add missing child nodes
2021-03-26 19:50 [PATCH v2] ASoC: dt-bindings: nvidia,tegra210-ahub: Add missing child nodes Rob Herring
2021-03-29 6:49 ` Thierry Reding
@ 2021-03-29 6:53 ` Sameer Pujar
2021-03-30 12:12 ` [PATCH v2] ASoC: dt-bindings: nvidia, tegra210-ahub: " Mark Brown
2021-03-30 16:05 ` Mark Brown
3 siblings, 0 replies; 5+ messages in thread
From: Sameer Pujar @ 2021-03-29 6:53 UTC (permalink / raw
To: Rob Herring, Mark Brown
Cc: devicetree, linux-kernel, Liam Girdwood, Thierry Reding,
Jonathan Hunter, alsa-devel, linux-tegra
On 3/27/2021 1:20 AM, Rob Herring wrote:
> The nvidia,tegra210-ahub binding is missing schema for child nodes. This
> results in warnings if 'additionalProperties: false' is set (or when the
> tools implement 'unevaluatedProperties' support). Add the child nodes
> and reference their schema if one exists.
>
> Cc: Liam Girdwood <lgirdwood@gmail.com>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Jonathan Hunter <jonathanh@nvidia.com>
> Cc: Sameer Pujar <spujar@nvidia.com>
> Cc: alsa-devel@alsa-project.org
> Cc: linux-tegra@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> v2:
> - Also add 'dspk' child node
>
> This patch ideally should be applied before this series[1].
>
> [1] https://lore.kernel.org/r/20210323163634.877511-1-robh@kernel.org/
> ---
> .../bindings/sound/nvidia,tegra210-ahub.yaml | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
Acked-by: Sameer Pujar <spujar@nvidia.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] ASoC: dt-bindings: nvidia, tegra210-ahub: Add missing child nodes
2021-03-26 19:50 [PATCH v2] ASoC: dt-bindings: nvidia,tegra210-ahub: Add missing child nodes Rob Herring
2021-03-29 6:49 ` Thierry Reding
2021-03-29 6:53 ` Sameer Pujar
@ 2021-03-30 12:12 ` Mark Brown
2021-03-30 16:05 ` Mark Brown
3 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2021-03-30 12:12 UTC (permalink / raw
To: Rob Herring
Cc: devicetree, alsa-devel, Liam Girdwood, Sameer Pujar, linux-kernel,
Jonathan Hunter, Thierry Reding, linux-tegra
[-- Attachment #1: Type: text/plain, Size: 710 bytes --]
On Fri, Mar 26, 2021 at 01:50:03PM -0600, Rob Herring wrote:
> The nvidia,tegra210-ahub binding is missing schema for child nodes. This
> results in warnings if 'additionalProperties: false' is set (or when the
> tools implement 'unevaluatedProperties' support). Add the child nodes
> and reference their schema if one exists.
This doesn't apply against current code, please check and resend:
Applying: ASoC: dt-bindings: nvidia, tegra210-ahub: Add missing child nodes
error: sha1 information is lacking or useless (Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml).
error: could not build fake ancestor
Patch failed at 0001 ASoC: dt-bindings: nvidia, tegra210-ahub: Add missing child nodes
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] ASoC: dt-bindings: nvidia, tegra210-ahub: Add missing child nodes
2021-03-26 19:50 [PATCH v2] ASoC: dt-bindings: nvidia,tegra210-ahub: Add missing child nodes Rob Herring
` (2 preceding siblings ...)
2021-03-30 12:12 ` [PATCH v2] ASoC: dt-bindings: nvidia, tegra210-ahub: " Mark Brown
@ 2021-03-30 16:05 ` Mark Brown
3 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2021-03-30 16:05 UTC (permalink / raw
To: Rob Herring
Cc: Mark Brown, Jonathan Hunter, linux-tegra, Liam Girdwood,
Sameer Pujar, Thierry Reding, linux-kernel, alsa-devel,
devicetree
On Fri, 26 Mar 2021 13:50:03 -0600, Rob Herring wrote:
> The nvidia,tegra210-ahub binding is missing schema for child nodes. This
> results in warnings if 'additionalProperties: false' is set (or when the
> tools implement 'unevaluatedProperties' support). Add the child nodes
> and reference their schema if one exists.
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: dt-bindings: nvidia, tegra210-ahub: Add missing child nodes
commit: 8b01a0d0b5c1327296b37a13c37ca7ab31841577
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-03-30 16:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-26 19:50 [PATCH v2] ASoC: dt-bindings: nvidia,tegra210-ahub: Add missing child nodes Rob Herring
2021-03-29 6:49 ` Thierry Reding
2021-03-29 6:53 ` Sameer Pujar
2021-03-30 12:12 ` [PATCH v2] ASoC: dt-bindings: nvidia, tegra210-ahub: " Mark Brown
2021-03-30 16:05 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).