* [PATCH 0/2] ARM: dts: rockchip: fix some interrupts on rk3288
@ 2016-02-23 13:40 John Keeping
2016-02-23 13:40 ` [PATCH 1/2] ARM: dts: rockchip: fix MIPI interrupt " John Keeping
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: John Keeping @ 2016-02-23 13:40 UTC (permalink / raw
To: Heiko Stuebner
Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Russell King, linux-arm-kernel, linux-rockchip, devicetree,
linux-kernel, John Keeping
None of these are used by drivers so these don't fix any bugs but maybe
they'll save someone debugging time in the future.
John Keeping (2):
ARM: dts: rockchip: fix MIPI interrupt on rk3288
ARM: dts: rockchip: fix audio interrupts on rk3288
arch/arm/boot/dts/rk3288.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--
2.7.0.226.gfe986fe
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] ARM: dts: rockchip: fix MIPI interrupt on rk3288
2016-02-23 13:40 [PATCH 0/2] ARM: dts: rockchip: fix some interrupts on rk3288 John Keeping
@ 2016-02-23 13:40 ` John Keeping
[not found] ` <1456234860-18832-1-git-send-email-john-HooS5bfzL4hWk0Htik3J/w@public.gmane.org>
2016-02-24 13:37 ` [PATCH 0/2] ARM: dts: rockchip: fix some " Heiko Stuebner
2 siblings, 0 replies; 4+ messages in thread
From: John Keeping @ 2016-02-23 13:40 UTC (permalink / raw
To: Heiko Stuebner
Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Russell King, linux-arm-kernel, linux-rockchip, devicetree,
linux-kernel, John Keeping
This isn't currently used by the driver but the correct value is 19
since DSIHOST0 is 51 in the TRM and the GIC offset requires 32 to be
subtracted.
Signed-off-by: John Keeping <john@metanate.com>
---
arch/arm/boot/dts/rk3288.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
index c75914b..5597105 100644
--- a/arch/arm/boot/dts/rk3288.dtsi
+++ b/arch/arm/boot/dts/rk3288.dtsi
@@ -857,7 +857,7 @@
mipi_dsi: mipi@ff960000 {
compatible = "rockchip,rk3288-mipi-dsi", "snps,dw-mipi-dsi";
reg = <0xff960000 0x4000>;
- interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
+ interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cru SCLK_MIPIDSI_24M>, <&cru PCLK_MIPI_DSI0>;
clock-names = "ref", "pclk";
rockchip,grf = <&grf>;
--
2.7.0.226.gfe986fe
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] ARM: dts: rockchip: fix audio interrupts on rk3288
[not found] ` <1456234860-18832-1-git-send-email-john-HooS5bfzL4hWk0Htik3J/w@public.gmane.org>
@ 2016-02-23 13:41 ` John Keeping
0 siblings, 0 replies; 4+ messages in thread
From: John Keeping @ 2016-02-23 13:41 UTC (permalink / raw
To: Heiko Stuebner
Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Russell King, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, John Keeping
These must be translated from the values in the TRM by subtracting 32,
which has not been done. The SPDIF interrupt is also off-by-one.
Signed-off-by: John Keeping <john-HooS5bfzL4hWk0Htik3J/w@public.gmane.org>
---
arch/arm/boot/dts/rk3288.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
index 5597105..a82d4b1 100644
--- a/arch/arm/boot/dts/rk3288.dtsi
+++ b/arch/arm/boot/dts/rk3288.dtsi
@@ -758,7 +758,7 @@
clocks = <&cru HCLK_SPDIF8CH>, <&cru SCLK_SPDIF8CH>;
dmas = <&dmac_bus_s 3>;
dma-names = "tx";
- interrupts = <GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>;
+ interrupts = <GIC_SPI 54 IRQ_TYPE_LEVEL_HIGH>;
pinctrl-names = "default";
pinctrl-0 = <&spdif_tx>;
rockchip,grf = <&grf>;
@@ -768,7 +768,7 @@
i2s: i2s@ff890000 {
compatible = "rockchip,rk3288-i2s", "rockchip,rk3066-i2s";
reg = <0xff890000 0x10000>;
- interrupts = <GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>;
+ interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>;
#address-cells = <1>;
#size-cells = <0>;
dmas = <&dmac_bus_s 0>, <&dmac_bus_s 1>;
--
2.7.0.226.gfe986fe
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 0/2] ARM: dts: rockchip: fix some interrupts on rk3288
2016-02-23 13:40 [PATCH 0/2] ARM: dts: rockchip: fix some interrupts on rk3288 John Keeping
2016-02-23 13:40 ` [PATCH 1/2] ARM: dts: rockchip: fix MIPI interrupt " John Keeping
[not found] ` <1456234860-18832-1-git-send-email-john-HooS5bfzL4hWk0Htik3J/w@public.gmane.org>
@ 2016-02-24 13:37 ` Heiko Stuebner
2 siblings, 0 replies; 4+ messages in thread
From: Heiko Stuebner @ 2016-02-24 13:37 UTC (permalink / raw
To: John Keeping
Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Russell King, linux-arm-kernel, linux-rockchip, devicetree,
linux-kernel
Am Dienstag, 23. Februar 2016, 13:40:58 schrieb John Keeping:
> None of these are used by drivers so these don't fix any bugs but maybe
> they'll save someone debugging time in the future.
>
> John Keeping (2):
> ARM: dts: rockchip: fix MIPI interrupt on rk3288
> ARM: dts: rockchip: fix audio interrupts on rk3288
applied both to my dts32 branch for 4.6 after verifying against the TRM as
well.
Thanks for catching these
Heiko
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-02-24 13:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-23 13:40 [PATCH 0/2] ARM: dts: rockchip: fix some interrupts on rk3288 John Keeping
2016-02-23 13:40 ` [PATCH 1/2] ARM: dts: rockchip: fix MIPI interrupt " John Keeping
[not found] ` <1456234860-18832-1-git-send-email-john-HooS5bfzL4hWk0Htik3J/w@public.gmane.org>
2016-02-23 13:41 ` [PATCH 2/2] ARM: dts: rockchip: fix audio interrupts " John Keeping
2016-02-24 13:37 ` [PATCH 0/2] ARM: dts: rockchip: fix some " Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).