* [PATCH V4] dt-bindings: usb: dwc3: Add interrupt-names property support for wakeup interrupt
@ 2023-06-19 10:50 Piyush Mehta
2023-06-19 20:34 ` Conor Dooley
2023-06-19 22:33 ` Rob Herring
0 siblings, 2 replies; 3+ messages in thread
From: Piyush Mehta @ 2023-06-19 10:50 UTC (permalink / raw
To: gregkh, robh+dt, krzysztof.kozlowski+dt, conor+dt, balbi
Cc: linux-usb, devicetree, linux-kernel, michal.simek, git,
Piyush Mehta
The hibernation feature enabled for Xilinx Versal NET SoC in DWC3 IP.
As the DWC3 IP supports the hibernation feature, to handle the wakeup
or hibernation interrupt, add host mode "wakeup" interrupt-names
optional property in the binding schema to capture remote-wakeup and
connect/ disconnect event in the hibernation state and increased maxItems
to 4 for the interrupts and interrupt-names property.
We have a dedicated IRQ line specifically for the hibernation feature.
When the "wakeup" IRQ line is triggered, it initiates a hibernation
interrupt, causing the system to wake up from the hibernation state.
Signed-off-by: Piyush Mehta <piyush.mehta@amd.com>
---
Change in V2:
- Addressed ROB review comments
- Updated name of interrupt-names property with "wakeup"
- Move interrupt-names property from dwc3-xilinx core to dwc3 core.
Link: https://lore.kernel.org/all/CAL_JsqK6_7XD7+w+EQvPPmbmSOpfo3JDb0xDN4StuHUm1kgchw@mail.gmail.com/
Change in V3:
- Addressed Krzysztof Kozlowski comments
- Update binding schema enum.
- Upadet commit message.
Link: https://lore.kernel.org/all/76dfbf27-8ad2-6e09-5354-b006b9e81af1@linaro.org/
Change in V4:
- Addressed ROB review comments:
- Fixed dt_check warnings
Link: https://lore.kernel.org/lkml/168448091422.2968830.10066003697035225886.robh@kernel.org/
---
Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
index 4f7625955ccc..a696f23730d3 100644
--- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
+++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
@@ -44,15 +44,15 @@ properties:
It's either a single common DWC3 interrupt (dwc_usb3) or individual
interrupts for the host, gadget and DRD modes.
minItems: 1
- maxItems: 3
+ maxItems: 4
interrupt-names:
minItems: 1
- maxItems: 3
+ maxItems: 4
oneOf:
- const: dwc_usb3
- items:
- enum: [host, peripheral, otg]
+ enum: [host, peripheral, otg, wakeup]
clocks:
description:
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH V4] dt-bindings: usb: dwc3: Add interrupt-names property support for wakeup interrupt
2023-06-19 10:50 [PATCH V4] dt-bindings: usb: dwc3: Add interrupt-names property support for wakeup interrupt Piyush Mehta
@ 2023-06-19 20:34 ` Conor Dooley
2023-06-19 22:33 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Conor Dooley @ 2023-06-19 20:34 UTC (permalink / raw
To: Piyush Mehta
Cc: gregkh, robh+dt, krzysztof.kozlowski+dt, conor+dt, balbi,
linux-usb, devicetree, linux-kernel, michal.simek, git
[-- Attachment #1: Type: text/plain, Size: 836 bytes --]
On Mon, Jun 19, 2023 at 04:20:32PM +0530, Piyush Mehta wrote:
> The hibernation feature enabled for Xilinx Versal NET SoC in DWC3 IP.
> As the DWC3 IP supports the hibernation feature, to handle the wakeup
> or hibernation interrupt, add host mode "wakeup" interrupt-names
> optional property in the binding schema to capture remote-wakeup and
> connect/ disconnect event in the hibernation state and increased maxItems
> to 4 for the interrupts and interrupt-names property.
>
> We have a dedicated IRQ line specifically for the hibernation feature.
> When the "wakeup" IRQ line is triggered, it initiates a hibernation
> interrupt, causing the system to wake up from the hibernation state.
>
> Signed-off-by: Piyush Mehta <piyush.mehta@amd.com>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Cheers,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V4] dt-bindings: usb: dwc3: Add interrupt-names property support for wakeup interrupt
2023-06-19 10:50 [PATCH V4] dt-bindings: usb: dwc3: Add interrupt-names property support for wakeup interrupt Piyush Mehta
2023-06-19 20:34 ` Conor Dooley
@ 2023-06-19 22:33 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2023-06-19 22:33 UTC (permalink / raw
To: Piyush Mehta
Cc: gregkh, devicetree, conor+dt, krzysztof.kozlowski+dt, git, balbi,
linux-usb, linux-kernel, robh+dt, michal.simek
On Mon, 19 Jun 2023 16:20:32 +0530, Piyush Mehta wrote:
> The hibernation feature enabled for Xilinx Versal NET SoC in DWC3 IP.
> As the DWC3 IP supports the hibernation feature, to handle the wakeup
> or hibernation interrupt, add host mode "wakeup" interrupt-names
> optional property in the binding schema to capture remote-wakeup and
> connect/ disconnect event in the hibernation state and increased maxItems
> to 4 for the interrupts and interrupt-names property.
>
> We have a dedicated IRQ line specifically for the hibernation feature.
> When the "wakeup" IRQ line is triggered, it initiates a hibernation
> interrupt, causing the system to wake up from the hibernation state.
>
> Signed-off-by: Piyush Mehta <piyush.mehta@amd.com>
> ---
> Change in V2:
> - Addressed ROB review comments
> - Updated name of interrupt-names property with "wakeup"
> - Move interrupt-names property from dwc3-xilinx core to dwc3 core.
>
> Link: https://lore.kernel.org/all/CAL_JsqK6_7XD7+w+EQvPPmbmSOpfo3JDb0xDN4StuHUm1kgchw@mail.gmail.com/
>
> Change in V3:
> - Addressed Krzysztof Kozlowski comments
> - Update binding schema enum.
> - Upadet commit message.
>
> Link: https://lore.kernel.org/all/76dfbf27-8ad2-6e09-5354-b006b9e81af1@linaro.org/
>
> Change in V4:
> - Addressed ROB review comments:
> - Fixed dt_check warnings
>
> Link: https://lore.kernel.org/lkml/168448091422.2968830.10066003697035225886.robh@kernel.org/
> ---
> Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-19 22:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-19 10:50 [PATCH V4] dt-bindings: usb: dwc3: Add interrupt-names property support for wakeup interrupt Piyush Mehta
2023-06-19 20:34 ` Conor Dooley
2023-06-19 22:33 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).