From: Conor Dooley <conor@kernel.org>
To: cong yang <yangcong5@huaqin.corp-partner.google.com>
Cc: sam@ravnborg.org, neil.armstrong@linaro.org, daniel@ffwll.ch,
dianders@chromium.org, linus.walleij@linaro.org,
krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
conor+dt@kernel.org, airlied@gmail.com,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
xuxinxiong@huaqin.corp-partner.google.com
Subject: Re: [PATCH v3 1/7] dt-bindings: display: panel: Add himax hx83102 panel bindings
Date: Fri, 26 Apr 2024 18:06:25 +0100 [thread overview]
Message-ID: <20240426-fifteen-random-ff4a535ab40d@spud> (raw)
In-Reply-To: <CAHwB_NLb9ENfCj-oJ2mV_DwFJ0h6TGSi1byUdd6Bri3gDsCo5Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2161 bytes --]
On Thu, Apr 25, 2024 at 02:03:24PM +0800, cong yang wrote:
> Conor Dooley <conor@kernel.org> 于2024年4月25日周四 00:55写道：
> > On Wed, Apr 24, 2024 at 10:30:04AM +0800, Cong Yang wrote:
> > > +++ b/Documentation/devicetree/bindings/display/panel/himax,hx83102.yaml
> >
> > Filename matching a compatible please. What you've done here makes it
> > seem like there's a fallback compatible missing, given this looks like
> > the LCD panel controller and the starry compatible below is an LCD panel.
>
> So change the filename to starry,himax83102-j02.yaml?
IDK chief, are you missing a fallback or not?
>
> >
> > > @@ -0,0 +1,73 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/display/panel/himax,hx83102.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Himax HX83102 MIPI-DSI LCD panel controller
Because the title here makes it seem like there should be.
> > > +maintainers:
> > > + - Cong Yang <yangcong5@huaqin.corp-partner.google.com>
> > > +
> > > +allOf:
> > > + - $ref: panel-common.yaml#
> > > +
> > > +properties:
> > > + compatible:
> > > + enum:
> > > + # STARRY himax83102-j02 10.51" WUXGA TFT LCD panel
> > > + - starry,himax83102-j02
> > > +
> > > + reg:
> > > + description: the virtual channel number of a DSI peripheral
> > > +
> > > + enable-gpios:
> > > + description: a GPIO spec for the enable pin
> > > +
> > > + pp1800-supply:
> > > + description: core voltage supply
> > > +
> > > + avdd-supply:
> > > + description: phandle of the regulator that provides positive voltage
> > > +
> > > + avee-supply:
> > > + description: phandle of the regulator that provides negative voltage
> > > +
> > > + backlight:
> > > + description: phandle of the backlight device attached to the panel
> >
> > I'm not sure why this was given a description when port or rotation
> > was not.
>
> So change it to backlight: true ?
Sure? It is just a repeat of something already described in
panel-common.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-04-26 17:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 2:30 [PATCH v3 0/7] Break out as separate driver and add BOE nv110wum-l60 IVO t109nw41 MIPI-DSI panel Cong Yang
2024-04-24 2:30 ` [PATCH v3 1/7] dt-bindings: display: panel: Add himax hx83102 panel bindings Cong Yang
2024-04-24 16:55 ` Conor Dooley
2024-04-25 6:03 ` cong yang
2024-04-26 17:06 ` Conor Dooley [this message]
2024-04-28 6:12 ` cong yang
2024-04-24 2:30 ` [PATCH v3 2/7] drm/panel: himax-hx83102: Break out as separate driver Cong Yang
2024-04-30 19:19 ` Doug Anderson
2024-05-07 13:44 ` cong yang
2024-05-07 16:29 ` Doug Anderson
2024-04-24 2:30 ` [PATCH v3 3/7] arm64: defconfig: Enable HIMAX_HX83102 panel Cong Yang
2024-04-24 2:30 ` [PATCH v3 4/7] dt-bindings: display: panel: Add compatible for BOE nv110wum-l60 Cong Yang
2024-04-24 2:30 ` [PATCH v3 5/7] drm/panel: himax-hx83102: Support for BOE nv110wum-l60 MIPI-DSI panel Cong Yang
2024-04-24 2:30 ` [PATCH v3 6/7] dt-bindings: display: panel: Add compatible for IVO t109nw41 Cong Yang
2024-04-24 2:30 ` [PATCH v3 7/7] drm/panel: himax-hx83102: Support for IVO t109nw41 MIPI-DSI panel Cong Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240426-fifteen-random-ff4a535ab40d@spud \
--to=conor@kernel.org \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=xuxinxiong@huaqin.corp-partner.google.com \
--cc=yangcong5@huaqin.corp-partner.google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).