From: Conor Dooley <conor@kernel.org>
To: Ramona Gradinariu <ramona.bolboaca13@gmail.com>
Cc: linux-kernel@vger.kernel.org, jic23@kernel.org,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
conor+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
robh@kernel.org, nuno.sa@analog.com
Subject: Re: [PATCH v2 7/8] dt-bindings: iio: imu: Add ADIS1657X family devices compatibles
Date: Wed, 8 May 2024 18:18:03 +0100 [thread overview]
Message-ID: <20240508-monsoon-theology-d141f4e32bad@spud> (raw)
In-Reply-To: <20240508131310.880479-8-ramona.bolboaca13@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1469 bytes --]
On Wed, May 08, 2024 at 04:13:09PM +0300, Ramona Gradinariu wrote:
> Add ADIS1657X family devices compatibles and specify the according
> maximum SPI baudrate.
> Similarly to other ADIS1650X devices, ADIS1657X supports sync-mode
> values [0,2].
> Each newly added device has a different angular velocity/linear
> acceleration/ delta velocity scale combination, as follows:
> Accel dynamic range sensitivity:
> - 262144000 LSB/g: ADIS16575
> - 52428800 LSB/g: ADIS16576, ADIS16577
> Gyro dynamic range sensitivity:
> - 2621440 LSB/deg/sec: ADIS1575-2, ADIS1576-2, ADIS1577-2
> - 655360 LSB/deg/sec: ADIS1575-3, ADIS1576-3, ADIS1577-3
> Delta velocity sensitivity:
> - 2^15/100 LSB/m/sec: ADIS16575
> - 2^15/125 LSB/m/sec: ADIS16576
> - 2^15/400 LSB/m/sec: ADIS16577
> Each ADIS1657X device supports FIFO usage and a sample-rate of 4.1KHz,
> meanwhile the already existing devices do not support FIFO usage and
> have a maximum sample-rate of 2.1KHz.
>
> Signed-off-by: Ramona Gradinariu <ramona.bolboaca13@gmail.com>
> ---
> changes in v2:
> - updated commit message stating the differences between the new added devices
> and existing ones supported by this driver
Thanks for that. Was much easier to understand this way than cross
checking a bunch of structs and the justification for how the bindings
look should be in the binding commit message anyway :)
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Cheers,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-05-08 17:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 13:13 [PATCH v2 0/8] adis16501 and adis1657x support Ramona Gradinariu
2024-05-08 13:13 ` [PATCH v2 1/8] dt-bindings: iio: imu: Add ADIS16501 compatibles Ramona Gradinariu
2024-05-08 13:13 ` [PATCH v2 2/8] drivers: iio: imu: Add support for ADIS16501 Ramona Gradinariu
2024-05-08 13:13 ` [PATCH v2 3/8] iio: imu: adis16475: Re-define ADIS16475_DATA Ramona Gradinariu
2024-05-08 13:13 ` [PATCH v2 4/8] iio: imu: adis_buffer: Add buffer setup API with buffer attributes Ramona Gradinariu
2024-05-10 22:21 ` kernel test robot
2024-05-11 13:22 ` Jonathan Cameron
2024-05-08 13:13 ` [PATCH v2 5/8] iio: imu: adis16475: Create push single sample API Ramona Gradinariu
2024-05-08 13:13 ` [PATCH v2 6/8] drivers: iio: imu: adis16475: generic computation for sample rate Ramona Gradinariu
2024-05-08 13:13 ` [PATCH v2 7/8] dt-bindings: iio: imu: Add ADIS1657X family devices compatibles Ramona Gradinariu
2024-05-08 17:18 ` Conor Dooley [this message]
2024-05-08 13:13 ` [PATCH v2 8/8] drivers: iio: imu: Add support for adis1657x family Ramona Gradinariu
2024-05-10 23:24 ` kernel test robot
2024-05-11 13:24 ` Jonathan Cameron
2024-05-11 13:54 ` Jonathan Cameron
2024-05-17 8:00 ` Ramona Gradinariu
2024-05-19 17:43 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240508-monsoon-theology-d141f4e32bad@spud \
--to=conor@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=ramona.bolboaca13@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).