From: Conor Dooley <conor@kernel.org>
To: Alina Yu <alina_yu@richtek.com>
Cc: lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
johnny_lai@richtek.com, cy_huang@richtek.com
Subject: Re: [PATCH v3 6/6] regulator: dt-bindings: rtq2208: Add property to get ldo of RTQ2208 is adjustable or not
Date: Mon, 13 May 2024 17:22:54 +0100 [thread overview]
Message-ID: <20240513-tissue-repave-13d2e3bf88fd@spud> (raw)
In-Reply-To: <6a3a90d9aa2022dfb92e124e417f3e72c2f28b0b.1715340537.git.alina_yu@richtek.com>
[-- Attachment #1: Type: text/plain, Size: 1696 bytes --]
On Fri, May 10, 2024 at 08:06:25PM +0800, Alina Yu wrote:
> Since there is no way to check is ldo is adjustable or not.
> As discussing in v2 series, 'richtek,fixed-microvolt' is added for that.
> user is supposed to know whether vout of ldo is adjustable.
>
> Signed-off-by: Alina Yu <alina_yu@richtek.com>
> ---
> Documentation/devicetree/bindings/regulator/richtek,rtq2208.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/regulator/richtek,rtq2208.yaml b/Documentation/devicetree/bindings/regulator/richtek,rtq2208.yaml
> index 609c066..6212f44 100644
> --- a/Documentation/devicetree/bindings/regulator/richtek,rtq2208.yaml
> +++ b/Documentation/devicetree/bindings/regulator/richtek,rtq2208.yaml
> @@ -75,6 +75,13 @@ properties:
> description:
> regulator description for ldo[1-2].
>
> + properties:
> + richtek,fixed-microvolt:
> + description: |
> + If it exists, the voltage is unadjustable.
> + There is no risk-free method for software to determine whether the ldo vout is fixed or not.
> + Therefore, it can only be done in this way.
> +
> required:
> - compatible
> - reg
> @@ -177,6 +184,7 @@ examples:
> };
> };
> ldo1 {
> + richtek,fixed-microvolt = <1200000>;
> regulator-min-microvolt = <1200000>;
> regulator-max-microvolt = <1200000>;
I'm dumb and this example seemed odd to me. Can you explain to me why
it is not sufficient to set min-microvolt == max-microvolt to achieve
the same thing?
Cheers,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-05-13 16:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 12:06 [PATCH v3 0/6] Fix rtq2208 BUCK ramp_delay and LDO dvs setting Alina Yu
2024-05-10 12:06 ` [PATCH v3 1/6] regulator: rtq2208: Fix invalid memory access when devm_of_regulator_put_matches is called Alina Yu
2024-05-15 15:47 ` Mark Brown
2024-05-27 9:31 ` Alina Yu
2024-05-10 12:06 ` [PATCH v3 2/6] regulator: rtq2208: Fix LDO vsel setting Alina Yu
2024-05-10 12:06 ` [PATCH v3 3/6] regulator: rtq2208: Fix LDO discharge register Alina Yu
2024-05-10 12:06 ` [PATCH v3 4/6] regulator: rtq2208: Fix the BUCK ramp_delay range to maximum of 16mVstep/us Alina Yu
2024-05-10 12:06 ` [PATCH v3 5/6] regulator: rtq2208: Fix LDO to be compatible with both fixed and adjustable vout Alina Yu
2024-05-10 12:06 ` [PATCH v3 6/6] regulator: dt-bindings: rtq2208: Add property to get ldo of RTQ2208 is adjustable or not Alina Yu
2024-05-13 16:22 ` Conor Dooley [this message]
2024-05-14 10:34 ` Mark Brown
2024-05-14 18:01 ` Conor Dooley
2024-05-15 7:38 ` Alina Yu
2024-05-15 8:06 ` Conor Dooley
2024-05-15 9:02 ` Alina Yu
2024-05-15 15:51 ` Conor Dooley
2024-05-15 16:04 ` Mark Brown
2024-05-15 16:16 ` Conor Dooley
2024-05-15 12:10 ` Mark Brown
2024-05-15 15:48 ` Conor Dooley
2024-05-29 11:21 ` (subset) [PATCH v3 0/6] Fix rtq2208 BUCK ramp_delay and LDO dvs setting Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240513-tissue-repave-13d2e3bf88fd@spud \
--to=conor@kernel.org \
--cc=alina_yu@richtek.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=johnny_lai@richtek.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).