From: "Yankejian (Hackim Yim)" <yankejian@huawei.com>
To: Rob Herring <robh@kernel.org>
Cc: davem@davemloft.net, arnd@arndb.de, fengguang.wu@intel.com,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
catalin.marinas@arm.com, will.deacon@arm.com,
salil.mehta@huawei.com, Yisen.Zhuang@huawei.com,
liguozhu@huawei.com, lisheng011@huawei.com,
huangdaode@hisilicon.com, xuwei5@hisilicon.com,
haifeng.wei@huawei.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linuxarm@huawei.com
Subject: Re: [PATCH net-next 2/2] net: hns: enet specisies a reference to dsaf (config and documents)
Date: Tue, 8 Dec 2015 20:21:05 +0800 [thread overview]
Message-ID: <5666CB31.6090109@huawei.com> (raw)
In-Reply-To: <20151207141221.GA18040@rob-hp-laptop>
On 2015/12/7 22:12, Rob Herring wrote:
> On Sat, Dec 05, 2015 at 03:59:16PM +0800, yankejian wrote:
>> when enet specisies a reference to dsaf, the correlative config and
> s/when/When/
ok，i will pay attention to it on patch v3.
thanks.
>> documents needs to update. this patch updates the correlative dtsi file
> s/this/This/
ok，i will pay attention to it on patch v3.
thanks.
>> and bindings documents .
> ^
> extra space
>
> This change breaks compatibility with old dtbs. IIRC, this is all new,
> so maybe it doesn't matter, but you should be explicit that you are
> doing that.
>
ok，i will pay attention to it on patch v3.
thanks.
>> Signed-off-by: yankejian <yankejian@huawei.com>
>> ---
>> .../devicetree/bindings/net/hisilicon-hns-dsaf.txt | 5 +----
>> .../devicetree/bindings/net/hisilicon-hns-nic.txt | 7 ++++---
>> arch/arm64/boot/dts/hisilicon/hip05_hns.dtsi | 19 +++++++++----------
>> 3 files changed, 14 insertions(+), 17 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/net/hisilicon-hns-dsaf.txt b/Documentation/devicetree/bindings/net/hisilicon-hns-dsaf.txt
>> index 80411b2..ecacfa4 100644
>> --- a/Documentation/devicetree/bindings/net/hisilicon-hns-dsaf.txt
>> +++ b/Documentation/devicetree/bindings/net/hisilicon-hns-dsaf.txt
>> @@ -4,8 +4,6 @@ Required properties:
>> - compatible: should be "hisilicon,hns-dsaf-v1" or "hisilicon,hns-dsaf-v2".
>> "hisilicon,hns-dsaf-v1" is for hip05.
>> "hisilicon,hns-dsaf-v2" is for Hi1610 and Hi1612.
>> -- dsa-name: dsa fabric name who provide this interface.
>> - should be "dsafX", X is the dsaf id.
>> - mode: dsa fabric mode string. only support one of dsaf modes like these:
>> "2port-64vf",
>> "6port-16rss",
>> @@ -26,9 +24,8 @@ Required properties:
>>
>> Example:
>>
>> -dsa: dsa@c7000000 {
>> +dsaf0: dsa@c7000000 {
>> compatible = "hisilicon,hns-dsaf-v1";
>> - dsa_name = "dsaf0";
>> mode = "6port-16rss";
>> interrupt-parent = <&mbigen_dsa>;
>> reg = <0x0 0xC0000000 0x0 0x420000
>> diff --git a/Documentation/devicetree/bindings/net/hisilicon-hns-nic.txt b/Documentation/devicetree/bindings/net/hisilicon-hns-nic.txt
>> index 41d19be..e6a9d1c 100644
>> --- a/Documentation/devicetree/bindings/net/hisilicon-hns-nic.txt
>> +++ b/Documentation/devicetree/bindings/net/hisilicon-hns-nic.txt
>> @@ -4,8 +4,9 @@ Required properties:
>> - compatible: "hisilicon,hns-nic-v1" or "hisilicon,hns-nic-v2".
>> "hisilicon,hns-nic-v1" is for hip05.
>> "hisilicon,hns-nic-v2" is for Hi1610 and Hi1612.
>> -- ae-name: accelerator name who provides this interface,
>> - is simply a name referring to the name of name in the accelerator node.
>> +- ae-handle: accelerator engine handle for hns,
>> + specifies a reference to the associating hardware driver node.
>> + see Documentation/devicetree/bindings/net/hisilicon-hns-dsaf.txt
>> - port-id: is the index of port provided by DSAF (the accelerator). DSAF can
>> connect to 8 PHYs. Port 0 to 1 are both used for adminstration purpose. They
>> are called debug ports.
>> @@ -41,7 +42,7 @@ Example:
>>
>> ethernet@0{
>> compatible = "hisilicon,hns-nic-v1";
>> - ae-name = "dsaf0";
>> + ae-handle = <&dsaf0>;
>> port-id = <0>;
>> local-mac-address = [a2 14 e4 4b 56 76];
>> };
>> diff --git a/arch/arm64/boot/dts/hisilicon/hip05_hns.dtsi b/arch/arm64/boot/dts/hisilicon/hip05_hns.dtsi
>> index 606dd5a..89c883e 100644
>> --- a/arch/arm64/boot/dts/hisilicon/hip05_hns.dtsi
>> +++ b/arch/arm64/boot/dts/hisilicon/hip05_hns.dtsi
>> @@ -23,9 +23,8 @@ soc0: soc@000000000 {
>> };
>> };
>>
>> - dsa: dsa@c7000000 {
>> + dsaf0: dsa@c7000000 {
>> compatible = "hisilicon,hns-dsaf-v1";
>> - dsa_name = "dsaf0";
>> mode = "6port-16rss";
>> interrupt-parent = <&mbigen_dsa>;
>>
>> @@ -127,7 +126,7 @@ soc0: soc@000000000 {
>>
>> eth0: ethernet@0{
>> compatible = "hisilicon,hns-nic-v1";
>> - ae-name = "dsaf0";
>> + ae-handle = <&dsaf0>;
>> port-id = <0>;
>> local-mac-address = [00 00 00 01 00 58];
>> status = "disabled";
>> @@ -135,14 +134,14 @@ soc0: soc@000000000 {
>> };
>> eth1: ethernet@1{
>> compatible = "hisilicon,hns-nic-v1";
>> - ae-name = "dsaf0";
>> + ae-handle = <&dsaf0>;
>> port-id = <1>;
>> status = "disabled";
>> dma-coherent;
>> };
>> eth2: ethernet@2{
>> compatible = "hisilicon,hns-nic-v1";
>> - ae-name = "dsaf0";
>> + ae-handle = <&dsaf0>;
>> port-id = <2>;
>> local-mac-address = [00 00 00 01 00 5a];
>> status = "disabled";
>> @@ -150,7 +149,7 @@ soc0: soc@000000000 {
>> };
>> eth3: ethernet@3{
>> compatible = "hisilicon,hns-nic-v1";
>> - ae-name = "dsaf0";
>> + ae-handle = <&dsaf0>;
>> port-id = <3>;
>> local-mac-address = [00 00 00 01 00 5b];
>> status = "disabled";
>> @@ -158,7 +157,7 @@ soc0: soc@000000000 {
>> };
>> eth4: ethernet@4{
>> compatible = "hisilicon,hns-nic-v1";
>> - ae-name = "dsaf0";
>> + ae-handle = <&dsaf0>;
>> port-id = <4>;
>> local-mac-address = [00 00 00 01 00 5c];
>> status = "disabled";
>> @@ -166,7 +165,7 @@ soc0: soc@000000000 {
>> };
>> eth5: ethernet@5{
>> compatible = "hisilicon,hns-nic-v1";
>> - ae-name = "dsaf0";
>> + ae-handle = <&dsaf0>;
>> port-id = <5>;
>> local-mac-address = [00 00 00 01 00 5d];
>> status = "disabled";
>> @@ -174,7 +173,7 @@ soc0: soc@000000000 {
>> };
>> eth6: ethernet@6{
>> compatible = "hisilicon,hns-nic-v1";
>> - ae-name = "dsaf0";
>> + ae-handle = <&dsaf0>;
>> port-id = <6>;
>> local-mac-address = [00 00 00 01 00 5e];
>> status = "disabled";
>> @@ -182,7 +181,7 @@ soc0: soc@000000000 {
>> };
>> eth7: ethernet@7{
>> compatible = "hisilicon,hns-nic-v1";
>> - ae-name = "dsaf0";
>> + ae-handle = <&dsaf0>;
>> port-id = <7>;
>> local-mac-address = [00 00 00 01 00 5f];
>> status = "disabled";
>> --
>> 1.9.1
>>
> .
>
next prev parent reply other threads:[~2015-12-08 12:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-05 7:59 [PATCH net-next 0/2] net: hns: enet specisies a reference to dsaf yankejian
2015-12-05 7:59 ` [PATCH net-next 1/2] " yankejian
[not found] ` <1449302356-54658-2-git-send-email-yankejian-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-12-08 18:10 ` Florian Fainelli
2015-12-09 10:39 ` Yankejian (Hackim Yim)
2015-12-05 7:59 ` [PATCH net-next 2/2] net: hns: enet specisies a reference to dsaf (config and documents) yankejian
2015-12-07 14:12 ` Rob Herring
2015-12-08 12:21 ` Yankejian (Hackim Yim) [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-12-05 6:10 [PATCH net-next 0/2] net: hns: enet specisies a reference to dsaf yankejian
2015-12-05 6:10 ` [PATCH net-next 2/2] net: hns: enet specisies a reference to dsaf (config and documents) yankejian
2015-12-05 22:19 ` Arnd Bergmann
2015-12-07 7:14 ` Yankejian (Hackim Yim)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5666CB31.6090109@huawei.com \
--to=yankejian@huawei.com \
--cc=Yisen.Zhuang@huawei.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=fengguang.wu@intel.com \
--cc=galak@codeaurora.org \
--cc=haifeng.wei@huawei.com \
--cc=huangdaode@hisilicon.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=liguozhu@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=lisheng011@huawei.com \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=robh@kernel.org \
--cc=salil.mehta@huawei.com \
--cc=will.deacon@arm.com \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).