* [PATCH] ARM64: dts: Mediatek: mt8173-evb: fix access MMC fail issue
@ 2016-02-19 6:00 Eddie Huang
[not found] ` <1455861643-24307-1-git-send-email-eddie.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Eddie Huang @ 2016-02-19 6:00 UTC (permalink / raw
To: Matthias Brugger, Kevin Hilman
Cc: Henry Chen, Chaotian Jing, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
srv_heupstream-NuS5LvNUpcJWk0Htik3J/w, Eddie Huang
MT8173 E1 chip has one bug that if turn off USB power domain, vcore
power will also be off, thus cause modules using vcore power domain
fail, like MMC. The E1 chip only found on MT8173-evb board and this
board only has E1 chip, so implement this as a board specific
workaround.
Pwrapper use vcore power, so add pwrapper using USB power domain to
keep USB power domain not to zero and disabled.
Signed-off-by: Eddie Huang <eddie.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
---
Sascha sent similar patch before[0], but MMC support runtime-pm,
vcore power domain still be disabled after MMC and USB suspend.
This silicon bug already fix in MT8173 MP chip.
[0]:http://lists.infradead.org/pipermail/linux-arm-kernel/2015-July/358065.html
---
arch/arm64/boot/dts/mediatek/mt8173-evb.dts | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
index e427f04..7453a47 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
@@ -214,6 +214,9 @@
};
&pwrap {
+ /* Only MT8173 E1 needs USB power domain */
+ power-domains = <&scpsys MT8173_POWER_DOMAIN_USB>;
+
pmic: mt6397 {
compatible = "mediatek,mt6397";
interrupt-parent = <&pio>;
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM64: dts: Mediatek: mt8173-evb: fix access MMC fail issue
[not found] ` <1455861643-24307-1-git-send-email-eddie.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
@ 2016-02-19 10:05 ` Matthias Brugger
2016-02-23 0:32 ` Kevin Hilman
1 sibling, 0 replies; 5+ messages in thread
From: Matthias Brugger @ 2016-02-19 10:05 UTC (permalink / raw
To: Eddie Huang, Kevin Hilman
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
srv_heupstream-NuS5LvNUpcJWk0Htik3J/w,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Henry Chen,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Chaotian Jing,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Hi Eddie,
On 19/02/16 07:00, Eddie Huang wrote:
> MT8173 E1 chip has one bug that if turn off USB power domain, vcore
> power will also be off, thus cause modules using vcore power domain
> fail, like MMC. The E1 chip only found on MT8173-evb board and this
> board only has E1 chip, so implement this as a board specific
> workaround.
>
> Pwrapper use vcore power, so add pwrapper using USB power domain to
> keep USB power domain not to zero and disabled.
>
> Signed-off-by: Eddie Huang <eddie.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
>
> ---
> Sascha sent similar patch before[0], but MMC support runtime-pm,
> vcore power domain still be disabled after MMC and USB suspend.
> This silicon bug already fix in MT8173 MP chip.
>
> [0]:http://lists.infradead.org/pipermail/linux-arm-kernel/2015-July/358065.html
> ---
> arch/arm64/boot/dts/mediatek/mt8173-evb.dts | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
> index e427f04..7453a47 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
> @@ -214,6 +214,9 @@
> };
>
> &pwrap {
> + /* Only MT8173 E1 needs USB power domain */
> + power-domains = <&scpsys MT8173_POWER_DOMAIN_USB>;
> +
Applied, thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM64: dts: Mediatek: mt8173-evb: fix access MMC fail issue
[not found] ` <1455861643-24307-1-git-send-email-eddie.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2016-02-19 10:05 ` Matthias Brugger
@ 2016-02-23 0:32 ` Kevin Hilman
[not found] ` <7h37skw9jd.fsf-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
1 sibling, 1 reply; 5+ messages in thread
From: Kevin Hilman @ 2016-02-23 0:32 UTC (permalink / raw
To: Eddie Huang
Cc: Matthias Brugger, Henry Chen, Chaotian Jing,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
srv_heupstream-NuS5LvNUpcJWk0Htik3J/w
Eddie Huang <eddie.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> writes:
> MT8173 E1 chip has one bug that if turn off USB power domain, vcore
> power will also be off, thus cause modules using vcore power domain
> fail, like MMC. The E1 chip only found on MT8173-evb board and this
> board only has E1 chip, so implement this as a board specific
> workaround.
>
> Pwrapper use vcore power, so add pwrapper using USB power domain to
> keep USB power domain not to zero and disabled.
>
> Signed-off-by: Eddie Huang <eddie.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Tested-by: Kevin Hilman <khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
I verified that this gets my mt8173-evb booting again when I enable MMC
support.
Thanks,
Kevin
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM64: dts: Mediatek: mt8173-evb: fix access MMC fail issue
[not found] ` <7h37skw9jd.fsf-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
@ 2016-02-23 8:53 ` Matthias Brugger
[not found] ` <56CC1E0E.4050400-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Matthias Brugger @ 2016-02-23 8:53 UTC (permalink / raw
To: Kevin Hilman, Eddie Huang
Cc: Henry Chen, Chaotian Jing, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
srv_heupstream-NuS5LvNUpcJWk0Htik3J/w
On 23/02/16 01:32, Kevin Hilman wrote:
> Eddie Huang <eddie.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> writes:
>
>> MT8173 E1 chip has one bug that if turn off USB power domain, vcore
>> power will also be off, thus cause modules using vcore power domain
>> fail, like MMC. The E1 chip only found on MT8173-evb board and this
>> board only has E1 chip, so implement this as a board specific
>> workaround.
>>
>> Pwrapper use vcore power, so add pwrapper using USB power domain to
>> keep USB power domain not to zero and disabled.
>>
>> Signed-off-by: Eddie Huang <eddie.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
>
> Tested-by: Kevin Hilman <khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
>
I send the patch in a pull request yesterday, so I won't be able to add
your tag.
Thanks for testing and reporting this issue!
Matthias
> I verified that this gets my mt8173-evb booting again when I enable MMC
> support.
>
> Thanks,
>
> Kevin
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM64: dts: Mediatek: mt8173-evb: fix access MMC fail issue
[not found] ` <56CC1E0E.4050400-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2016-02-23 18:32 ` Kevin Hilman
0 siblings, 0 replies; 5+ messages in thread
From: Kevin Hilman @ 2016-02-23 18:32 UTC (permalink / raw
To: Matthias Brugger
Cc: Eddie Huang, Henry Chen, Chaotian Jing,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
srv_heupstream-NuS5LvNUpcJWk0Htik3J/w
Matthias Brugger <matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> writes:
> On 23/02/16 01:32, Kevin Hilman wrote:
>> Eddie Huang <eddie.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> writes:
>>
>>> MT8173 E1 chip has one bug that if turn off USB power domain, vcore
>>> power will also be off, thus cause modules using vcore power domain
>>> fail, like MMC. The E1 chip only found on MT8173-evb board and this
>>> board only has E1 chip, so implement this as a board specific
>>> workaround.
>>>
>>> Pwrapper use vcore power, so add pwrapper using USB power domain to
>>> keep USB power domain not to zero and disabled.
>>>
>>> Signed-off-by: Eddie Huang <eddie.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
>>
>> Tested-by: Kevin Hilman <khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
>>
>
> I send the patch in a pull request yesterday, so I won't be able to
> add your tag.
No worries. Was on vacation, so couldn't test sooner.
> Thanks for testing and reporting this issue!
You're welcome,
Kevin
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-02-23 18:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-19 6:00 [PATCH] ARM64: dts: Mediatek: mt8173-evb: fix access MMC fail issue Eddie Huang
[not found] ` <1455861643-24307-1-git-send-email-eddie.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2016-02-19 10:05 ` Matthias Brugger
2016-02-23 0:32 ` Kevin Hilman
[not found] ` <7h37skw9jd.fsf-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2016-02-23 8:53 ` Matthias Brugger
[not found] ` <56CC1E0E.4050400-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-02-23 18:32 ` Kevin Hilman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).