From: Krzysztof Kozlowski <krzk@kernel.org>
To: Mithil <bavishimithil@gmail.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] ASoC: dt-bindings: omap-mcpdm: Convert to DT schema
Date: Sun, 5 May 2024 10:26:49 +0200 [thread overview]
Message-ID: <676ce61c-e850-4046-ad0f-e3382be3fe0c@kernel.org> (raw)
In-Reply-To: <CAGzNGR=pvv67UJtNnkDUMhrpnPjNCCYEGeCaM7e_9=4G+Lcfgw@mail.gmail.com>
On 05/05/2024 09:36, Mithil wrote:
> On Wed, Apr 17, 2024 at 7:33 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
>> How did this happen? I see this was in v1, but I am quite surprised to
>> be listed here. I am for sure not a maintainer of this binding. Choose
>> driver maintainers or platform maintainers, worse case.
>
> I might have overlooked this, will fix it. There is no driver
> maintainer for it as far as I know.
> Should I include the module author?
Or platform maintainers or whoever is interested in this hardware.
>
>> Not much improved here. You miss $ref and optionally constraints.
> Something like this
> $ref: /schemas/types.yaml#/definitions/string
> enum: [mcpdm]
> Didnt really understand the "optionally constraints" part.
Sorry, you stripped out *entire* context. No clue what you refer to.
>
>> Missing constraints, so replace it with maxItems: 1
> Similar to how clock-names are handled?
>
>> List the items. I asked to open existing bindings and take a look how it
>> is there. Existing bindings would show you how we code this part.
> clock-names:
> items:
> - const: pdmclk
> minItems: 1
> maxItems: 1
> Something like this?
No. Do you see code like this anywhere? Please only list the items,
although without context impossible to judge.
>
>> Just one blank line.
> Removed.
>
>> That's wrong address. Old code does not have 0. Please do no change
>> parts of code without reason. If there is a reason, explain it in the
>> changelog.
>>
> The checks were giving a warning if 0 was not included hence, I'll put
> the real address if needed then.
>
>> Include header and use common defines for flags. Just like all other
>> recent bindings.
>>
> There's no defines for them, this is how it is in the dts :(
It does not matter whether some particular DTS uses values or defines,
if these are the well known constants. Again, stripping entire context
and replying after 2-3 weeks does not help me to understand this at all.
Between these 2-3 weeks I got another 200 patches to review.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-05-05 8:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 13:42 [PATCH v4] ASoC: dt-bindings: omap-mcpdm: Convert to DT schema Mighty
2024-04-17 14:03 ` Krzysztof Kozlowski
2024-05-05 7:36 ` Mithil
2024-05-05 8:26 ` Krzysztof Kozlowski [this message]
2024-05-05 9:59 ` Mithil
2024-05-05 11:32 ` Krzysztof Kozlowski
2024-05-05 11:49 ` Mithil
2024-05-07 15:12 ` Mithil
2024-05-07 18:23 ` Krzysztof Kozlowski
-- strict thread matches above, loose matches on Subject: below --
2024-05-17 8:36 Mighty
2024-05-17 9:24 ` Rob Herring (Arm)
2024-05-18 11:59 ` Mithil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=676ce61c-e850-4046-ad0f-e3382be3fe0c@kernel.org \
--to=krzk@kernel.org \
--cc=bavishimithil@gmail.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).