From: Laurentiu Mihalcea <laurentiumihalcea111@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
Shengjiu Wang <shengjiu.wang@nxp.com>,
Liu Ying <victor.liu@nxp.com>,
Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>,
devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] dt-bindings: mfd: add schema for 8ulp AVD-SIM
Date: Thu, 9 May 2024 21:48:03 +0300 [thread overview]
Message-ID: <799c3c81-fc33-4f76-bd0b-287e8b8a6f5a@gmail.com> (raw)
In-Reply-To: <20240422142906.GB1207218-robh@kernel.org>
On 4/22/2024 5:29 PM, Rob Herring wrote:
> On Thu, Apr 18, 2024 at 11:37:19PM +0300, Laurentiu Mihalcea wrote:
>> From: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
>>
>> Add schema for i.MX8ULP's AVD-SIM module.
>>
>> Signed-off-by: Liu Ying <victor.liu@nxp.com>
>> Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
>> ---
>> .../bindings/mfd/fsl,imx8ulp-avd-sim.yaml | 42 +++++++++++++++++++
>> 1 file changed, 42 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/mfd/fsl,imx8ulp-avd-sim.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/fsl,imx8ulp-avd-sim.yaml b/Documentation/devicetree/bindings/mfd/fsl,imx8ulp-avd-sim.yaml
>> new file mode 100644
>> index 000000000000..4020c6e37f80
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mfd/fsl,imx8ulp-avd-sim.yaml
>> @@ -0,0 +1,42 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/mfd/fsl,imx8ulp-avd-sim.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: NXP i.MX8ULP Audio-Video Domain System Integration Module
>> +
>> +maintainers:
>> + - Liu Ying <victor.liu@nxp.com>
>> +
>> +description: |
>> + The AVD-SIM module provides configuration options for components of AVD.
>> +
>> +properties:
>> + compatible:
>> + items:
>> + - const: fsl,imx8ulp-avd-sim
>> + - const: syscon
>> + - const: simple-mfd
> 'simple-mfd' means you have child nodes, but you have none defined.
Thanks for the clarification! These were intentionally omitted since they're
not needed for the DSP.
>
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + clocks:
>> + maxItems: 1
> If you do add child nodes, 'simple-mfd' also means there is not any
> dependency on the parent node such as needing this clock to be enabled
> for the child nodes.
>
> Rob
The plan was to add the children later on as required.
Given the children would in fact depend on the parent's clock being
enabled, I wonder if just removing 'simple-mfd' from the compatible
list would do the trick?
next prev parent reply other threads:[~2024-05-09 18:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 20:37 [PATCH 0/3] Add DSP node for imx8ulp Laurentiu Mihalcea
2024-04-18 20:37 ` [PATCH 1/3] dt-bindings: dsp: support imx8ulp dsp clocks Laurentiu Mihalcea
2024-04-18 21:08 ` Frank Li
2024-04-22 14:24 ` Rob Herring
2024-04-22 14:26 ` Rob Herring
2024-04-18 20:37 ` [PATCH 2/3] dt-bindings: mfd: add schema for 8ulp AVD-SIM Laurentiu Mihalcea
2024-04-18 21:10 ` Frank Li
2024-04-22 14:29 ` Rob Herring
2024-05-09 18:48 ` Laurentiu Mihalcea [this message]
2024-05-13 9:02 ` Krzysztof Kozlowski
2024-04-18 20:37 ` [PATCH 3/3] arm64: dts: imx8ulp: add DSP node Laurentiu Mihalcea
2024-04-18 21:17 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=799c3c81-fc33-4f76-bd0b-287e8b8a6f5a@gmail.com \
--to=laurentiumihalcea111@gmail.com \
--cc=conor+dt@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=laurentiu.mihalcea@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@nxp.com \
--cc=victor.liu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).