From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Chanh Nguyen <chanh@os.amperecomputing.com>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Justin Ledford <justinledford@google.com>,
devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-kernel@vger.kernel.org,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
Open Source Submission <patches@amperecomputing.com>
Cc: Phong Vo <phong@os.amperecomputing.com>,
Thang Nguyen <thang@os.amperecomputing.com>,
Quan Nguyen <quan@os.amperecomputing.com>
Subject: Re: [PATCH v2 1/3] dt-bindings: hwmon: Add maxim max31790 bindings
Date: Sun, 14 Apr 2024 08:03:36 +0200 [thread overview]
Message-ID: <80effcab-74b8-4e15-a4db-9982b000b6b1@linaro.org> (raw)
In-Reply-To: <20240414042246.8681-2-chanh@os.amperecomputing.com>
On 14/04/2024 06:22, Chanh Nguyen wrote:
> Add a device tree bindings for max31790 device.
>
Nothing improved in commit msg, where is the rationale of split of bindings?
A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
> Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com>
> ---
> Changes in v2:
> - Update filename of the maxim,max31790.yaml [Krzysztof]
> - Add the common fan schema to $ref [Krzysztof]
> - Update the node name to "fan-controller" in maxim,max31790.yaml [Krzysztof]
> - Drop "driver" in commit title [Krzysztof]
> ---
> .../bindings/hwmon/maxim,max31790.yaml | 52 +++++++++++++++++++
> 1 file changed, 52 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml
>
> diff --git a/Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml b/Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml
> new file mode 100644
> index 000000000000..a561e5a3e9e4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml
> @@ -0,0 +1,52 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/maxim,max31790.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: The Maxim MAX31790 Fan Controller
> +
> +maintainers:
> + - Guenter Roeck <linux@roeck-us.net>
> +
> +description: >
> + The MAX31790 controls the speeds of up to six fans using six
> + independent PWM outputs. The desired fan speeds (or PWM duty cycles)
> + are written through the I2C interface.
> +
> + Datasheets:
> + https://datasheets.maximintegrated.com/en/ds/MAX31790.pdf
> +
> +properties:
> + compatible:
> + const: maxim,max31790
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + resets:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> +
> +allOf:
> + - $ref: fan-common.yaml#
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + fan-controller@20 {
> + compatible = "maxim,max31790";
> + reg = <0x20>;
Make the example complete - add all properties, like clocks, resets and
any others which are applicable.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-04-14 6:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-14 4:22 [PATCH v2 0/3] Update the max31790 driver Chanh Nguyen
2024-04-14 4:22 ` [PATCH v2 1/3] dt-bindings: hwmon: Add maxim max31790 bindings Chanh Nguyen
2024-04-14 6:03 ` Krzysztof Kozlowski [this message]
2024-04-16 4:38 ` Chanh Nguyen
2024-04-14 4:22 ` [PATCH v2 2/3] hwmon: (max31790): Support config PWM output becomes TACH Chanh Nguyen
2024-04-14 8:03 ` Christophe JAILLET
2024-04-16 5:27 ` Chanh Nguyen
2024-04-16 17:39 ` Christophe JAILLET
2024-04-17 2:54 ` Chanh Nguyen
2024-04-14 4:22 ` [PATCH v2 3/3] dt-bindings: hwmon: max31790: Add maxim,pwmout-pin-as-tach-input property Chanh Nguyen
2024-04-14 6:07 ` Krzysztof Kozlowski
2024-04-16 4:52 ` Chanh Nguyen
2024-04-23 8:45 ` Chanh Nguyen
2024-04-23 17:02 ` Conor Dooley
2024-04-25 10:33 ` Chanh Nguyen
2024-04-25 14:05 ` Guenter Roeck
2024-04-25 15:46 ` Krzysztof Kozlowski
2024-04-25 15:56 ` Conor Dooley
2024-05-05 10:08 ` Chanh Nguyen
2024-05-05 15:40 ` Guenter Roeck
2024-05-08 3:44 ` Chanh Nguyen
2024-05-08 16:47 ` Conor Dooley
2024-05-09 8:29 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80effcab-74b8-4e15-a4db-9982b000b6b1@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=chanh@os.amperecomputing.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=justinledford@google.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=openbmc@lists.ozlabs.org \
--cc=patches@amperecomputing.com \
--cc=phong@os.amperecomputing.com \
--cc=quan@os.amperecomputing.com \
--cc=robh+dt@kernel.org \
--cc=thang@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).