From: Shengjiu Wang <shengjiu.wang@gmail.com>
To: Stephen Boyd <sboyd@kernel.org>, p.zabel@pengutronix.de
Cc: Shengjiu Wang <shengjiu.wang@nxp.com>,
abelvesa@kernel.org, conor+dt@kernel.org, festevam@gmail.com,
imx@lists.linux.dev, kernel@pengutronix.de, krzk+dt@kernel.org,
marex@denx.de, mturquette@baylibre.com, peng.fan@nxp.com,
robh@kernel.org, s.hauer@pengutronix.de, shawnguo@kernel.org,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/4] clk: imx: clk-audiomix: Add reset controller
Date: Fri, 10 May 2024 12:02:39 +0800 [thread overview]
Message-ID: <CAA+D8AP9uS1ePxSeSUPGCGe42U5sNguZYQS3d-9T305d2iVbhQ@mail.gmail.com> (raw)
In-Reply-To: <0d10a689504be61c50b186d89ddbf9d1.sboyd@kernel.org>
On Fri, May 10, 2024 at 6:04 AM Stephen Boyd <sboyd@kernel.org> wrote:
>
> Quoting Shengjiu Wang (2024-05-08 18:43:56)
> > Audiomix block control can be a reset controller for
> > Enhanced Audio Return Channel (EARC), which is one of
> > modules in this audiomix subsystem.
> >
> > The EARC PHY software reset and EARC controller software
> > reset need to be supported.
>
> Can you move this to drivers/reset and use auxiliary device APIs to do
> that? The idea would be to have reset maintainers review reset code.
Thanks for your comments.
This is a minor reset control only for XCVR devices, two reset bits
are accessed.
If we move to an auxiliary device, we need to define a new header file
and a new driver, which will bring more code size and complexity.
So is it necessary to separate it to another auxiliary driver/device?
And add Philipp Zabel in loop for review.
Best Regards
Shengjiu Wang
next prev parent reply other threads:[~2024-05-10 4:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 1:43 [PATCH v2 0/4] clk: imx: clk-audiomix: Improvement for audiomix Shengjiu Wang
2024-05-09 1:43 ` [PATCH v2 1/4] dt-bindings: clock: imx8mp: Add #reset-cells property Shengjiu Wang
2024-05-09 7:01 ` Krzysztof Kozlowski
2024-05-09 1:43 ` [PATCH v2 2/4] clk: imx: clk-audiomix: Add reset controller Shengjiu Wang
2024-05-09 22:04 ` Stephen Boyd
2024-05-10 4:02 ` Shengjiu Wang [this message]
2024-05-14 7:22 ` Shengjiu Wang
2024-05-09 1:43 ` [PATCH v2 3/4] clk: imx: clk-audiomix: Add CLK_SET_RATE_PARENT flags for clocks Shengjiu Wang
2024-05-09 1:43 ` [PATCH v2 4/4] clk: imx: clk-audiomix: Corrent parent clock for earc_phy and audpll Shengjiu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAA+D8AP9uS1ePxSeSUPGCGe42U5sNguZYQS3d-9T305d2iVbhQ@mail.gmail.com \
--to=shengjiu.wang@gmail.com \
--cc=abelvesa@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=peng.fan@nxp.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).