From: Binbin Zhou <zhoubb.aaron@gmail.com>
To: Conor Dooley <conor@kernel.org>
Cc: Binbin Zhou <zhoubinbin@loongson.cn>,
Huacai Chen <chenhuacai@loongson.cn>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, Huacai Chen <chenhuacai@kernel.org>,
loongson-kernel@lists.loongnix.cn,
Xuerui Wang <kernel@xen0n.name>,
loongarch@lists.linux.dev
Subject: Re: [PATCH v1 1/2] LoongArch: dts: Add new supported device nodes to Loongson-2K0500
Date: Thu, 9 May 2024 07:10:27 +0600 [thread overview]
Message-ID: <CAMpQs4JyLSGKVWPzej39Rq0G_Z2QmJ0S+y3bMruBm4tO-ZWq+Q@mail.gmail.com> (raw)
In-Reply-To: <20240508-startup-oblivious-d864191f524f@spud>
On Wed, May 8, 2024 at 10:26 PM Conor Dooley <conor@kernel.org> wrote:
>
> On Wed, May 08, 2024 at 04:29:10PM +0800, Binbin Zhou wrote:
> > By now, more Loongson-2K0500 related drivers are supported, such as
> > clock controller, thermal controller, and dma controller.
> > Now we add these device nodes to the Loongson-2K0500 dts file.
> >
> > Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn>
> > ---
> > .../boot/dts/loongson-2k0500-ref.dts | 4 +
> > arch/loongarch/boot/dts/loongson-2k0500.dtsi | 81 ++++++++++++++++++-
> > 2 files changed, 82 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/loongarch/boot/dts/loongson-2k0500-ref.dts b/arch/loongarch/boot/dts/loongson-2k0500-ref.dts
> > index 8aefb0c12672..62dad6297e82 100644
> > --- a/arch/loongarch/boot/dts/loongson-2k0500-ref.dts
> > +++ b/arch/loongarch/boot/dts/loongson-2k0500-ref.dts
> > @@ -41,6 +41,10 @@ linux,cma {
> > };
> > };
> >
> > +&clk {
> > + status = "okay";
> > +};
>
> For most devices, doing the "disable in dtsi, enable in dts" approach is
> the right thing to do, but for things like clock-controllers or
> architectural interrupt controllers that no-one is going to disable
> since they'll not have a usable system otherwise, it's not needed.
>
Hi Conor:
Yes, as you said, it is not needed here. I will check it again.
Thanks.
Binbin
> Cheers,
> Conor.
next prev parent reply other threads:[~2024-05-09 1:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 8:29 [PATCH v1 0/2] LoongArch: dts: Add more support device ndoes to Loongson-2K Binbin Zhou
2024-05-08 8:29 ` [PATCH v1 1/2] LoongArch: dts: Add new supported device nodes to Loongson-2K0500 Binbin Zhou
2024-05-08 16:26 ` Conor Dooley
2024-05-09 1:10 ` Binbin Zhou [this message]
2024-05-08 8:29 ` [PATCH v1 2/2] LoongArch: dts: Add new supported device nodes to Loongson-2K2000 Binbin Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMpQs4JyLSGKVWPzej39Rq0G_Z2QmJ0S+y3bMruBm4tO-ZWq+Q@mail.gmail.com \
--to=zhoubb.aaron@gmail.com \
--cc=chenhuacai@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@xen0n.name \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=loongarch@lists.linux.dev \
--cc=loongson-kernel@lists.loongnix.cn \
--cc=robh+dt@kernel.org \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).