From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Johan Hovold <johan+linaro@kernel.org>
Cc: Lee Jones <lee@kernel.org>, Mark Brown <broonie@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Das Srinagesh <quic_gurus@quicinc.com>,
Satya Priya <quic_c_skakit@quicinc.com>,
Stephen Boyd <swboyd@chromium.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH 12/13] regulator: add pm8008 pmic regulator driver
Date: Mon, 6 May 2024 22:09:50 +0300 [thread overview]
Message-ID: <Zjkq_nWyvc6bUtiu@surfacebook.localdomain> (raw)
In-Reply-To: <20240506150830.23709-13-johan+linaro@kernel.org>
Mon, May 06, 2024 at 05:08:29PM +0200, Johan Hovold kirjoitti:
> From: Satya Priya <quic_c_skakit@quicinc.com>
>
> Qualcomm Technologies, Inc. PM8008 is an I2C-controlled PMIC containing
> seven LDO regulators. Add a PM8008 regulator driver to support PMIC
> regulator management via the regulator framework.
>
> Note that this driver, originally submitted by Satya Priya [1], has been
> reworked to match the new devicetree binding which no longer describes
> each regulator as a separate device.
>
> This avoids describing internal details like register offsets in the
> devicetree and allows for extending the implementation with features
> like over-current protection without having to update the binding.
>
> Specifically note that the regulator interrupts are shared between all
> regulators.
>
> Note that the secondary regmap is looked up by name and that if the
> driver ever needs to be generalised to support regulators provided by
> the primary regmap (I2C address) such information could be added to a
> driver lookup table matching on the parent compatible.
>
> This also fixes the original implementation, which looked up regulators
> by 'regulator-name' property rather than devicetree node name and which
> prevented the regulators from being named to match board schematics.
> [1] https://lore.kernel.org/r/1655200111-18357-8-git-send-email-quic_c_skakit@quicinc.com
Make it Link: tag?
Link: URL [1]
...
> [ johan: rework probe to match new binding, amend commit message and
> Kconfig entry]
Wouldn't be better on one line?
...
+ array_size.h
+ bits.h
> +#include <linux/device.h>
> +#include <linux/kernel.h>
What is this header for?
+ math.h
> +#include <linux/module.h>
> +#include <linux/of.h>
> +#include <linux/platform_device.h>
> +#include <linux/regmap.h>
> +#include <linux/regulator/driver.h>
+ asm/byteorder.h
...
> +static int pm8008_regulator_get_voltage(struct regulator_dev *rdev)
> +{
> + struct pm8008_regulator *pm8008_reg = rdev_get_drvdata(rdev);
> + __le16 mV;
> + int uV;
> +
> + regmap_bulk_read(pm8008_reg->regmap,
> + LDO_VSET_LB_REG(pm8008_reg->base), (void *)&mV, 2);
Why casting?
> + uV = le16_to_cpu(mV) * 1000;
> + return (uV - pm8008_reg->rdesc.min_uV) / pm8008_reg->rdesc.uV_step;
> +}
> +
> +static inline int pm8008_write_voltage(struct pm8008_regulator *pm8008_reg,
> + int mV)
> +{
> + __le16 vset_raw;
> +
> + vset_raw = cpu_to_le16(mV);
Can be joined to a single line.
> + return regmap_bulk_write(pm8008_reg->regmap,
> + LDO_VSET_LB_REG(pm8008_reg->base),
> + (const void *)&vset_raw, sizeof(vset_raw));
Why casting?
> +}
...
> +static int pm8008_regulator_set_voltage(struct regulator_dev *rdev,
> + unsigned int selector)
> +{
> + struct pm8008_regulator *pm8008_reg = rdev_get_drvdata(rdev);
> + int rc, mV;
> +
> + rc = regulator_list_voltage_linear_range(rdev, selector);
> + if (rc < 0)
> + return rc;
> +
> + /* voltage control register is set with voltage in millivolts */
> + mV = DIV_ROUND_UP(rc, 1000);
> + rc = pm8008_write_voltage(pm8008_reg, mV);
> + if (rc < 0)
> + return rc;
> +
> + return 0;
return pm8008_write_voltage(pm8008_reg, mV);
?
> +}
> +
> + regmap = dev_get_regmap(dev->parent, "secondary");
> + if (!regmap)
> + return -EINVAL;
> +
> + for (i = 0; i < ARRAY_SIZE(reg_data); i++) {
> + pm8008_reg = devm_kzalloc(dev, sizeof(*pm8008_reg), GFP_KERNEL);
> + if (!pm8008_reg)
> + return -ENOMEM;
> +
> + pm8008_reg->regmap = regmap;
> + pm8008_reg->base = reg_data[i].base;
> +
> + /* get slew rate */
> + rc = regmap_bulk_read(pm8008_reg->regmap,
> + LDO_STEPPER_CTL_REG(pm8008_reg->base), &val, 1);
> + if (rc < 0) {
> + dev_err(dev, "failed to read step rate: %d\n", rc);
> + return rc;
return dev_err_probe(...);
> + }
> + val &= STEP_RATE_MASK;
> + pm8008_reg->step_rate = DEFAULT_VOLTAGE_STEPPER_RATE >> val;
> + rdesc = &pm8008_reg->rdesc;
> + rdesc->type = REGULATOR_VOLTAGE;
> + rdesc->ops = &pm8008_regulator_ops;
> + rdesc->name = reg_data[i].name;
> + rdesc->supply_name = reg_data[i].supply_name;
> + rdesc->of_match = reg_data[i].name;
> + rdesc->uV_step = VSET_STEP_UV;
> + rdesc->linear_ranges = reg_data[i].voltage_range;
> + rdesc->n_linear_ranges = 1;
> + BUILD_BUG_ON((ARRAY_SIZE(pldo_ranges) != 1) ||
> + (ARRAY_SIZE(nldo_ranges) != 1));
> +
> + if (reg_data[i].voltage_range == nldo_ranges) {
> + rdesc->min_uV = NLDO_MIN_UV;
> + rdesc->n_voltages = ((NLDO_MAX_UV - NLDO_MIN_UV) / rdesc->uV_step) + 1;
> + } else {
> + rdesc->min_uV = PLDO_MIN_UV;
> + rdesc->n_voltages = ((PLDO_MAX_UV - PLDO_MIN_UV) / rdesc->uV_step) + 1;
> + }
> +
> + rdesc->enable_reg = LDO_ENABLE_REG(pm8008_reg->base);
> + rdesc->enable_mask = ENABLE_BIT;
> + rdesc->min_dropout_uV = reg_data[i].min_dropout_uv;
> + rdesc->regulators_node = of_match_ptr("regulators");
> +
> + reg_config.dev = dev->parent;
> + reg_config.driver_data = pm8008_reg;
> + reg_config.regmap = pm8008_reg->regmap;
> +
> + rdev = devm_regulator_register(dev, rdesc, ®_config);
> + if (IS_ERR(rdev)) {
> + rc = PTR_ERR(rdev);
> + dev_err(dev, "failed to register regulator %s: %d\n",
> + reg_data[i].name, rc);
> + return rc;
return dev_err_probe(...);
> + }
> + }
> +
> + return 0;
> +}
...
> +static struct platform_driver pm8008_regulator_driver = {
> + .driver = {
> + .name = "qcom-pm8008-regulator",
> + },
> + .probe = pm8008_regulator_probe,
> +};
> +
Unneeded blank line.
> +module_platform_driver(pm8008_regulator_driver);
...
> +MODULE_ALIAS("platform:qcom-pm8008-regulator");
Use ID table instead.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-05-06 19:11 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 15:08 [PATCH 00/13] arm64: dts: qcom: sc8280xp-x13s: enable pm8008 camera pmic Johan Hovold
2024-05-06 15:08 ` [PATCH 01/13] dt-bindings: mfd: pm8008: add reset gpio Johan Hovold
2024-05-07 6:38 ` Krzysztof Kozlowski
2024-05-08 21:39 ` Stephen Boyd
2024-05-27 13:32 ` Linus Walleij
2024-05-06 15:08 ` [PATCH 02/13] mfd: pm8008: fix regmap irq chip initialisation Johan Hovold
2024-05-06 18:56 ` Andy Shevchenko
2024-05-07 15:01 ` Johan Hovold
2024-05-07 17:16 ` Andy Shevchenko
2024-05-09 8:49 ` Johan Hovold
2024-05-09 13:26 ` Andy Shevchenko
2024-05-06 15:08 ` [PATCH 03/13] mfd: pm8008: deassert reset on probe Johan Hovold
2024-05-06 18:57 ` Andy Shevchenko
2024-05-07 15:15 ` Johan Hovold
2024-05-08 16:12 ` Bryan O'Donoghue
2024-05-09 9:31 ` Johan Hovold
2024-05-29 16:17 ` Johan Hovold
2024-05-29 18:52 ` Bryan O'Donoghue
2024-05-27 13:39 ` Linus Walleij
2024-05-06 15:08 ` [PATCH 04/13] mfd: pm8008: mark regmap structures as const Johan Hovold
2024-05-08 17:37 ` Bryan O'Donoghue
2024-05-08 22:03 ` Stephen Boyd
2024-05-06 15:08 ` [PATCH 05/13] mfd: pm8008: use lower case hex notation Johan Hovold
2024-05-08 17:38 ` Bryan O'Donoghue
2024-05-08 22:03 ` Stephen Boyd
2024-05-06 15:08 ` [PATCH 06/13] mfd: pm8008: rename irq chip Johan Hovold
2024-05-08 17:38 ` Bryan O'Donoghue
2024-05-08 22:04 ` Stephen Boyd
2024-05-06 15:08 ` [PATCH 07/13] mfd: pm8008: drop unused driver data Johan Hovold
2024-05-08 17:40 ` Bryan O'Donoghue
2024-05-08 22:05 ` Stephen Boyd
2024-05-06 15:08 ` [PATCH 08/13] dt-bindings: pinctrl: qcom,pmic-gpio: drop pm8008 Johan Hovold
2024-05-07 6:41 ` Krzysztof Kozlowski
2024-05-08 22:06 ` Stephen Boyd
2024-05-06 15:08 ` [PATCH 09/13] pinctrl: qcom: spmi-gpio: drop broken pm8008 support Johan Hovold
2024-05-08 17:43 ` Bryan O'Donoghue
2024-05-08 22:06 ` Stephen Boyd
2024-05-27 13:35 ` Linus Walleij
2024-05-29 16:12 ` Johan Hovold
2024-05-06 15:08 ` [PATCH 10/13] dt-bindings: mfd: pm8008: rework binding Johan Hovold
2024-05-07 6:43 ` Krzysztof Kozlowski
2024-05-07 15:23 ` Johan Hovold
2024-05-08 22:09 ` Stephen Boyd
2024-05-09 6:57 ` Krzysztof Kozlowski
2024-05-06 15:08 ` [PATCH 11/13] mfd: pm8008: rework driver Johan Hovold
2024-05-06 19:18 ` Andy Shevchenko
2024-05-09 9:42 ` Johan Hovold
2024-05-10 13:15 ` Andy Shevchenko
2024-05-22 6:49 ` Johan Hovold
2024-05-22 7:13 ` Andy Shevchenko
2024-05-22 8:00 ` Johan Hovold
2024-05-08 17:56 ` Bryan O'Donoghue
2024-05-06 15:08 ` [PATCH 12/13] regulator: add pm8008 pmic regulator driver Johan Hovold
2024-05-06 19:09 ` Andy Shevchenko [this message]
2024-05-07 15:44 ` Johan Hovold
2024-05-07 17:22 ` Andy Shevchenko
2024-05-07 18:14 ` Krzysztof Kozlowski
2024-05-09 8:57 ` Johan Hovold
2024-05-09 10:48 ` Krzysztof Kozlowski
2024-05-09 12:26 ` Johan Hovold
2024-05-17 9:15 ` Krzysztof Kozlowski
2024-05-08 11:41 ` Mark Brown
2024-05-09 8:53 ` Johan Hovold
2024-05-09 13:24 ` Andy Shevchenko
2024-05-14 13:43 ` Satya Priya Kakitapalli
2024-05-14 22:14 ` Konrad Dybcio
2024-05-29 16:04 ` Johan Hovold
2024-05-14 14:04 ` Satya Priya Kakitapalli
2024-05-14 14:18 ` Andy Shevchenko
2024-05-14 15:04 ` Satya Priya Kakitapalli (Temp)
2024-05-14 16:04 ` Andy Shevchenko
2024-05-07 11:48 ` Konrad Dybcio
2024-05-07 15:52 ` Johan Hovold
2024-05-08 17:55 ` Bryan O'Donoghue
2024-05-08 22:37 ` Stephen Boyd
2024-05-09 9:10 ` Johan Hovold
2024-05-29 15:55 ` Johan Hovold
2024-05-09 12:07 ` Andy Shevchenko
2024-05-09 12:20 ` Johan Hovold
2024-05-06 15:08 ` [PATCH 13/13] arm64: dts: qcom: sc8280xp-x13s: enable pm8008 camera pmic Johan Hovold
2024-05-08 17:53 ` Bryan O'Donoghue
2024-05-06 20:40 ` [PATCH 00/13] " Rob Herring (Arm)
2024-05-09 8:42 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zjkq_nWyvc6bUtiu@surfacebook.localdomain \
--to=andy.shevchenko@gmail.com \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_c_skakit@quicinc.com \
--cc=quic_gurus@quicinc.com \
--cc=robh@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).