From: Andrea della Porta <andrea.porta@suse.com>
To: Florian Fainelli <florian.fainelli@broadcom.com>
Cc: Andrea della Porta <andrea.porta@suse.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Kamal Dasu <kamal.dasu@broadcom.com>,
Al Cooper <alcooperx@gmail.com>, Eric Anholt <eric@anholt.net>,
Stefan Wahren <wahrenst@gmx.net>,
devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org
Subject: Re: [PATCH v2 4/4] arm64: dts: broadcom: Add support for BCM2712
Date: Thu, 16 May 2024 10:36:27 +0200 [thread overview]
Message-ID: <ZkXFi6_2DkXRNgSL@apocalypse> (raw)
In-Reply-To: <786bbf35-e9fe-445c-b6f9-21119e60fb34@broadcom.com>
On 09:14 Fri 10 May , Florian Fainelli wrote:
> On 5/10/24 07:35, Andrea della Porta wrote:
>
> This should be #size-cells = <2> to be future proof and support over 4GB of
> DRAM, because the DDR controller and the memory map on that chip have been
> designed with that requirement.
>
> > +
> > + interrupt-parent = <&gicv2>;
> > +
> > + axi: axi {
> > + compatible = "simple-bus";
> > + #address-cells = <2>;
> > + #size-cells = <1>;
> > + ranges;
>
> The AXI peripheral window should be defined in the ranges property. The
> aperture is from 0x10_0000_0000 to 0x10_3FFF_FFFF.
>
> From that point on you can define all peripherals under the axi node to be
> relative to that axi aperture, just like what you did for the legacy Pi
> peripherals in the subsequent bus node.
This doesn't seem to match with what I have here:
- some axi peripherals goes beyond 0x10_3FFF_FFFF (e.g. the interrupt
controller is @0x107fff9000)
- downstream dts have that ranges going from 0x10 0x00000000 0x11 0x00000000,
so to span all the peripheral (included e.g. the above int controller)
- another comment in downstream dts says: // 10_00000000-1x_xxxxxxxx = up to
64GB system RAM
I'm a little confused here, of course we could also define multiple ranges
but I don't really know what the boundaries are. Anyway, I would opt for the
extended range (0x10 0x00000000 - 0x11 0x00000000) unless there is concern
about it. Any thoughts?
Many thanks,
Andrea
next prev parent reply other threads:[~2024-05-16 8:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 14:35 [PATCH v2 0/4] Add minimal boot support for Raspberry Pi 5 Andrea della Porta
2024-05-10 14:35 ` [PATCH v2 1/4] dt-bindings: arm: bcm: Add BCM2712 SoC support Andrea della Porta
2024-05-10 18:40 ` Stefan Wahren
2024-05-10 21:33 ` Conor Dooley
2024-05-20 13:37 ` Krzysztof Kozlowski
2024-05-10 14:35 ` [PATCH v2 2/4] dt-bindings: mmc: Add support for BCM2712 SD host controller Andrea della Porta
2024-05-10 19:01 ` Stefan Wahren
2024-05-13 18:58 ` Rob Herring
2024-05-10 14:35 ` [PATCH v2 3/4] mmc: sdhci-brcmstb: Add BCM2712 support Andrea della Porta
2024-05-10 19:22 ` Stefan Wahren
2024-05-10 14:35 ` [PATCH v2 4/4] arm64: dts: broadcom: Add support for BCM2712 Andrea della Porta
2024-05-10 16:13 ` Marc Zyngier
2024-05-10 16:14 ` Florian Fainelli
2024-05-16 8:36 ` Andrea della Porta [this message]
2024-05-20 18:03 ` Florian Fainelli
2024-05-10 19:43 ` Stefan Wahren
2024-05-13 13:27 ` [PATCH v2 0/4] Add minimal boot support for Raspberry Pi 5 Rob Herring (Arm)
2024-05-16 10:32 ` Andrea della Porta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZkXFi6_2DkXRNgSL@apocalypse \
--to=andrea.porta@suse.com \
--cc=adrian.hunter@intel.com \
--cc=alcooperx@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eric@anholt.net \
--cc=florian.fainelli@broadcom.com \
--cc=kamal.dasu@broadcom.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=rjui@broadcom.com \
--cc=robh@kernel.org \
--cc=sbranden@broadcom.com \
--cc=ulf.hansson@linaro.org \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).