From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
cros-qcom-dts-watchers@chromium.org,
Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 00/31] Clean up thermal zone polling-delay
Date: Fri, 10 May 2024 13:49:56 +0100 [thread overview]
Message-ID: <b4dba1d5-448a-4a4b-94d5-f27c6ff0010d@linaro.org> (raw)
In-Reply-To: <20240510-topic-msm-polling-cleanup-v2-0-436ca4218da2@linaro.org>
On 10/05/2024 12:59, Konrad Dybcio wrote:
> A trivial follow-up on the changes introduced in Commit 488164006a28
> ("thermal/of: Assume polling-delay(-passive) 0 when absent").
>
> Should probably wait until v6.9-rc1 so that the patch in question is
> in the base tree, otherwise TZs will fail to register.
>
> FWIW, Compile-tested only (except 8280).
>
> To: Bjorn Andersson <andersson@kernel.org>
> To: Rob Herring <robh@kernel.org>
> To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> To: Conor Dooley <conor+dt@kernel.org>
> To: cros-qcom-dts-watchers@chromium.org
> To: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: devicetree@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>
> Changes in v2:
> - Un-drop passive delays. Whether they're useful where they're enabled
> is a topic for another patchset, as it requires examination on a case-
> -by-case basis.
> - Better unify the style (newlines between properties)
> - Link to v1: https://lore.kernel.org/r/20240319-topic-msm-polling-cleanup-v1-0-e0aee1dbcd78@linaro.org
So perhaps you can answer the question I have.
Right now, we have non-zero delay values, doesn't this mean the thermal
framework driver has a delay between evaluating dT/dt values per
Documentation/devicetree/bindings/thermal/thermal-zones.yaml
Your commit log implies or my reading of it is, there's no functional
change because its currently driven by an IRQ but, is that actually _so_
with non-zero values in the DT?
---
bod
prev parent reply other threads:[~2024-05-10 12:49 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 11:59 [PATCH v2 00/31] Clean up thermal zone polling-delay Konrad Dybcio
2024-05-10 11:59 ` [PATCH v2 01/31] arm64: dts: qcom: ipq6018-*: Remove thermal zone polling delays Konrad Dybcio
2024-05-10 11:59 ` [PATCH v2 02/31] arm64: dts: qcom: ipq8074-*: " Konrad Dybcio
2024-05-10 11:59 ` [PATCH v2 03/31] arm64: dts: qcom: ipq9574-*: " Konrad Dybcio
2024-05-10 11:59 ` [PATCH v2 04/31] arm64: dts: qcom: msm8916-*: " Konrad Dybcio
2024-05-10 11:59 ` [PATCH v2 05/31] arm64: dts: qcom: msm8939-*: " Konrad Dybcio
2024-05-10 11:59 ` [PATCH v2 06/31] arm64: dts: qcom: msm8953-*: " Konrad Dybcio
2024-05-10 11:59 ` [PATCH v2 07/31] arm64: dts: qcom: msm8976-*: " Konrad Dybcio
2024-05-10 11:59 ` [PATCH v2 08/31] arm64: dts: qcom: msm8996-*: " Konrad Dybcio
2024-05-10 11:59 ` [PATCH v2 09/31] arm64: dts: qcom: msm8998-*: " Konrad Dybcio
2024-05-10 11:59 ` [PATCH v2 10/31] arm64: dts: qcom: pm7550ba: " Konrad Dybcio
2024-05-10 11:59 ` [PATCH v2 11/31] arm64: dts: qcom: pms405: " Konrad Dybcio
2024-05-10 11:59 ` [PATCH v2 12/31] arm64: dts: qcom: pmx75: " Konrad Dybcio
2024-05-10 11:59 ` [PATCH v2 13/31] arm64: dts: qcom: qcm2290-*: " Konrad Dybcio
2024-05-10 11:59 ` [PATCH v2 14/31] arm64: dts: qcom: qcs404-*: " Konrad Dybcio
2024-05-10 11:59 ` [PATCH v2 15/31] arm64: dts: qcom: sa8775p-*: " Konrad Dybcio
2024-05-10 11:59 ` [PATCH v2 16/31] arm64: dts: qcom: sc7180-*: " Konrad Dybcio
2024-05-10 11:59 ` [PATCH v2 17/31] arm64: dts: qcom: sc7280-*: " Konrad Dybcio
2024-05-10 11:59 ` [PATCH v2 18/31] arm64: dts: qcom: sc8180x-*: " Konrad Dybcio
2024-05-10 11:59 ` [PATCH v2 19/31] arm64: dts: qcom: sc8280xp-*: " Konrad Dybcio
2024-05-10 11:59 ` [PATCH v2 20/31] arm64: dts: qcom: sdm660-*: " Konrad Dybcio
2024-05-10 11:59 ` [PATCH v2 21/31] arm64: dts: qcom: sdm845-*: " Konrad Dybcio
2024-05-10 11:59 ` [PATCH v2 22/31] arm64: dts: qcom: sm6115-*: " Konrad Dybcio
2024-05-10 11:59 ` [PATCH v2 23/31] arm64: dts: qcom: sm6125-*: " Konrad Dybcio
2024-05-10 11:59 ` [PATCH v2 24/31] arm64: dts: qcom: sm6350-*: " Konrad Dybcio
2024-05-10 11:59 ` [PATCH v2 25/31] arm64: dts: qcom: sm6375-*: " Konrad Dybcio
2024-05-10 11:59 ` [PATCH v2 26/31] arm64: dts: qcom: sm8150-*: " Konrad Dybcio
2024-05-10 11:59 ` [PATCH v2 27/31] arm64: dts: qcom: sm8250-*: " Konrad Dybcio
2024-05-10 11:59 ` [PATCH v2 28/31] arm64: dts: qcom: sm8350-*: " Konrad Dybcio
2024-05-10 11:59 ` [PATCH v2 29/31] arm64: dts: qcom: sm8450-*: " Konrad Dybcio
2024-05-10 11:59 ` [PATCH v2 30/31] arm64: dts: qcom: sm8550-*: " Konrad Dybcio
2024-05-10 11:59 ` [PATCH v2 31/31] arm64: dts: qcom: sm8650-*: " Konrad Dybcio
2024-05-10 12:47 ` Bryan O'Donoghue
2024-05-10 12:49 ` Bryan O'Donoghue [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4dba1d5-448a-4a4b-94d5-f27c6ff0010d@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).