From: Krzysztof Kozlowski <krzk@kernel.org>
To: Artur Weber <aweber.kernel@gmail.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
alsa-devel@alsa-project.org, linux-sound@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v2 7/7] ARM: dts: samsung: exynos4212-tab3: Fix up wm1811 codec config
Date: Thu, 9 May 2024 09:13:15 +0200 [thread overview]
Message-ID: <b8c82b1a-db57-4e89-9beb-63992744afe6@kernel.org> (raw)
In-Reply-To: <20240508-midas-wm1811-gpio-jack-v2-7-b4d36cd02c6e@gmail.com>
On 08/05/2024 12:58, Artur Weber wrote:
> Drop incorrect interrupt parent and add MCLK2 clock.
1. Separate patches.
2. Missing explanation why. "Incorrect" says a bit, but not too much.
Also, imprecise - you remove all interrupts, not just incorrect parent.
Please provide proper rationale, why this is not correct and information
that bluetooth 32 kHz clock feeds both bluetooth module and audio codec.
>
Best regards,
Krzysztof
prev parent reply other threads:[~2024-05-09 7:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 10:58 [PATCH v2 0/7] ASoC: samsung: midas-audio: Add GPIO-based headset jack detection Artur Weber
2024-05-08 10:58 ` [PATCH v2 1/7] ASoC: dt-bindings: samsung,midas-audio: Add headset mic bias supply Artur Weber
2024-05-08 10:58 ` [PATCH v2 2/7] ASoC: dt-bindings: samsung,midas-audio: Add GPIO-based headset jack detection Artur Weber
2024-05-08 12:52 ` Rob Herring (Arm)
2024-05-08 10:58 ` [PATCH v2 3/7] ASoC: samsung: midas_wm1811: Add headset mic bias supply support Artur Weber
2024-05-08 10:58 ` [PATCH v2 4/7] ASoC: samsung: midas_wm1811: Add GPIO-based headset jack detection Artur Weber
2024-05-08 10:58 ` [PATCH v2 5/7] ASoC: samsung: midas_wm1811: Use dev_err_probe where appropriate Artur Weber
2024-05-08 10:58 ` [PATCH v2 6/7] ARM: dts: samsung: exynos4212-tab3: Fix headset mic, add jack detection Artur Weber
2024-05-08 10:58 ` [PATCH v2 7/7] ARM: dts: samsung: exynos4212-tab3: Fix up wm1811 codec config Artur Weber
2024-05-09 7:13 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8c82b1a-db57-4e89-9beb-63992744afe6@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=alsa-devel@alsa-project.org \
--cc=aweber.kernel@gmail.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=tiwai@suse.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).