From: mr.nuke.me@gmail.com
To: "Devi Priya" <quic_devipriy@quicinc.com>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konrad.dybcio@linaro.org>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Vinod Koul" <vkoul@kernel.org>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-phy@lists.infradead.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v4 RESEND 0/8] ipq9574: Enable PCI-Express support
Date: Wed, 8 May 2024 12:10:01 -0500 [thread overview]
Message-ID: <c3f99ece-7f66-4c6f-a262-4d8894154ae9@gmail.com> (raw)
In-Reply-To: <569087fe-e675-41a4-b975-2d01d95b6d3c@quicinc.com>
On 5/8/24 1:16 AM, Devi Priya wrote:
>
>
> On 5/1/2024 9:58 AM, Alexandru Gagniuc wrote:
>> There are four PCIe ports on IPQ9574, pcie0 thru pcie3. This series
>> addresses pcie2, which is a gen3x2 port. The board I have only uses
>> pcie2, and that's the only one enabled in this series. pcie3 is added
>> as a special request, but is untested.
>>
>> I believe this makes sense as a monolithic series, as the individual
>> pieces are not that useful by themselves.
>
> Hi Alexandru,
>
> As Dmitry suggested, we are working on enabling the PCIe NOC clocks
> via Interconnect. We will be posting the PCIe series with
> Interconnect support [1] shortly.
I am generally very hesitant to depend on unmerged series, as this can
cause undue delays. In this particular case, I considered that both
series can continue to stay independent, with the ability to convert the
PCIe users to the new clock scheme when the time is right.
> [1] -
> https://lore.kernel.org/linux-arm-msm/20240430064214.2030013-1-quic_varada@quicinc.com/
What changes would be needed to this series to make use of this? How
does one use the "interconnected" clocks?
Alex
> Thanks,
> S.Devi Priya
>>
>> In v2, I've had some issues regarding the dt schema checks. For
>> transparency, I used the following test invocations to test:
>>
>> make dt_binding_check
>> DT_SCHEMA_FILES=qcom,pcie.yaml:qcom,ipq8074-qmp-pcie-phy.yaml
>> make dtbs_check
>> DT_SCHEMA_FILES=qcom,pcie.yaml:qcom,ipq8074-qmp-pcie-phy.yaml
>>
>> Changes since v3:
>> - "const"ify .hw.init fields for the PCIE pipe clocks
>> - Used pciephy_v5_regs_layout instead of v4 in phy-qcom-qmp-pcie.c
>> - Included Manivannan's patch for qcom-pcie.c clocks
>> - Dropped redundant comments in "ranges" and "interrupt-map" of pcie2.
>> - Added pcie3 and pcie3_phy dts nodes
>> - Moved snoc and anoc clocks to PCIe controller from PHY
>>
>> Changes since v2:
>> - reworked resets in qcom,pcie.yaml to resolve dt schema errors
>> - constrained "reg" in qcom,pcie.yaml
>> - reworked min/max intems in qcom,ipq8074-qmp-pcie-phy.yaml
>> - dropped msi-parent for pcie node, as it is handled by "msi" IRQ
>>
>> Changes since v1:
>> - updated new tables in phy-qcom-qmp-pcie.c to use lowercase hex
>> numbers
>> - reorganized qcom,ipq8074-qmp-pcie-phy.yaml to use a single list of
>> clocks
>> - reorganized qcom,pcie.yaml to include clocks+resets per compatible
>> - Renamed "pcie2_qmp_phy" label to "pcie2_phy"
>> - moved "ranges" property of pcie@20000000 higher up
>>
>> Alexandru Gagniuc (7):
>> dt-bindings: clock: Add PCIe pipe related clocks for IPQ9574
>> clk: qcom: gcc-ipq9574: Add PCIe pipe clocks
>> dt-bindings: PCI: qcom: Add IPQ9574 PCIe controller
>> PCI: qcom: Add support for IPQ9574
>> dt-bindings: phy: qcom,ipq8074-qmp-pcie: add ipq9574 gen3x2 PHY
>> phy: qcom-qmp-pcie: add support for ipq9574 gen3x2 PHY
>> arm64: dts: qcom: ipq9574: add PCIe2 and PCIe3 nodes
>>
>> Manivannan Sadhasivam (1):
>> PCI: qcom: Switch to devm_clk_bulk_get_all() API to get the clocks
>> from Devicetree
>>
>> .../devicetree/bindings/pci/qcom,pcie.yaml | 37 ++++
>> .../phy/qcom,ipq8074-qmp-pcie-phy.yaml | 1 +
>> arch/arm64/boot/dts/qcom/ipq9574.dtsi | 178 +++++++++++++++++-
>> drivers/clk/qcom/gcc-ipq9574.c | 76 ++++++++
>> drivers/pci/controller/dwc/pcie-qcom.c | 164 +++-------------
>> drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 136 ++++++++++++-
>> .../phy/qualcomm/phy-qcom-qmp-pcs-pcie-v5.h | 14 ++
>> include/dt-bindings/clock/qcom,ipq9574-gcc.h | 4 +
>> 8 files changed, 469 insertions(+), 141 deletions(-)
>>
next prev parent reply other threads:[~2024-05-08 17:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-01 4:28 [PATCH v4 RESEND 0/8] ipq9574: Enable PCI-Express support Alexandru Gagniuc
2024-05-01 4:28 ` [PATCH v4 RESEND 1/8] dt-bindings: clock: Add PCIe pipe related clocks for IPQ9574 Alexandru Gagniuc
2024-05-01 4:28 ` [PATCH v4 RESEND 2/8] clk: qcom: gcc-ipq9574: Add PCIe pipe clocks Alexandru Gagniuc
2024-05-01 4:28 ` [PATCH v4 RESEND 3/8] dt-bindings: PCI: qcom: Add IPQ9574 PCIe controller Alexandru Gagniuc
2024-05-01 4:28 ` [PATCH v4 RESEND 4/8] PCI: qcom: Switch to devm_clk_bulk_get_all() API to get the clocks from Devicetree Alexandru Gagniuc
2024-05-11 6:35 ` Manivannan Sadhasivam
2024-05-14 7:51 ` Manivannan Sadhasivam
2024-05-01 4:28 ` [PATCH v4 RESEND 5/8] PCI: qcom: Add support for IPQ9574 Alexandru Gagniuc
2024-05-01 10:21 ` Krzysztof Kozlowski
2024-05-01 15:43 ` mr.nuke.me
2024-05-01 16:43 ` Krzysztof Kozlowski
2024-05-11 6:39 ` Manivannan Sadhasivam
2024-05-01 4:28 ` [PATCH v4 RESEND 6/8] dt-bindings: phy: qcom,ipq8074-qmp-pcie: add ipq9574 gen3x2 PHY Alexandru Gagniuc
2024-05-01 4:28 ` [PATCH v4 RESEND 7/8] phy: qcom-qmp-pcie: add support for " Alexandru Gagniuc
2024-05-01 4:28 ` [PATCH v4 RESEND 8/8] arm64: dts: qcom: ipq9574: add PCIe2 and PCIe3 nodes Alexandru Gagniuc
2024-05-01 20:32 ` Alex G.
2024-05-01 10:22 ` [PATCH v4 RESEND 0/8] ipq9574: Enable PCI-Express support Krzysztof Kozlowski
2024-05-01 15:37 ` mr.nuke.me
2024-05-08 6:16 ` Devi Priya
2024-05-08 17:10 ` mr.nuke.me [this message]
2024-05-12 8:35 ` Devi Priya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3f99ece-7f66-4c6f-a262-4d8894154ae9@gmail.com \
--to=mr.nuke.me@gmail.com \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kishon@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mturquette@baylibre.com \
--cc=quic_devipriy@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).